From: Robin Murphy <robin.murphy@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH 0/2] irqchip/gic*: Complain about the use of IRQ_TYPE_NONE
Date: Fri, 16 Mar 2018 16:19:44 +0000 [thread overview]
Message-ID: <5f274a06-3a9c-7d41-2e4d-9733e4ac6078@arm.com> (raw)
In-Reply-To: <20180316145511.28362-1-marc.zyngier@arm.com>
On 16/03/18 14:55, Marc Zyngier wrote:
> Grepping through the dts files, the documentation, and reviewing
> patches, one can only notice the use of IRQ_TYPE_NONE in interrupt
> specifiers. At least for the GIC, this doesn't mean anything. The
> unsuspecting driver will end-up with whatever was there before, and
> there is a 50% probability that it is not what it wants.
>
> I'd love to fix it myself, but I also have a 50% probability of
> getting it wrong. In order to make the user aware they are walking on
> thin ice, let's add some warnings. Hopefully, they'll be annoying
> enough that people will fix their firmware. Croudsourcing debugging...
I guess there's also the alternative nuclear option of breaking their
build ;)
Robin.
----->8-----
diff --git a/include/dt-bindings/interrupt-controller/irq.h
b/include/dt-bindings/interrupt-controller/irq.h
index a8b310555f14..de79af80d01e 100644
--- a/include/dt-bindings/interrupt-controller/irq.h
+++ b/include/dt-bindings/interrupt-controller/irq.h
@@ -10,7 +10,7 @@
#ifndef _DT_BINDINGS_INTERRUPT_CONTROLLER_IRQ_H
#define _DT_BINDINGS_INTERRUPT_CONTROLLER_IRQ_H
-#define IRQ_TYPE_NONE 0
+#define IRQ_TYPE_NONE "This is nonsense and needs fixing"
#define IRQ_TYPE_EDGE_RISING 1
#define IRQ_TYPE_EDGE_FALLING 2
#define IRQ_TYPE_EDGE_BOTH (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING)
WARNING: multiple messages have this Message-ID (diff)
From: robin.murphy@arm.com (Robin Murphy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] irqchip/gic*: Complain about the use of IRQ_TYPE_NONE
Date: Fri, 16 Mar 2018 16:19:44 +0000 [thread overview]
Message-ID: <5f274a06-3a9c-7d41-2e4d-9733e4ac6078@arm.com> (raw)
In-Reply-To: <20180316145511.28362-1-marc.zyngier@arm.com>
On 16/03/18 14:55, Marc Zyngier wrote:
> Grepping through the dts files, the documentation, and reviewing
> patches, one can only notice the use of IRQ_TYPE_NONE in interrupt
> specifiers. At least for the GIC, this doesn't mean anything. The
> unsuspecting driver will end-up with whatever was there before, and
> there is a 50% probability that it is not what it wants.
>
> I'd love to fix it myself, but I also have a 50% probability of
> getting it wrong. In order to make the user aware they are walking on
> thin ice, let's add some warnings. Hopefully, they'll be annoying
> enough that people will fix their firmware. Croudsourcing debugging...
I guess there's also the alternative nuclear option of breaking their
build ;)
Robin.
----->8-----
diff --git a/include/dt-bindings/interrupt-controller/irq.h
b/include/dt-bindings/interrupt-controller/irq.h
index a8b310555f14..de79af80d01e 100644
--- a/include/dt-bindings/interrupt-controller/irq.h
+++ b/include/dt-bindings/interrupt-controller/irq.h
@@ -10,7 +10,7 @@
#ifndef _DT_BINDINGS_INTERRUPT_CONTROLLER_IRQ_H
#define _DT_BINDINGS_INTERRUPT_CONTROLLER_IRQ_H
-#define IRQ_TYPE_NONE 0
+#define IRQ_TYPE_NONE "This is nonsense and needs fixing"
#define IRQ_TYPE_EDGE_RISING 1
#define IRQ_TYPE_EDGE_FALLING 2
#define IRQ_TYPE_EDGE_BOTH (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING)
next prev parent reply other threads:[~2018-03-16 16:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 14:55 [PATCH 0/2] irqchip/gic*: Complain about the use of IRQ_TYPE_NONE Marc Zyngier
2018-03-16 14:55 ` Marc Zyngier
2018-03-16 14:55 ` [PATCH 1/2] irqchip/gic: Loudly complain " Marc Zyngier
2018-03-16 14:55 ` Marc Zyngier
2018-03-16 14:55 ` [PATCH 2/2] irqchip/gic-v3: " Marc Zyngier
2018-03-16 14:55 ` Marc Zyngier
2018-10-17 18:24 ` Doug Anderson
2018-10-17 18:24 ` Doug Anderson
2018-03-16 16:19 ` Robin Murphy [this message]
2018-03-16 16:19 ` [PATCH 0/2] irqchip/gic*: Complain " Robin Murphy
2018-03-16 16:39 ` Marc Zyngier
2018-03-16 16:39 ` Marc Zyngier
2018-03-16 16:46 ` Robin Murphy
2018-03-16 16:46 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f274a06-3a9c-7d41-2e4d-9733e4ac6078@arm.com \
--to=robin.murphy@arm.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.