All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: iommu@lists.linux.dev, linux-kselftest@vger.kernel.org
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
	Kevin Tian <kevin.tian@intel.com>,
	kvm@vger.kernel.org, Lixiao Yang <lixiao.yang@intel.com>,
	Matthew Rosato <mjrosato@linux.ibm.com>,
	Nicolin Chen <nicolinc@nvidia.com>, Yi Liu <yi.l.liu@intel.com>
Subject: [PATCH v8 06/19] iommufd: Use the iommufd_group to avoid duplicate MSI setup
Date: Mon, 17 Jul 2023 15:12:02 -0300	[thread overview]
Message-ID: <6-v8-6659224517ea+532-iommufd_alloc_jgg@nvidia.com> (raw)
In-Reply-To: <0-v8-6659224517ea+532-iommufd_alloc_jgg@nvidia.com>

This only needs to be done once per group, not once per device. The once
per device was a way to make the device list work. Since we are abandoning
this we can optimize things a bit.

Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Tested-by: Nicolin Chen <nicolinc@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/iommu/iommufd/device.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c
index 83bd6b751a9799..b2504c612a37b7 100644
--- a/drivers/iommu/iommufd/device.c
+++ b/drivers/iommu/iommufd/device.c
@@ -318,10 +318,6 @@ int iommufd_hw_pagetable_attach(struct iommufd_hw_pagetable *hwpt,
 	if (rc)
 		goto err_unlock;
 
-	rc = iommufd_device_setup_msi(idev, hwpt, sw_msi_start);
-	if (rc)
-		goto err_unresv;
-
 	/*
 	 * Only attach to the group once for the first device that is in the
 	 * group. All the other devices will follow this attachment. The user
@@ -330,6 +326,10 @@ int iommufd_hw_pagetable_attach(struct iommufd_hw_pagetable *hwpt,
 	 * attachment.
 	 */
 	if (list_empty(&idev->igroup->device_list)) {
+		rc = iommufd_device_setup_msi(idev, hwpt, sw_msi_start);
+		if (rc)
+			goto err_unresv;
+
 		rc = iommu_attach_group(hwpt->domain, idev->igroup->group);
 		if (rc)
 			goto err_unresv;
-- 
2.41.0


  parent reply	other threads:[~2023-07-17 18:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 18:11 [PATCH v8 00/19] Add iommufd physical device operations for replace and alloc hwpt Jason Gunthorpe
2023-07-17 18:11 ` [PATCH v8 01/19] iommufd: Move isolated msi enforcement to iommufd_device_bind() Jason Gunthorpe
2023-07-17 18:11 ` [PATCH v8 02/19] iommufd: Add iommufd_group Jason Gunthorpe
2023-07-17 18:11 ` [PATCH v8 03/19] iommufd: Replace the hwpt->devices list with iommufd_group Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 04/19] iommu: Export iommu_get_resv_regions() Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 05/19] iommufd: Keep track of each device's reserved regions instead of groups Jason Gunthorpe
2023-07-17 18:12 ` Jason Gunthorpe [this message]
2023-07-17 18:12 ` [PATCH v8 07/19] iommufd: Make sw_msi_start a group global Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 08/19] iommufd: Move putting a hwpt to a helper function Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 09/19] iommufd: Add enforced_cache_coherency to iommufd_hw_pagetable_alloc() Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 10/19] iommufd: Allow a hwpt to be aborted after allocation Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 11/19] iommufd: Fix locking around hwpt allocation Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 12/19] iommufd: Reorganize iommufd_device_attach into iommufd_device_change_pt Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 13/19] iommu: Introduce a new iommu_group_replace_domain() API Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 14/19] iommufd: Add iommufd_device_replace() Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 15/19] iommufd: Make destroy_rwsem use a lock class per object type Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 16/19] iommufd/selftest: Test iommufd_device_replace() Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 17/19] iommufd: Add IOMMU_HWPT_ALLOC Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 18/19] iommufd/selftest: Return the real idev id from selftest mock_domain Jason Gunthorpe
2023-07-17 18:12 ` [PATCH v8 19/19] iommufd/selftest: Add a selftest for IOMMU_HWPT_ALLOC Jason Gunthorpe
2023-07-26 13:37 ` [PATCH v8 00/19] Add iommufd physical device operations for replace and alloc hwpt Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6-v8-6659224517ea+532-iommufd_alloc_jgg@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lixiao.yang@intel.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=nicolinc@nvidia.com \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.