From: Aarushi Mehta <mehta.aaru20@gmail.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>,
Julia Suvorova <jusual@mail.ru>
Subject: [Qemu-devel] [PATCH v2] trivial fix of malloc to g_new in thunk
Date: Thu, 28 Feb 2019 21:05:41 +0530 [thread overview]
Message-ID: <60952760a82dc603b836ca41fd0f9b1325cad635.camel@gmail.com> (raw)
Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
---
Note that since thunking occurs throughout the lifetime of the QEMU instance,
there is no matching 'free' to correct
It might be valuable to edit the BiteSizedTasks to reflect that g_new is favoured over g_malloc
thunk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/thunk.c b/thunk.c
index d5d8645cd4..17f3d320bb 100644
--- a/thunk.c
+++ b/thunk.c
@@ -89,7 +89,7 @@ void thunk_register_struct(int id, const char *name, const argtype *types)
for(i = 0;i < 2; i++) {
offset = 0;
max_align = 1;
- se->field_offsets[i] = malloc(nb_fields * sizeof(int));
+ se->field_offsets[i] = g_new(int, nb_fields);
type_ptr = se->field_types;
for(j = 0;j < nb_fields; j++) {
size = thunk_type_size(type_ptr, i);
--
2.17.1
Regards
Aarushi Mehta
next reply other threads:[~2019-02-28 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 15:35 Aarushi Mehta [this message]
2019-02-28 16:03 ` [Qemu-devel] [PATCH v2] trivial fix of malloc to g_new in thunk Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60952760a82dc603b836ca41fd0f9b1325cad635.camel@gmail.com \
--to=mehta.aaru20@gmail.com \
--cc=jusual@mail.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.