All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lv Zheng <lv.zheng@intel.com>
To: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Len Brown <len.brown@intel.com>
Cc: Lv Zheng <lv.zheng@intel.com>, Lv Zheng <zetalog@gmail.com>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [PATCH v4 3/3] ACPI / EC: Enable noirq stage event detection
Date: Thu, 31 Aug 2017 16:10:37 +0800	[thread overview]
Message-ID: <64a875783cf29f651261ba7e881cc5ac5c5e0c4b.1504166863.git.lv.zheng@intel.com> (raw)
In-Reply-To: <cover.1504166863.git.lv.zheng@intel.com>

This patch enables noirq stage event detection for the EC driver.

EC is a very special driver, required to detecting events throughout the
entire suspend/resume process. Thus this patch enables event detection for
EC during noirq stages to meet this requirement. This is done by making
sure that the EC sleep APIs:
  acpi_ec_block_transactions()
  acpi_ec_unblock_transactions()
rather than the EC driver suspend/resume hooks:
  acpi_ec_suspend()
  acpi_ec_resume()
are the boundary of the EC event handling during suspend/resume, so that
the ACPI sleep core can tune their invocation timing to handle special BIOS
requirements.

If this commit is bisected to be a regression culprit, please report this
to bugzilla.kernel.org for further investigation.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=196129
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Tested-by: Tomislav Ivek <tomislav.ivek@gmail.com>
---
 drivers/acpi/ec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 9363656..36ce5e7 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -157,7 +157,7 @@ static bool ec_no_wakeup __read_mostly;
 module_param(ec_no_wakeup, bool, 0644);
 MODULE_PARM_DESC(ec_no_wakeup, "Do not wake up from suspend-to-idle");
 
-static bool ec_detect_noirq_events __read_mostly;
+static bool ec_detect_noirq_events __read_mostly = true;
 module_param(ec_detect_noirq_events, bool, 0644);
 MODULE_PARM_DESC(ec_detect_noirq_events, "Enabling event detection during noirq stage");
 
-- 
2.7.4

  parent reply	other threads:[~2017-08-31  8:10 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27  7:55 [PATCH 1/3] ACPI / EC: Cleanup EC GPE mask flag Lv Zheng
2017-07-27  7:55 ` [PATCH 2/3] ACPI: EC: Add IRQ polling support for noirq stages Lv Zheng
2017-07-27  7:55 ` [PATCH 3/3] ACPI: EC: Enable noirq stage GPE polling Lv Zheng
2017-07-31  5:47 ` [PATCH v2 0/4] ACPI / EC: Solve EC event handling issues Lv Zheng
2017-07-31  5:47   ` [PATCH v2 1/4] ACPI / EC: Cleanup EC GPE mask flag Lv Zheng
2017-07-31  5:47   ` [PATCH v2 2/4] ACPI / EC: Add IRQ polling support for noirq stages Lv Zheng
2017-07-31  5:48   ` [PATCH v2 3/4] ACPI / EC: Add support to handle EC events earlier Lv Zheng
2017-07-31  5:48   ` [PATCH v2 4/4] ACPI / EC: Enable noirq stage GPE polling Lv Zheng
2017-08-11  6:36 ` [PATCH v3 0/4] ACPI / EC: Poll more EC events during suspend/resume Lv Zheng
2017-08-11  6:36   ` [PATCH v3 1/4] ACPI / EC: Cleanup EC GPE mask flag Lv Zheng
2017-08-22 13:17     ` Rafael J. Wysocki
2017-08-23  4:19       ` Zheng, Lv
2017-08-11  6:36   ` [PATCH v3 2/4] ACPI / EC: Add IRQ polling support for noirq stages Lv Zheng
2017-08-11  6:36   ` [PATCH v3 3/4] ACPI / EC: Add support to handle EC events earlier Lv Zheng
2017-08-11  6:36   ` [PATCH v3 4/4] ACPI / EC: Enable noirq stage GPE polling Lv Zheng
2017-08-31  8:10 ` [PATCH v4 0/3] ACPI / EC: Fix EC event handling issues Lv Zheng
2017-08-31  8:10   ` [PATCH v4 1/3] ACPI / EC: Fix possible driver order issue by moving EC event handling earlier Lv Zheng
2017-08-31  8:10   ` [PATCH v4 2/3] ACPI / EC: Add event detection support for noirq stages Lv Zheng
2017-08-31  8:10   ` Lv Zheng [this message]
2017-09-26  7:52   ` [PATCH v4 0/3] ACPI / EC: Fix EC event handling issues Zheng, Lv
2017-09-29  2:50 ` [RFC PATCH v6 0/3] ACPI / EC: Tune the timing of EC events arrival during S3-exit Lv Zheng
2017-09-29  2:50   ` [RFC PATCH v6 1/3] ACPI / EC: Fix possible driver order issue by moving EC event handling earlier Lv Zheng
2017-11-22 12:52     ` Zhang, Rui
2017-11-22 12:52       ` Zhang, Rui
2017-11-24  1:20       ` Zheng, Lv
2017-11-27  8:56         ` Benjamin Tissoires
2017-09-29  2:50   ` [RFC PATCH v6 2/3] ACPI / EC: Add event detection support for noirq stages Lv Zheng
2017-11-22 12:43     ` Zhang, Rui
2017-11-22 12:43       ` Zhang, Rui
2017-09-29  2:50   ` [RFC PATCH v6 3/3] ACPI / EC: Enable noirq stage event detection Lv Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64a875783cf29f651261ba7e881cc5ac5c5e0c4b.1504166863.git.lv.zheng@intel.com \
    --to=lv.zheng@intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=zetalog@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.