All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: broonie@kernel.org
Cc: moinejf@free.fr, alsa-devel@alsa-project.org,
	kuninori.morimoto.gx@renesas.com, tiwai@suse.de,
	lgirdwood@gmail.com, jsarha@ti.com
Subject: [PATCH 2/3] ASoC: simple-card: Simplify error msg in simple_card_dai_link_of()
Date: Thu, 24 Apr 2014 19:13:59 +0800	[thread overview]
Message-ID: <64f9e48d758f3d3dd7bc806cef54df8aad8ac280.1398337861.git.Guangyu.Chen@freescale.com> (raw)
In-Reply-To: <cover.1398337861.git.Guangyu.Chen@freescale.com>

It would look better to use prop instead.

Signed-off-by: Nicolin Chen <Guangyu.Chen@freescale.com>
---
 sound/soc/generic/simple-card.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
index 383a4a1..c091557 100644
--- a/sound/soc/generic/simple-card.c
+++ b/sound/soc/generic/simple-card.c
@@ -166,8 +166,7 @@ static int simple_card_dai_link_of(struct device_node *node,
 	np = of_get_child_by_name(node, prop);
 	if (!np) {
 		ret = -EINVAL;
-		dev_err(dev, "%s: Can't find simple-audio-card,cpu DT node\n",
-			__func__);
+		dev_err(dev, "%s: Can't find %s DT node\n", __func__, prop);
 		goto dai_link_of_err;
 	}
 
@@ -198,8 +197,7 @@ static int simple_card_dai_link_of(struct device_node *node,
 	np = of_get_child_by_name(node, prop);
 	if (!np) {
 		ret = -EINVAL;
-		dev_err(dev, "%s: Can't find simple-audio-card,codec DT node\n",
-			__func__);
+		dev_err(dev, "%s: Can't find %s DT node\n", __func__, prop);
 		goto dai_link_of_err;
 	}
 
-- 
1.8.4

  parent reply	other threads:[~2014-04-24 11:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24 11:13 [PATCH 0/3] Fix some minor issues in simple card driver Nicolin Chen
2014-04-24 11:13 ` [PATCH 1/3] ASoC: simple-card: Drop node->name checking Nicolin Chen
2014-04-24 12:47   ` Jyri Sarha
2014-04-24 13:03     ` Mark Brown
2014-04-24 13:05       ` Jyri Sarha
2014-04-24 11:13 ` Nicolin Chen [this message]
2014-04-24 11:14 ` [PATCH 3/3] ASoC: simple-card: Improve coding style Nicolin Chen
2014-04-24 12:20 ` [PATCH 0/3] Fix some minor issues in simple card driver Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64f9e48d758f3d3dd7bc806cef54df8aad8ac280.1398337861.git.Guangyu.Chen@freescale.com \
    --to=guangyu.chen@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jsarha@ti.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=moinejf@free.fr \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.