All of lore.kernel.org
 help / color / mirror / Atom feed
From: alison.schofield@intel.com
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
	nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
	Dave Jiang <dave.jiang@intel.com>
Subject: [ndctl PATCH v10 3/7] cxl/event_trace: add a private context for private parsers
Date: Wed,  6 Mar 2024 10:42:22 -0800	[thread overview]
Message-ID: <6e975df49a62cdb544791633fdd1a998a0b60164.1709748564.git.alison.schofield@intel.com> (raw)
In-Reply-To: <cover.1709748564.git.alison.schofield@intel.com>

From: Alison Schofield <alison.schofield@intel.com>

CXL event tracing provides helpers to iterate through a trace
buffer and extract events of interest. It offers two parsing
options: a default parser that adds every field of an event to
a json object, and a private parsing option where the caller can
parse each event as it wishes.

Although the private parser can do some conditional parsing based
on field values, it has no method to receive additional information
needed to make parsing decisions in the callback.

Add a private_ctx field to the existing 'struct event_context'.
Replace the jlist_head parameter, used in the default parser,
with the private_ctx.

This is in preparation for adding a private parser requiring
additional context for cxl_poison events.

Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
---
 cxl/event_trace.c | 2 +-
 cxl/event_trace.h | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/cxl/event_trace.c b/cxl/event_trace.c
index 93a95f9729fd..bdad0c19dbd4 100644
--- a/cxl/event_trace.c
+++ b/cxl/event_trace.c
@@ -221,7 +221,7 @@ static int cxl_event_parse(struct tep_event *event, struct tep_record *record,
 
 	if (event_ctx->parse_event)
 		return event_ctx->parse_event(event, record,
-					      &event_ctx->jlist_head);
+					      event_ctx->private_ctx);
 
 	return cxl_event_to_json(event, record, &event_ctx->jlist_head);
 }
diff --git a/cxl/event_trace.h b/cxl/event_trace.h
index 7f7773b2201f..ec61962abbc6 100644
--- a/cxl/event_trace.h
+++ b/cxl/event_trace.h
@@ -16,8 +16,9 @@ struct event_ctx {
 	struct list_head jlist_head;
 	const char *event_name; /* optional */
 	int event_pid; /* optional */
+	void *private_ctx; /* required with parse_event() */
 	int (*parse_event)(struct tep_event *event, struct tep_record *record,
-			   struct list_head *jlist_head); /* optional */
+			   void *private_ctx);/* optional */
 };
 
 int cxl_parse_events(struct tracefs_instance *inst, struct event_ctx *ectx);
-- 
2.37.3


  parent reply	other threads:[~2024-03-06 18:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 18:42 [ndctl PATCH v10 0/7] Support poison list retrieval alison.schofield
2024-03-06 18:42 ` [ndctl PATCH v10 1/7] libcxl: add interfaces for GET_POISON_LIST mailbox commands alison.schofield
2024-03-06 23:07   ` Dan Williams
2024-03-06 18:42 ` [ndctl PATCH v10 2/7] cxl: add an optional pid check to event parsing alison.schofield
2024-03-06 23:11   ` Dan Williams
2024-03-06 18:42 ` alison.schofield [this message]
2024-03-06 23:36   ` [ndctl PATCH v10 3/7] cxl/event_trace: add a private context for private parsers Dan Williams
2024-03-10 22:39     ` Alison Schofield
2024-03-06 18:42 ` [ndctl PATCH v10 4/7] cxl/event_trace: add helpers to retrieve tep fields by type alison.schofield
2024-03-06 23:53   ` Dan Williams
2024-03-08  4:06     ` Alison Schofield
2024-03-06 18:42 ` [ndctl PATCH v10 5/7] cxl/list: collect and parse media_error records alison.schofield
2024-03-07  0:50   ` Dan Williams
2024-03-06 18:42 ` [ndctl PATCH v10 6/7] cxl/list: add --media-errors option to cxl list alison.schofield
2024-03-07  1:09   ` Dan Williams
2024-03-06 18:42 ` [ndctl PATCH v10 7/7] cxl/test: add cxl-poison.sh unit test alison.schofield
2024-03-06 23:03 ` [ndctl PATCH v10 0/7] Support poison list retrieval Dan Williams
2024-03-08  3:58   ` Alison Schofield
2024-03-08  4:03     ` Dan Williams
2024-03-10 19:21   ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e975df49a62cdb544791633fdd1a998a0b60164.1709748564.git.alison.schofield@intel.com \
    --to=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.