All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	linux-usb@vger.kernel.org, Dmitry Bogdanov <d.bogdanov@yadro.com>,
	Mike Christie <michael.christie@oracle.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Roman Bolshakov <r.bolshakov@yadro.com>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: [PATCH 21/36] usb: gadget: f_tcm: Handle multiple commands in parallel
Date: Wed, 06 Jul 2022 16:36:34 -0700	[thread overview]
Message-ID: <6f7b66be0db84fc5a362293dbff6674f19a5b311.1657149962.git.Thinh.Nguyen@synopsys.com> (raw)
In-Reply-To: <cover.1657149962.git.Thinh.Nguyen@synopsys.com>

Resubmit command on completion to fetch more commands and service them
in parallel. Increase the number of work in a queue. Each work will be
for each command allowing them to be processed concurrently. Also, set
them to be unbounded by cpu to improve performance.

Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
---
 drivers/usb/gadget/function/f_tcm.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
index 6e0b54985932..91d853682468 100644
--- a/drivers/usb/gadget/function/f_tcm.c
+++ b/drivers/usb/gadget/function/f_tcm.c
@@ -728,21 +728,16 @@ static int usbg_submit_command(struct f_uas *, struct usb_request *);
 static void uasp_cmd_complete(struct usb_ep *ep, struct usb_request *req)
 {
 	struct f_uas *fu = req->context;
-	int ret;
 
-	if (req->status < 0)
+	if (req->status == -ESHUTDOWN)
 		return;
 
-	ret = usbg_submit_command(fu, req);
-	/*
-	 * Once we tune for performance enqueue the command req here again so
-	 * we can receive a second command while we processing this one. Pay
-	 * attention to properly sync STAUS endpoint with DATA IN + OUT so you
-	 * don't break HS.
-	 */
-	if (!ret)
+	if (req->status < 0) {
+		usb_ep_queue(fu->ep_cmd, req, GFP_ATOMIC);
 		return;
-	usb_ep_queue(fu->ep_cmd, req, GFP_ATOMIC);
+	}
+
+	usbg_submit_command(fu, req);
 }
 
 static int uasp_alloc_stream_res(struct f_uas *fu, struct uas_stream *stream)
@@ -1357,7 +1352,8 @@ static struct se_portal_group *usbg_make_tpg(struct se_wwn *wwn,
 		goto unref_dep;
 	mutex_init(&tpg->tpg_mutex);
 	atomic_set(&tpg->tpg_port_count, 0);
-	tpg->workqueue = alloc_workqueue("tcm_usb_gadget", 0, 1);
+	tpg->workqueue = alloc_workqueue("tcm_usb_gadget",
+					 WQ_UNBOUND, WQ_UNBOUND_MAX_ACTIVE);
 	if (!tpg->workqueue)
 		goto free_tpg;
 
-- 
2.28.0


  parent reply	other threads:[~2022-07-06 23:36 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06 23:34 [PATCH 00/36] usb: gadget: f_tcm: Enhance UASP driver Thinh Nguyen
2022-07-06 23:34 ` [PATCH 01/36] target: Handle MI_REPORT_SUPPORTED_OPERATION_CODES Thinh Nguyen
2022-07-07  8:01   ` Oliver Neukum
2022-07-07 11:44   ` kernel test robot
2022-07-06 23:34 ` [PATCH 02/36] target: Add overlapped response to tmrsp_table Thinh Nguyen
2022-07-06 23:34 ` [PATCH 03/36] target: Don't drain empty list Thinh Nguyen
2022-07-07 12:42   ` Dmitry Bogdanov
2022-07-06 23:34 ` [PATCH 04/36] target: Does tmr notify on aborted command Thinh Nguyen
2022-07-07 12:56   ` Dmitry Bogdanov
2022-07-08 23:11     ` Thinh Nguyen
2022-07-11  9:44       ` Dmitry Bogdanov
2022-07-12  2:57         ` Thinh Nguyen
2022-07-11 10:31       ` Bodo Stroesser
2022-07-12  3:09         ` Thinh Nguyen
2022-07-06 23:34 ` [PATCH 05/36] target: Don't remove command too early Thinh Nguyen
2022-07-07 13:16   ` Dmitry Bogdanov
2022-07-08 23:40     ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 06/36] target: Return Function Complete Thinh Nguyen
2022-07-07 13:34   ` Dmitry Bogdanov
2022-07-08 23:51     ` Thinh Nguyen
2022-07-11  9:53       ` Dmitry Bogdanov
2022-07-06 23:35 ` [PATCH 07/36] target: Don't do tmr_notify on empty aborted list Thinh Nguyen
2022-07-07 13:36   ` Dmitry Bogdanov
2022-07-08 23:53     ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 08/36] target: Refactor core_tmr_abort_task Thinh Nguyen
2022-07-07 13:40   ` Dmitry Bogdanov
2022-07-09  0:02     ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 09/36] target: Add common Task Management values Thinh Nguyen
2022-07-07 19:36   ` Dmitry Bogdanov
2022-07-09  0:04     ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 10/36] target: Implement TMR_ABORT_TASK_SET Thinh Nguyen
2022-07-07 19:40   ` Dmitry Bogdanov
2022-07-08  9:50     ` Dmitry Bogdanov
2022-07-09  0:46       ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 11/36] target: Properly set Sense Data Length of CHECK CONDITION Thinh Nguyen
2022-07-07  8:24   ` Oliver Neukum
2022-07-07 10:21     ` Thinh Nguyen
2022-07-07 20:27   ` Dmitry Bogdanov
2022-07-09  0:11     ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 12/36] target: Properly set Sense data length when copy sense Thinh Nguyen
2022-07-07 20:53   ` Dmitry Bogdanov
2022-07-09  0:11     ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 13/36] target: Don't respond TMR_LUN_DOES_NOT_EXIST for all TMR failure Thinh Nguyen
2022-07-06 23:35 ` [PATCH 14/36] target: Introduce target_submit_tmr_fail_response Thinh Nguyen
2022-07-06 23:35 ` [PATCH 15/36] target: Include INQUIRY length Thinh Nguyen
2022-07-07 10:11   ` Konstantin Shelekhin
2022-07-14  1:42     ` Thinh Nguyen
2022-07-06 23:36 ` [PATCH 16/36] usb: gadget: f_tcm: Increase stream count Thinh Nguyen
2022-07-06 23:36 ` [PATCH 17/36] usb: gadget: f_tcm: Increase bMaxBurst Thinh Nguyen
2022-07-06 23:36 ` [PATCH 18/36] usb: gadget: f_tcm: Don't set static stream_id Thinh Nguyen
2022-07-08  7:00   ` Dmitry Bogdanov
2022-07-09  0:12     ` Thinh Nguyen
2022-07-06 23:36 ` [PATCH 19/36] usb: gadget: f_tcm: Allocate matching number of commands to streams Thinh Nguyen
2022-07-06 23:36 ` [PATCH 20/36] usb: gadget: f_tcm: Limit number of sessions Thinh Nguyen
2022-07-07  6:57   ` Greg Kroah-Hartman
2022-07-07 10:31     ` Thinh Nguyen
2022-07-06 23:36 ` Thinh Nguyen [this message]
2022-07-06 23:36 ` [PATCH 22/36] usb: gadget: f_tcm: Use extra number of commands Thinh Nguyen
2022-07-06 23:36 ` [PATCH 23/36] usb: gadget: f_tcm: Return ATA cmd direction Thinh Nguyen
2022-07-06 23:36 ` [PATCH 24/36] usb: gadget: f_tcm: Execute command on write completion Thinh Nguyen
2022-07-06 23:36 ` [PATCH 25/36] usb: gadget: f_tcm: Minor cleanup redundant code Thinh Nguyen
2022-07-06 23:37 ` [PATCH 26/36] usb: gadget: f_tcm: Don't free command immediately Thinh Nguyen
2022-07-06 23:37 ` [PATCH 27/36] usb: gadget: f_tcm: Translate error to sense Thinh Nguyen
2022-07-06 23:37 ` [PATCH 28/36] usb: gadget: f_tcm: Cleanup unused variable Thinh Nguyen
2022-07-06 23:37 ` [PATCH 29/36] usb: gadget: f_tcm: Update state on data write Thinh Nguyen
2022-07-06 23:37 ` [PATCH 30/36] usb: gadget: f_tcm: Handle abort command Thinh Nguyen
2022-07-06 23:37 ` [PATCH 31/36] usb: gadget: f_tcm: Cleanup requests on ep disable Thinh Nguyen
2022-07-06 23:37 ` [PATCH 32/36] usb: gadget: f_tcm: Send sense reason Thinh Nguyen
2022-07-08  7:35   ` Dmitry Bogdanov
2022-07-09  0:13     ` Thinh Nguyen
2022-07-06 23:37 ` [PATCH 33/36] usb: gadget: f_tcm: Save CPU ID per command Thinh Nguyen
2022-07-06 23:37 ` [PATCH 34/36] usb: gadget: f_tcm: Free tags earlier Thinh Nguyen
2022-07-07  9:14   ` Dmitriy Bogdanov
2022-07-07 10:11     ` Thinh Nguyen
2022-07-07 12:37       ` Dmitry Bogdanov
2022-07-06 23:38 ` [PATCH 35/36] usb: gadget: f_tcm: Handle TASK_MANAGEMENT commands Thinh Nguyen
2022-07-08  9:07   ` Dmitry Bogdanov
2022-07-09  0:41     ` Thinh Nguyen
2022-07-06 23:38 ` [PATCH 36/36] usb: gadget: f_tcm: Comply with UAS Task Management requirement Thinh Nguyen
2022-07-07  4:38 ` [PATCH 00/36] usb: gadget: f_tcm: Enhance UASP driver Christoph Hellwig
2022-07-07  4:50   ` Thinh Nguyen
2022-07-07  6:59 ` Greg Kroah-Hartman
2022-07-07 10:15   ` Thinh Nguyen
2022-07-07 11:15     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f7b66be0db84fc5a362293dbff6674f19a5b311.1657149962.git.Thinh.Nguyen@synopsys.com \
    --to=thinh.nguyen@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=d.bogdanov@yadro.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michael.christie@oracle.com \
    --cc=r.bolshakov@yadro.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.