All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Kucheria <amit.kucheria@linaro.org>
To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	daniel.lezcano@linaro.org, bjorn.andersson@linaro.org,
	swboyd@chromium.org, sivaa@codeaurora.org,
	Andy Gross <agross@kernel.org>
Cc: Amit Kucheria <amit.kucheria@verdurent.com>, linux-pm@vger.kernel.org
Subject: [PATCH v5 3/8] drivers: thermal: tsens: use simpler variables
Date: Tue, 18 Feb 2020 23:42:07 +0530	[thread overview]
Message-ID: <6f95b3f0d39433c7e6b01094bdb200a7ac8e9f0d.1582048155.git.amit.kucheria@linaro.org> (raw)
In-Reply-To: <cover.1582048155.git.amit.kucheria@linaro.org>

We already dereference the sensor and save it into a variable. Use the
variable directly to make the code easier to read.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 drivers/thermal/qcom/tsens-common.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
index c2df30a08b9e..1cbc5a6e5b4f 100644
--- a/drivers/thermal/qcom/tsens-common.c
+++ b/drivers/thermal/qcom/tsens-common.c
@@ -368,7 +368,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
 			tsens_set_interrupt(priv, hw_id, UPPER, disable);
 			if (d.up_thresh > temp) {
 				dev_dbg(priv->dev, "[%u] %s: re-arm upper\n",
-					priv->sensor[i].hw_id, __func__);
+					hw_id, __func__);
 				tsens_set_interrupt(priv, hw_id, UPPER, enable);
 			} else {
 				trigger = true;
@@ -379,7 +379,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
 			tsens_set_interrupt(priv, hw_id, LOWER, disable);
 			if (d.low_thresh < temp) {
 				dev_dbg(priv->dev, "[%u] %s: re-arm low\n",
-					priv->sensor[i].hw_id, __func__);
+					hw_id, __func__);
 				tsens_set_interrupt(priv, hw_id, LOWER, enable);
 			} else {
 				trigger = true;
@@ -392,7 +392,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
 		if (trigger) {
 			dev_dbg(priv->dev, "[%u] %s: TZ update trigger (%d mC)\n",
 				hw_id, __func__, temp);
-			thermal_zone_device_update(priv->sensor[i].tzd,
+			thermal_zone_device_update(s->tzd,
 						   THERMAL_EVENT_UNSPECIFIED);
 		} else {
 			dev_dbg(priv->dev, "[%u] %s: no violation:  %d\n",
@@ -435,7 +435,7 @@ int tsens_set_trips(void *_sensor, int low, int high)
 	spin_unlock_irqrestore(&priv->ul_lock, flags);
 
 	dev_dbg(dev, "[%u] %s: (%d:%d)->(%d:%d)\n",
-		s->hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high);
+		hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high);
 
 	return 0;
 }
-- 
2.20.1


  parent reply	other threads:[~2020-02-18 18:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 18:12 [PATCH v5 0/8] thermal: tsens: Handle critical interrupts Amit Kucheria
2020-02-18 18:12 ` [PATCH v5 1/8] drivers: thermal: tsens: De-constify struct tsens_features Amit Kucheria
2020-02-19 22:54   ` Stephen Boyd
2020-02-18 18:12 ` [PATCH v5 2/8] drivers: thermal: tsens: Pass around struct tsens_sensor as a constant Amit Kucheria
2020-02-19 22:54   ` Stephen Boyd
2020-02-18 18:12 ` Amit Kucheria [this message]
2020-02-19 22:53   ` [PATCH v5 3/8] drivers: thermal: tsens: use simpler variables Stephen Boyd
2020-02-18 18:12 ` [PATCH v5 4/8] drivers: thermal: tsens: Release device in success path Amit Kucheria
2020-02-19 22:55   ` Stephen Boyd
2020-02-24  9:22     ` Amit Kucheria
2020-02-18 18:12 ` [PATCH v5 5/8] drivers: thermal: tsens: Add critical interrupt support Amit Kucheria
2020-02-20  0:05   ` Stephen Boyd
2020-02-24 12:44     ` Amit Kucheria
2020-02-18 18:12 ` [PATCH v5 6/8] drivers: thermal: tsens: Add watchdog support Amit Kucheria
2020-02-19 22:52   ` Stephen Boyd
2020-02-18 18:12 ` [PATCH v5 7/8] drivers: thermal: tsens: kernel-doc fixup Amit Kucheria
2020-02-19 22:51   ` Stephen Boyd
2020-02-18 18:12 ` [PATCH v5 8/8] drivers: thermal: tsens: Remove unnecessary irq flag Amit Kucheria
2020-02-19 22:50   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f95b3f0d39433c7e6b01094bdb200a7ac8e9f0d.1582048155.git.amit.kucheria@linaro.org \
    --to=amit.kucheria@linaro.org \
    --cc=agross@kernel.org \
    --cc=amit.kucheria@verdurent.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sivaa@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.