From: "Rubén Justo" <rjusto@gmail.com>
To: git@vger.kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Martin Ågren" <martin.agren@gmail.com>
Subject: [PATCH] ref-filter.c: fix a leak in get_head_description
Date: Sun, 25 Sep 2022 00:53:18 +0200 [thread overview]
Message-ID: <6ff29e96-7f8d-c354-dced-b1b363e54467@gmail.com> (raw)
In 2708ce62d2 (branch: sort detached HEAD based on a flag, 2021-01-07) a
call to wt_status_state_free_buffers, responsible of freeing the
resources that could be allocated in the local struct wt_status_state
state, was eliminated.
The call to wt_status_state_free_buffers was introduced in 962dd7ebc3
(wt-status: introduce wt_status_state_free_buffers(), 2020-09-27). This
commit brings back that call in get_head_description.
Signed-off-by: Rubén Justo <rjusto@gmail.com>
---
ref-filter.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ref-filter.c b/ref-filter.c
index fd1cb14b0f..914908fac5 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -1722,6 +1722,8 @@ char *get_head_description(void)
} else
strbuf_addstr(&desc, _("(no branch)"));
+ wt_status_state_free_buffers(&state);
+
return strbuf_detach(&desc, NULL);
}
--
2.36.1
next reply other threads:[~2022-09-24 22:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 22:53 Rubén Justo [this message]
2022-09-26 6:59 ` [PATCH] ref-filter.c: fix a leak in get_head_description Martin Ågren
2022-09-26 19:12 ` Junio C Hamano
2022-09-27 5:59 ` Martin Ågren
2022-09-26 8:14 ` Ævar Arnfjörð Bjarmason
2022-09-26 19:13 ` Rubén Justo
2022-10-08 0:35 ` [PATCH v2] wt-status: using of wt_status_state_free_buffers Rubén Justo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ff29e96-7f8d-c354-dced-b1b363e54467@gmail.com \
--to=rjusto@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.