From: Alexander Graf <agraf@suse.de> To: Christoffer Dall <christoffer.dall@linaro.org> Cc: Marc Zyngier <marc.zyngier@arm.com>, Paolo Bonzini <pbonzini@redhat.com>, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/3] Support userspace irqchip with arch timers Date: Fri, 30 Sep 2016 21:31:51 +0200 [thread overview] Message-ID: <71b0ae9d-baea-1f65-3c01-5d87f4f4746f@suse.de> (raw) In-Reply-To: <20160930154335.GB7996@cbox> On 30.09.16 17:43, Christoffer Dall wrote: > On Fri, Sep 30, 2016 at 05:38:11PM +0200, Alexander Graf wrote: >> >> >> On 30.09.16 16:54, Alexander Graf wrote: >>> >>> >>> On 27.09.16 21:08, Christoffer Dall wrote: >>>> Hi Alex, >>>> >>>> Marc and I have been looking at this during Linaro connect and have >>>> slightly reworked your patch into this small series. >>>> >>>> It would be good if you could have a look at it and test it out. >>>> >>>> I've tested it with your QEMU, and it works for UP, but secondary CPUs >>>> fail to come up, and it looks like the kernel never gets an IPI for >>>> those CPUs from userspace. Any chance you're willing to take a look at >>>> that? >>> >>> I still need to see whether I can come up with a prettier solution, but >>> for now this works: >>> >>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c >> >> Eh, no, not in i386 code :). But the problem seems to be a missing >> mpstate sync. >> > Yeah, that looked really dodgy. Have you tested it? :) This time around tested with the correct command line parameters I hope :). I'll send a pretty patch later. diff --git a/target-arm/kvm.c b/target-arm/kvm.c index b4c8fe2..b549f00 100644 --- a/target-arm/kvm.c +++ b/target-arm/kvm.c @@ -173,6 +173,12 @@ int kvm_arch_init(MachineState *ms, KVMState *s) */ kvm_async_interrupts_allowed = true; + /* + * PSCI wakes up secondary cores, so we always need to + * have vCPUs waiting in kernel space + */ + kvm_halt_in_kernel_allowed = true; + cap_has_mp_state = kvm_check_extension(s, KVM_CAP_MP_STATE); type_register_static(&host_arm_cpu_type_info); Alex
WARNING: multiple messages have this Message-ID (diff)
From: agraf@suse.de (Alexander Graf) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/3] Support userspace irqchip with arch timers Date: Fri, 30 Sep 2016 21:31:51 +0200 [thread overview] Message-ID: <71b0ae9d-baea-1f65-3c01-5d87f4f4746f@suse.de> (raw) In-Reply-To: <20160930154335.GB7996@cbox> On 30.09.16 17:43, Christoffer Dall wrote: > On Fri, Sep 30, 2016 at 05:38:11PM +0200, Alexander Graf wrote: >> >> >> On 30.09.16 16:54, Alexander Graf wrote: >>> >>> >>> On 27.09.16 21:08, Christoffer Dall wrote: >>>> Hi Alex, >>>> >>>> Marc and I have been looking at this during Linaro connect and have >>>> slightly reworked your patch into this small series. >>>> >>>> It would be good if you could have a look at it and test it out. >>>> >>>> I've tested it with your QEMU, and it works for UP, but secondary CPUs >>>> fail to come up, and it looks like the kernel never gets an IPI for >>>> those CPUs from userspace. Any chance you're willing to take a look at >>>> that? >>> >>> I still need to see whether I can come up with a prettier solution, but >>> for now this works: >>> >>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c >> >> Eh, no, not in i386 code :). But the problem seems to be a missing >> mpstate sync. >> > Yeah, that looked really dodgy. Have you tested it? :) This time around tested with the correct command line parameters I hope :). I'll send a pretty patch later. diff --git a/target-arm/kvm.c b/target-arm/kvm.c index b4c8fe2..b549f00 100644 --- a/target-arm/kvm.c +++ b/target-arm/kvm.c @@ -173,6 +173,12 @@ int kvm_arch_init(MachineState *ms, KVMState *s) */ kvm_async_interrupts_allowed = true; + /* + * PSCI wakes up secondary cores, so we always need to + * have vCPUs waiting in kernel space + */ + kvm_halt_in_kernel_allowed = true; + cap_has_mp_state = kvm_check_extension(s, KVM_CAP_MP_STATE); type_register_static(&host_arm_cpu_type_info); Alex
next prev parent reply other threads:[~2016-09-30 19:31 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-27 19:08 [PATCH 0/3] Support userspace irqchip with arch timers Christoffer Dall 2016-09-27 19:08 ` Christoffer Dall 2016-09-27 19:08 ` [PATCH 1/3] KVM: arm/arm64: Cleanup the arch timer code's irqchip checking Christoffer Dall 2016-09-27 19:08 ` Christoffer Dall 2016-09-27 19:08 ` [PATCH 2/3] KVM: arm/arm64: Add ARM arch timer interrupts ABI Christoffer Dall 2016-09-27 19:08 ` Christoffer Dall 2016-11-01 11:26 ` Peter Maydell 2016-11-01 11:26 ` Peter Maydell 2016-11-01 14:50 ` Christoffer Dall 2016-11-01 14:50 ` Christoffer Dall 2016-11-01 14:54 ` Peter Maydell 2016-11-01 14:54 ` Peter Maydell 2016-11-01 15:32 ` Christoffer Dall 2016-11-01 15:32 ` Christoffer Dall 2016-11-01 16:56 ` Marc Zyngier 2016-11-01 16:56 ` Marc Zyngier 2016-11-01 16:56 ` Marc Zyngier 2016-09-27 19:08 ` [PATCH 3/3] KVM: arm/arm64: Support arch timers with a userspace gic Christoffer Dall 2016-09-27 19:08 ` Christoffer Dall 2016-09-29 15:11 ` [PATCH 0/3] Support userspace irqchip with arch timers Alexander Graf 2016-09-29 15:11 ` Alexander Graf 2016-09-30 14:54 ` Alexander Graf 2016-09-30 14:54 ` Alexander Graf 2016-09-30 15:38 ` Alexander Graf 2016-09-30 15:38 ` Alexander Graf 2016-09-30 15:43 ` Christoffer Dall 2016-09-30 15:43 ` Christoffer Dall 2016-09-30 15:55 ` Alexander Graf 2016-09-30 15:55 ` Alexander Graf 2016-09-30 19:31 ` Alexander Graf [this message] 2016-09-30 19:31 ` Alexander Graf 2016-10-28 14:38 ` Marc Zyngier 2016-10-28 14:38 ` Marc Zyngier 2016-10-28 15:52 ` Alexander Graf 2016-10-28 15:52 ` Alexander Graf 2016-10-28 15:57 ` Marc Zyngier 2016-10-28 15:57 ` Marc Zyngier 2016-10-28 20:25 ` Alexander Graf 2016-10-28 20:25 ` Alexander Graf 2016-10-29 13:19 ` Paolo Bonzini 2016-10-29 13:19 ` Paolo Bonzini 2016-10-29 18:55 ` Alexander Graf 2016-10-29 18:55 ` Alexander Graf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=71b0ae9d-baea-1f65-3c01-5d87f4f4746f@suse.de \ --to=agraf@suse.de \ --cc=christoffer.dall@linaro.org \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=pbonzini@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.