All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Machata <petrm@mellanox.com>
To: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: davem@davemloft.net, shuah@kernel.org, idosch@mellanox.com
Subject: [PATCH net-next 1/2] selftests: forwarding: mirror_vlan: Uninstall trap
Date: Fri, 01 Jun 2018 00:37:44 +0200	[thread overview]
Message-ID: <72a086d8bfd94ec0bc438b00a9ebf4f5d6515f2c.1527805500.git.petrm@mellanox.com> (raw)
In-Reply-To: <cover.1527805500.git.petrm@mellanox.com>

Instead of installing a trap before tests run and uninstalling it after
they run, mirror_vlan.sh installs it twice due to a typo. Fix the typo.

Signed-off-by: Petr Machata <petrm@mellanox.com>
---
 tools/testing/selftests/net/forwarding/mirror_vlan.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/forwarding/mirror_vlan.sh b/tools/testing/selftests/net/forwarding/mirror_vlan.sh
index 1e10520..c22e949 100755
--- a/tools/testing/selftests/net/forwarding/mirror_vlan.sh
+++ b/tools/testing/selftests/net/forwarding/mirror_vlan.sh
@@ -146,7 +146,7 @@ test_all()
 
 	tests_run
 
-	trap_install $h3 ingress
+	trap_uninstall $h3 ingress
 	slow_path_trap_uninstall $swp1 egress
 	slow_path_trap_uninstall $swp1 ingress
 }
-- 
2.4.11

WARNING: multiple messages have this Message-ID (diff)
From: petrm at mellanox.com (Petr Machata)
Subject: [PATCH net-next 1/2] selftests: forwarding: mirror_vlan: Uninstall trap
Date: Fri, 01 Jun 2018 00:37:44 +0200	[thread overview]
Message-ID: <72a086d8bfd94ec0bc438b00a9ebf4f5d6515f2c.1527805500.git.petrm@mellanox.com> (raw)
In-Reply-To: <cover.1527805500.git.petrm@mellanox.com>

Instead of installing a trap before tests run and uninstalling it after
they run, mirror_vlan.sh installs it twice due to a typo. Fix the typo.

Signed-off-by: Petr Machata <petrm at mellanox.com>
---
 tools/testing/selftests/net/forwarding/mirror_vlan.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/forwarding/mirror_vlan.sh b/tools/testing/selftests/net/forwarding/mirror_vlan.sh
index 1e10520..c22e949 100755
--- a/tools/testing/selftests/net/forwarding/mirror_vlan.sh
+++ b/tools/testing/selftests/net/forwarding/mirror_vlan.sh
@@ -146,7 +146,7 @@ test_all()
 
 	tests_run
 
-	trap_install $h3 ingress
+	trap_uninstall $h3 ingress
 	slow_path_trap_uninstall $swp1 egress
 	slow_path_trap_uninstall $swp1 ingress
 }
-- 
2.4.11

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: petrm@mellanox.com (Petr Machata)
Subject: [PATCH net-next 1/2] selftests: forwarding: mirror_vlan: Uninstall trap
Date: Fri, 01 Jun 2018 00:37:44 +0200	[thread overview]
Message-ID: <72a086d8bfd94ec0bc438b00a9ebf4f5d6515f2c.1527805500.git.petrm@mellanox.com> (raw)
Message-ID: <20180531223744.w_wEb4O4l7_eC40Q7k1oIFI2a04aIwfCS7rRTmtcibk@z> (raw)
In-Reply-To: <cover.1527805500.git.petrm@mellanox.com>

Instead of installing a trap before tests run and uninstalling it after
they run, mirror_vlan.sh installs it twice due to a typo. Fix the typo.

Signed-off-by: Petr Machata <petrm at mellanox.com>
---
 tools/testing/selftests/net/forwarding/mirror_vlan.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/forwarding/mirror_vlan.sh b/tools/testing/selftests/net/forwarding/mirror_vlan.sh
index 1e10520..c22e949 100755
--- a/tools/testing/selftests/net/forwarding/mirror_vlan.sh
+++ b/tools/testing/selftests/net/forwarding/mirror_vlan.sh
@@ -146,7 +146,7 @@ test_all()
 
 	tests_run
 
-	trap_install $h3 ingress
+	trap_uninstall $h3 ingress
 	slow_path_trap_uninstall $swp1 egress
 	slow_path_trap_uninstall $swp1 ingress
 }
-- 
2.4.11

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-05-31 22:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 22:37 [PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets Petr Machata
2018-05-31 22:37 ` Petr Machata
2018-05-31 22:37 ` petrm
2018-05-31 22:37 ` Petr Machata [this message]
2018-05-31 22:37   ` [PATCH net-next 1/2] selftests: forwarding: mirror_vlan: Uninstall trap Petr Machata
2018-05-31 22:37   ` petrm
2018-05-31 22:37 ` [PATCH net-next 2/2] selftests: forwarding: mirror_vlan: Change test description Petr Machata
2018-05-31 22:37   ` Petr Machata
2018-05-31 22:37   ` petrm
2018-06-04 14:09 ` [PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets David Miller
2018-06-04 14:09   ` David Miller
2018-06-04 14:09   ` davem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72a086d8bfd94ec0bc438b00a9ebf4f5d6515f2c.1527805500.git.petrm@mellanox.com \
    --to=petrm@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=idosch@mellanox.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.