From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org, linux@arm.linux.org.uk,
daniel@ffwll.ch, airlied@linux.ie
Cc: jani.nikula@intel.com
Subject: [PATCH 1/4] drm/i915: fix EDID memory leak in SDVO
Date: Wed, 15 Aug 2012 12:32:36 +0300 [thread overview]
Message-ID: <738a7ab23d49f3fb68cc67062eaa57ed6c8d23c7.1345022231.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1345022231.git.jani.nikula@intel.com>
In-Reply-To: <cover.1345022231.git.jani.nikula@intel.com>
The EDID returned by drm_get_edid() was never freed.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_sdvo.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
index d172e98..d81bb0b 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -1692,6 +1692,7 @@ static bool intel_sdvo_detect_hdmi_audio(struct drm_connector *connector)
edid = intel_sdvo_get_edid(connector);
if (edid != NULL && edid->input & DRM_EDID_INPUT_DIGITAL)
has_audio = drm_detect_monitor_audio(edid);
+ kfree(edid);
return has_audio;
}
--
1.7.4.1
next prev parent reply other threads:[~2012-08-15 9:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-11 16:51 [BUG] EDID leaks kernel memory Russell King - ARM Linux
2012-08-13 14:24 ` Daniel Vetter
2012-08-15 9:32 ` [PATCH 0/4] remove raw_edid, and fix related memory leaks Jani Nikula
2012-08-15 9:32 ` Jani Nikula [this message]
2012-08-15 22:45 ` [PATCH 1/4] drm/i915: fix EDID memory leak in SDVO Daniel Vetter
2012-08-15 9:32 ` [PATCH 2/4] drm/ast: fix EDID memory leak Jani Nikula
2012-08-15 9:32 ` [PATCH 3/4] drm/exynos: fix EDID memory leak in HDMI Jani Nikula
2012-08-22 4:21 ` InKi Dae
2012-08-15 9:32 ` [PATCH 4/4] drm: remove the raw_edid field from struct drm_display_info Jani Nikula
2012-08-22 5:18 ` InKi Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=738a7ab23d49f3fb68cc67062eaa57ed6c8d23c7.1345022231.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.