All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guru Das Srinagesh <gurus@codeaurora.org>
To: linux-pwm@vger.kernel.org,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
	David Collins <collinsd@codeaurora.org>,
	linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
	Stephen Boyd <sboyd@kernel.org>, Lee Jones <lee.jones@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	linux-arm-kernel@lists.infradead.org,
	Guru Das Srinagesh <gurus@codeaurora.org>
Subject: [PATCH v15 08/11] pwm: sun4i: Use nsecs_to_jiffies to avoid a division
Date: Tue, 26 May 2020 10:35:08 -0700	[thread overview]
Message-ID: <73a3e90f5a5a4fe4fb0f0412c7425effc338036b.1590514331.git.gurus@codeaurora.org> (raw)
In-Reply-To: <cover.1590514331.git.gurus@codeaurora.org>
In-Reply-To: <cover.1590514331.git.gurus@codeaurora.org>

Since the PWM framework is switching struct pwm_state.period's datatype
to u64, prepare for this transition by using nsecs_to_jiffies() which
does away with the need for a division operation.

Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
Acked-by: Chen-Yu Tsai <wens@csie.org>
---
 drivers/pwm/pwm-sun4i.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
index 5c677c5..1694e69 100644
--- a/drivers/pwm/pwm-sun4i.c
+++ b/drivers/pwm/pwm-sun4i.c
@@ -285,7 +285,7 @@ static int sun4i_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
 	val = (duty & PWM_DTY_MASK) | PWM_PRD(period);
 	sun4i_pwm_writel(sun4i_pwm, val, PWM_CH_PRD(pwm->hwpwm));
 	sun4i_pwm->next_period[pwm->hwpwm] = jiffies +
-		usecs_to_jiffies(cstate.period / 1000 + 1);
+		nsecs_to_jiffies(cstate.period + 1000);
 
 	if (state->polarity != PWM_POLARITY_NORMAL)
 		ctrl &= ~BIT_CH(PWM_ACT_STATE, pwm->hwpwm);
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


WARNING: multiple messages have this Message-ID (diff)
From: Guru Das Srinagesh <gurus@codeaurora.org>
To: linux-pwm@vger.kernel.org,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Guru Das Srinagesh <gurus@codeaurora.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	David Collins <collinsd@codeaurora.org>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Joe Perches <joe@perches.com>,
	Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
	Lee Jones <lee.jones@linaro.org>,
	Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH v15 08/11] pwm: sun4i: Use nsecs_to_jiffies to avoid a division
Date: Tue, 26 May 2020 10:35:08 -0700	[thread overview]
Message-ID: <73a3e90f5a5a4fe4fb0f0412c7425effc338036b.1590514331.git.gurus@codeaurora.org> (raw)
In-Reply-To: <cover.1590514331.git.gurus@codeaurora.org>
In-Reply-To: <cover.1590514331.git.gurus@codeaurora.org>

Since the PWM framework is switching struct pwm_state.period's datatype
to u64, prepare for this transition by using nsecs_to_jiffies() which
does away with the need for a division operation.

Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
Acked-by: Chen-Yu Tsai <wens@csie.org>
---
 drivers/pwm/pwm-sun4i.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
index 5c677c5..1694e69 100644
--- a/drivers/pwm/pwm-sun4i.c
+++ b/drivers/pwm/pwm-sun4i.c
@@ -285,7 +285,7 @@ static int sun4i_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
 	val = (duty & PWM_DTY_MASK) | PWM_PRD(period);
 	sun4i_pwm_writel(sun4i_pwm, val, PWM_CH_PRD(pwm->hwpwm));
 	sun4i_pwm->next_period[pwm->hwpwm] = jiffies +
-		usecs_to_jiffies(cstate.period / 1000 + 1);
+		nsecs_to_jiffies(cstate.period + 1000);
 
 	if (state->polarity != PWM_POLARITY_NORMAL)
 		ctrl &= ~BIT_CH(PWM_ACT_STATE, pwm->hwpwm);
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-05-26 17:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26 17:35 [PATCH v15 00/11] Convert PWM period and duty cycle to u64 Guru Das Srinagesh
2020-05-26 17:35 ` Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 01/11] drm/i915: Use 64-bit division macro Guru Das Srinagesh
2020-05-26 17:35   ` Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 02/11] hwmon: pwm-fan: " Guru Das Srinagesh
2020-05-26 17:35   ` Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 03/11] ir-rx51: " Guru Das Srinagesh
2020-05-26 17:35   ` Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 04/11] pwm: clps711x: " Guru Das Srinagesh
2020-05-26 17:35   ` Guru Das Srinagesh
2020-05-28 20:33   ` Guru Das Srinagesh
2020-05-28 20:33     ` Guru Das Srinagesh
2020-06-01 11:33     ` Daniel Thompson
2020-06-01 11:33       ` Daniel Thompson
2020-05-26 17:35 ` [PATCH v15 05/11] pwm: pwm-imx-tpm: " Guru Das Srinagesh
2020-05-26 17:35   ` Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 06/11] pwm: imx27: Use 64-bit division macro and function Guru Das Srinagesh
2020-05-26 17:35   ` Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 07/11] pwm: sifive: Use 64-bit division macro Guru Das Srinagesh
2020-05-26 17:35   ` Guru Das Srinagesh
2020-05-26 17:35   ` Guru Das Srinagesh
2020-05-26 17:35 ` Guru Das Srinagesh [this message]
2020-05-26 17:35   ` [PATCH v15 08/11] pwm: sun4i: Use nsecs_to_jiffies to avoid a division Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 09/11] backlight: pwm_bl: Use 64-bit division function Guru Das Srinagesh
2020-05-26 17:35   ` Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 10/11] clk: pwm: " Guru Das Srinagesh
2020-05-26 17:35   ` Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 11/11] pwm: core: Convert period and duty cycle to u64 Guru Das Srinagesh
2020-05-26 17:35   ` Guru Das Srinagesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73a3e90f5a5a4fe4fb0f0412c7425effc338036b.1590514331.git.gurus@codeaurora.org \
    --to=gurus@codeaurora.org \
    --cc=arnd@arndb.de \
    --cc=collinsd@codeaurora.org \
    --cc=dan.carpenter@oracle.com \
    --cc=daniel.thompson@linaro.org \
    --cc=geert@linux-m68k.org \
    --cc=joe@perches.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=sboyd@kernel.org \
    --cc=subbaram@codeaurora.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.