All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>,
	"George Dunlap" <george.dunlap@citrix.com>,
	"Tim Deegan" <tim@xen.org>
Subject: [PATCH 4/8] x86/shadow: exclude HVM-only code from sh_remove_shadows() when !HVM
Date: Tue, 26 Jul 2022 18:05:17 +0200	[thread overview]
Message-ID: <75dd380e-5dab-8d19-b9da-b59188bc4997@suse.com> (raw)
In-Reply-To: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com>

In my (debug) build this amounts to well over 500 bytes of dead code.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -2240,10 +2240,12 @@ void sh_remove_shadows(struct domain *d,
     }                                                                   \
 } while (0)
 
+#ifdef CONFIG_HVM
     DO_UNSHADOW(SH_type_l2_32_shadow);
     DO_UNSHADOW(SH_type_l1_32_shadow);
     DO_UNSHADOW(SH_type_l2_pae_shadow);
     DO_UNSHADOW(SH_type_l1_pae_shadow);
+#endif
     DO_UNSHADOW(SH_type_l4_64_shadow);
     DO_UNSHADOW(SH_type_l3_64_shadow);
     DO_UNSHADOW(SH_type_l2h_64_shadow);



  parent reply	other threads:[~2022-07-26 16:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26 15:58 [PATCH 0/8] x86: XSA-40{1,2,8} follow-up Jan Beulich
2022-07-26 16:03 ` [PATCH 1/8] x86/shadow: drop shadow_prepare_page_type_change()'s 3rd parameter Jan Beulich
2022-07-27  9:25   ` Andrew Cooper
2022-07-26 16:04 ` [PATCH 2/8] x86/shadow: properly handle get_page() failing Jan Beulich
2022-07-27 12:46   ` Andrew Cooper
2022-07-27 12:53     ` Jan Beulich
2022-07-27 19:06       ` Andrew Cooper
2022-07-28  6:12         ` Jan Beulich
2022-07-26 16:04 ` [PATCH 3/8] mm: enforce return value checking on get_page() Jan Beulich
2022-07-26 17:32   ` Julien Grall
2022-07-26 16:05 ` Jan Beulich [this message]
2022-07-27 12:55   ` [PATCH 4/8] x86/shadow: exclude HVM-only code from sh_remove_shadows() when !HVM Andrew Cooper
2022-07-26 16:05 ` [PATCH 5/8] x86/shadow: don't open-code shadow_remove_all_shadows() Jan Beulich
2022-07-27 12:56   ` Andrew Cooper
2022-07-26 16:06 ` [PATCH 6/8] x86/shadow: drop CONFIG_HVM conditionals from sh_update_cr3() Jan Beulich
2022-07-27 12:57   ` Andrew Cooper
2022-07-26 16:06 ` [PATCH 7/8] x86/mm: adjust type check around _get_page_type()'s TLB flush Jan Beulich
2022-07-27 18:25   ` Andrew Cooper
2022-07-28  6:16     ` Jan Beulich
2022-08-12  8:51     ` Jan Beulich
2022-07-26 16:07 ` [PATCH 8/8] x86/mm: re-arrange " Jan Beulich
2022-07-27 18:31   ` Andrew Cooper
2022-07-28  6:20     ` Jan Beulich
2022-07-30 20:28 ` [PATCH 0/8] x86: XSA-40{1,2,8} follow-up Tim Deegan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75dd380e-5dab-8d19-b9da-b59188bc4997@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=tim@xen.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.