All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com,
	linux-fsdevel@vger.kernel.org, brauner@kernel.org
Subject: [PATCH 07/18] btrfs: add a NOSPACECACHE mount option flag
Date: Mon,  6 Nov 2023 17:08:15 -0500	[thread overview]
Message-ID: <7723acf40642ab84b48f25f31e2894120d035b5d.1699308010.git.josef@toxicpanda.com> (raw)
In-Reply-To: <cover.1699308010.git.josef@toxicpanda.com>

With the old mount API we'd pre-populate the mount options with the
space cache settings of the file system, and then the user toggled them
on or off with the mount options.  When we switch to the new mount API
the mount options will be set before we get into opening the file
system, so we need a flag to indicate that the user explicitly asked for
-o nospace_cache so we can make the appropriate changes after the fact.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 fs/btrfs/disk-io.c | 1 +
 fs/btrfs/fs.h      | 1 +
 2 files changed, 2 insertions(+)

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 072c45811c41..c70e507a28d0 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -2938,6 +2938,7 @@ void btrfs_clear_oneshot_options(struct btrfs_fs_info *fs_info)
 {
 	btrfs_clear_opt(fs_info->mount_opt, USEBACKUPROOT);
 	btrfs_clear_opt(fs_info->mount_opt, CLEAR_CACHE);
+	btrfs_clear_opt(fs_info->mount_opt, NOSPACECACHE);
 }
 
 /*
diff --git a/fs/btrfs/fs.h b/fs/btrfs/fs.h
index 318df6f9d9cb..ecfa13a9c2cf 100644
--- a/fs/btrfs/fs.h
+++ b/fs/btrfs/fs.h
@@ -188,6 +188,7 @@ enum {
 	BTRFS_MOUNT_IGNOREBADROOTS		= (1UL << 27),
 	BTRFS_MOUNT_IGNOREDATACSUMS		= (1UL << 28),
 	BTRFS_MOUNT_NODISCARD			= (1UL << 29),
+	BTRFS_MOUNT_NOSPACECACHE		= (1UL << 30),
 };
 
 /*
-- 
2.41.0


  parent reply	other threads:[~2023-11-06 22:08 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-06 22:08 [PATCH 00/18] btrfs: convert to the new mount API Josef Bacik
2023-11-06 22:08 ` [PATCH 01/18] fs: indicate request originates from old mount api Josef Bacik
2023-11-08  7:59   ` Christoph Hellwig
2023-11-06 22:08 ` [PATCH 02/18] btrfs: split out the mount option validation code into its own helper Josef Bacik
2023-11-06 22:08 ` [PATCH 03/18] btrfs: set default compress type at btrfs_init_fs_info time Josef Bacik
2023-11-06 22:08 ` [PATCH 04/18] btrfs: move space cache settings into open_ctree Josef Bacik
2023-11-07 15:14   ` Johannes Thumshirn
2023-11-06 22:08 ` [PATCH 05/18] btrfs: do not allow free space tree rebuild on extent tree v2 Josef Bacik
2023-11-06 22:08 ` [PATCH 06/18] btrfs: split out ro->rw and rw->ro helpers into their own functions Josef Bacik
2023-11-07 15:16   ` Johannes Thumshirn
2023-11-08 15:52     ` Josef Bacik
2023-11-06 22:08 ` Josef Bacik [this message]
2023-11-06 22:08 ` [PATCH 08/18] btrfs: add fs_parameter definitions Josef Bacik
2023-11-06 22:08 ` [PATCH 09/18] btrfs: add parse_param callback for the new mount api Josef Bacik
2023-11-06 22:08 ` [PATCH 10/18] btrfs: add fs context handling functions Josef Bacik
2023-11-08  8:46   ` Christian Brauner
2023-11-06 22:08 ` [PATCH 11/18] btrfs: add reconfigure callback for fs_context Josef Bacik
2023-11-06 22:08 ` [PATCH 12/18] btrfs: add get_tree callback for new mount API Josef Bacik
2023-11-08  9:00   ` Christian Brauner
2023-11-06 22:08 ` [PATCH 13/18] btrfs: handle the ro->rw transition for mounting different subovls Josef Bacik
2023-11-08  8:41   ` Christian Brauner
2023-11-08 15:53     ` Josef Bacik
2023-11-06 22:08 ` [PATCH 14/18] btrfs: switch to the new mount API Josef Bacik
2023-11-08  9:03   ` Christian Brauner
2023-11-06 22:08 ` [PATCH 15/18] btrfs: move the device specific mount options to super.c Josef Bacik
2023-11-06 22:08 ` [PATCH 16/18] btrfs: remove old mount API code Josef Bacik
2023-11-06 22:08 ` [PATCH 17/18] btrfs: move one shot mount option clearing to super.c Josef Bacik
2023-11-06 22:08 ` [PATCH 18/18] btrfs: set clear_cache if we use usebackuproot Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7723acf40642ab84b48f25f31e2894120d035b5d.1699308010.git.josef@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=brauner@kernel.org \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.