From: Eric Sandeen <sandeen@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 1/2] xfs_db: short circuit type_f if type is unchanged
Date: Thu, 20 Aug 2020 19:05:37 -0500 [thread overview]
Message-ID: <784ed247-0467-093b-1113-ff80a1289cbd@redhat.com> (raw)
In-Reply-To: <8b1ab1c4-64f6-5410-bf40-30776dae4dd5@redhat.com>
There's no reason to go through the type change code if the
type has not been changed.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/db/type.c b/db/type.c
index 3cb1e868..572ac6d6 100644
--- a/db/type.c
+++ b/db/type.c
@@ -216,6 +216,8 @@ type_f(
tt = findtyp(argv[1]);
if (tt == NULL) {
dbprintf(_("no such type %s\n"), argv[1]);
+ } else if (iocur_top->typ == tt) {
+ return 0;
} else {
if (iocur_top->typ == NULL)
dbprintf(_("no current object\n"));
next prev parent reply other threads:[~2020-08-21 0:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 23:44 [PATCH 0/2] xfs_db: more type_f cleanups Eric Sandeen
2020-08-21 0:05 ` Eric Sandeen [this message]
2020-08-21 14:46 ` [PATCH 1/2] xfs_db: short circuit type_f if type is unchanged Darrick J. Wong
2020-08-21 15:46 ` Eric Sandeen
2020-08-21 0:09 ` [PATCH 2/2] xfs_db: consolidate set_iocur_type behavior Eric Sandeen
2020-08-21 14:52 ` Darrick J. Wong
2020-08-21 15:48 ` Eric Sandeen
2020-08-24 16:51 ` [PATCH 2/2 V2] xfs_db: consolidate set_iocur_type() behavior Eric Sandeen
2020-08-24 17:03 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=784ed247-0467-093b-1113-ff80a1289cbd@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.