All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Coddington <bcodding@redhat.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <anna.schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH] NFS: Retry a zero-length short read
Date: Wed, 16 Mar 2016 05:17:07 -0400	[thread overview]
Message-ID: <79adfc63f33887475f6a0f0eeaacd8b52b2ed12c.1458119750.git.bcodding@redhat.com> (raw)

A zero-length short read without eof should be retried rather than sending
an error to the application.

Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
---
 fs/nfs/read.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/fs/nfs/read.c b/fs/nfs/read.c
index eb31e23..7269d42 100644
--- a/fs/nfs/read.c
+++ b/fs/nfs/read.c
@@ -244,11 +244,6 @@ static void nfs_readpage_retry(struct rpc_task *task,
 
 	/* This is a short read! */
 	nfs_inc_stats(hdr->inode, NFSIOS_SHORTREAD);
-	/* Has the server at least made some progress? */
-	if (resp->count == 0) {
-		nfs_set_pgio_error(hdr, -EIO, argp->offset);
-		return;
-	}
 
 	/* For non rpc-based layout drivers, retry-through-MDS */
 	if (!task->tk_ops) {
-- 
1.7.1


             reply	other threads:[~2016-03-16  9:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16  9:17 Benjamin Coddington [this message]
2016-03-16 13:14 ` [PATCH] NFS: Retry a zero-length short read Trond Myklebust
2016-03-16 14:22   ` Benjamin Coddington
2016-03-16 14:40     ` Trond Myklebust
2016-03-16 14:56       ` Benjamin Coddington
2016-03-16 15:20         ` Benjamin Coddington
2016-03-16 16:22           ` Trond Myklebust
2016-03-16 17:18             ` J. Bruce Fields
2016-03-16 17:36               ` Benjamin Coddington
2016-03-16 19:15                 ` J. Bruce Fields
2016-03-16 19:46                   ` Benjamin Coddington
2016-03-16 19:56                     ` J. Bruce Fields
2016-03-16 20:02                       ` Trond Myklebust
2016-03-17  2:03                         ` Mkrtchyan, Tigran
2016-03-17 10:11                           ` Benjamin Coddington
2016-03-17 13:24                             ` Trond Myklebust
2016-03-17 13:34                               ` Benjamin Coddington
2016-03-22 21:04                         ` J. Bruce Fields
2016-03-16 19:46                 ` J. Bruce Fields
2016-03-16 17:30             ` Benjamin Coddington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79adfc63f33887475f6a0f0eeaacd8b52b2ed12c.1458119750.git.bcodding@redhat.com \
    --to=bcodding@redhat.com \
    --cc=anna.schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.