Re: [PATCH v7 05/24] x86/resctrl: Track the closid with the rmid

From: James Morse <james.morse@arm.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	shameerali.kolothum.thodi@huawei.com,
	D Scott Phillips OS <scott@os.amperecomputing.com>,
	carl@os.amperecomputing.com, lcherian@marvell.com,
	bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com,
	baolin.wang@linux.alibaba.com,
	Jamie Iles <quic_jiles@quicinc.com>,
	Xin Hao <xhao@linux.alibaba.com>,
	peternewman@google.com, dfustini@baylibre.com,
	amitsinght@marvell.com
Subject: Re: [PATCH v7 05/24] x86/resctrl: Track the closid with the rmid
Date: Wed, 13 Dec 2023 18:03:52 +0000	[thread overview]
Message-ID: <79cdd108-d522-b1e0-6623-9c0e43534afc@arm.com> (raw)
In-Reply-To: <c4e18e30-1898-471e-8065-ebb85d654084@intel.com>

Hi Reinette,

On 09/11/2023 17:41, Reinette Chatre wrote:
> On 10/25/2023 11:03 AM, James Morse wrote:
>> @@ -732,10 +752,10 @@ static int dom_data_init(struct rdt_resource *r)
>>  	}
>>  
>>  	/*
>> -	 * RMID 0 is special and is always allocated. It's used for all
>> -	 * tasks that are not monitored.
>> -	 */
>> -	entry = __rmid_entry(0);
>> +	* These are used for rdtgroup_default control group, which will be
>> +	* setup later in rdtgroup_init().
> 
> This sentence I provided was intended to just replace two sentences, not the
> entire paragraph you had. Note that I explicitly stated "change last two
> sentences". Without the original text the above "These" is not clear.
> If you just want to copy&paste here is the entire intended comment:
> 
> 	RESCTRL_RESERVED_CLOSID and RESCTRL_RESERVED_RMID are special and
> 	are always allocated. These are used for the rdtgroup_default
> 	control group, which will be setup later in rdtgroup_init().

Thanks! I probably got muddled with whether this was against the existing code or not.

James