From: Simon Horman <horms+renesas@verge.net.au> To: linux-renesas-soc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Magnus Damm <magnus.damm@gmail.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Simon Horman <horms+renesas@verge.net.au> Subject: [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing Date: Tue, 2 May 2017 10:35:49 +0200 [thread overview] Message-ID: <7b4ccb3c466f62bbf2f4dd5d6a143d945a6f3051.1493713942.git.horms+renesas@verge.net.au> (raw) In-Reply-To: <cover.1493713942.git.horms+renesas@verge.net.au> From: Geert Uytterhoeven <geert+renesas@glider.be> If the R-Car RST driver is not included, compile-testing R-Car clock drivers fails with a link error: undefined reference to `rcar_rst_read_mode_pins' To fix this, provide a dummy version. Use the exact same test logic as in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to control compilation of the R-Car RST driver. Fixes: 527c02f66d263d2e ("soc: renesas: Add R-Car RST driver") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- include/linux/soc/renesas/rcar-rst.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/soc/renesas/rcar-rst.h b/include/linux/soc/renesas/rcar-rst.h index a18e0783946b..787e7ad53d45 100644 --- a/include/linux/soc/renesas/rcar-rst.h +++ b/include/linux/soc/renesas/rcar-rst.h @@ -1,6 +1,11 @@ #ifndef __LINUX_SOC_RENESAS_RCAR_RST_H__ #define __LINUX_SOC_RENESAS_RCAR_RST_H__ +#if defined(CONFIG_ARCH_RCAR_GEN1) || defined(CONFIG_ARCH_RCAR_GEN2) || \ + defined(CONFIG_ARCH_R8A7795) || defined(CONFIG_ARCH_R8A7796) int rcar_rst_read_mode_pins(u32 *mode); +#else +static inline int rcar_rst_read_mode_pins(u32 *mode) { return -ENODEV; } +#endif #endif /* __LINUX_SOC_RENESAS_RCAR_RST_H__ */ -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: horms+renesas@verge.net.au (Simon Horman) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing Date: Tue, 2 May 2017 10:35:49 +0200 [thread overview] Message-ID: <7b4ccb3c466f62bbf2f4dd5d6a143d945a6f3051.1493713942.git.horms+renesas@verge.net.au> (raw) In-Reply-To: <cover.1493713942.git.horms+renesas@verge.net.au> From: Geert Uytterhoeven <geert+renesas@glider.be> If the R-Car RST driver is not included, compile-testing R-Car clock drivers fails with a link error: undefined reference to `rcar_rst_read_mode_pins' To fix this, provide a dummy version. Use the exact same test logic as in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to control compilation of the R-Car RST driver. Fixes: 527c02f66d263d2e ("soc: renesas: Add R-Car RST driver") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- include/linux/soc/renesas/rcar-rst.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/soc/renesas/rcar-rst.h b/include/linux/soc/renesas/rcar-rst.h index a18e0783946b..787e7ad53d45 100644 --- a/include/linux/soc/renesas/rcar-rst.h +++ b/include/linux/soc/renesas/rcar-rst.h @@ -1,6 +1,11 @@ #ifndef __LINUX_SOC_RENESAS_RCAR_RST_H__ #define __LINUX_SOC_RENESAS_RCAR_RST_H__ +#if defined(CONFIG_ARCH_RCAR_GEN1) || defined(CONFIG_ARCH_RCAR_GEN2) || \ + defined(CONFIG_ARCH_R8A7795) || defined(CONFIG_ARCH_R8A7796) int rcar_rst_read_mode_pins(u32 *mode); +#else +static inline int rcar_rst_read_mode_pins(u32 *mode) { return -ENODEV; } +#endif #endif /* __LINUX_SOC_RENESAS_RCAR_RST_H__ */ -- 2.1.4
next prev parent reply other threads:[~2017-05-02 8:35 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-02 8:35 [GIT PULL] Renesas ARM Based SoC Fixes for v4.12 Simon Horman 2017-05-02 8:35 ` Simon Horman 2017-05-02 8:35 ` Simon Horman [this message] 2017-05-02 8:35 ` [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing Simon Horman 2017-05-10 13:34 ` [GIT PULL] Renesas ARM Based SoC Fixes for v4.12 Arnd Bergmann 2017-05-10 13:34 ` Arnd Bergmann -- strict thread matches above, loose matches on Subject: below -- 2017-04-25 17:36 [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing Geert Uytterhoeven 2017-04-26 7:13 ` Simon Horman 2017-04-26 7:34 ` Simon Horman 2017-04-26 12:35 ` Geert Uytterhoeven 2017-04-28 5:14 ` Simon Horman 2017-04-28 7:28 ` Geert Uytterhoeven 2017-04-28 8:01 ` Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7b4ccb3c466f62bbf2f4dd5d6a143d945a6f3051.1493713942.git.horms+renesas@verge.net.au \ --to=horms+renesas@verge.net.au \ --cc=geert+renesas@glider.be \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.