From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
jani.nikula@intel.com, ville.syrjala@linux.intel.com,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 3/7] drm/sysfs: switch to drm device based logging
Date: Mon, 8 Apr 2024 12:23:58 +0300 [thread overview]
Message-ID: <7f3dd5b4a33f964c6903c7a964da5397f4084aeb.1712568037.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1712568037.git.jani.nikula@intel.com>
Prefer drm_dbg_kms() and drm_dbg_lease() over DRM_DEBUG_KMS() and
DRM_DEBUG() to debug log the drm device info. Fix some debug categories
and unify connector logging while at it.
v2: Drop superfluous newline
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/drm_sysfs.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
index a953f69a34b6..bd9b8ab4f82b 100644
--- a/drivers/gpu/drm/drm_sysfs.c
+++ b/drivers/gpu/drm/drm_sysfs.c
@@ -209,10 +209,9 @@ static ssize_t status_store(struct device *device,
ret = -EINVAL;
if (old_force != connector->force || !connector->force) {
- DRM_DEBUG_KMS("[CONNECTOR:%d:%s] force updated from %d to %d or reprobing\n",
- connector->base.id,
- connector->name,
- old_force, connector->force);
+ drm_dbg_kms(dev, "[CONNECTOR:%d:%s] force updated from %d to %d or reprobing\n",
+ connector->base.id, connector->name,
+ old_force, connector->force);
connector->funcs->fill_modes(connector,
dev->mode_config.max_width,
@@ -383,8 +382,8 @@ int drm_sysfs_connector_add(struct drm_connector *connector)
if (r)
goto err_free;
- DRM_DEBUG("adding \"%s\" to sysfs\n",
- connector->name);
+ drm_dbg_kms(dev, "[CONNECTOR:%d:%s] adding connector to sysfs\n",
+ connector->base.id, connector->name);
r = device_add(kdev);
if (r) {
@@ -430,8 +429,9 @@ void drm_sysfs_connector_remove(struct drm_connector *connector)
if (dev_fwnode(connector->kdev))
component_del(connector->kdev, &typec_connector_ops);
- DRM_DEBUG("removing \"%s\" from sysfs\n",
- connector->name);
+ drm_dbg_kms(connector->dev,
+ "[CONNECTOR:%d:%s] removing connector from sysfs\n",
+ connector->base.id, connector->name);
device_unregister(connector->kdev);
connector->kdev = NULL;
@@ -442,7 +442,7 @@ void drm_sysfs_lease_event(struct drm_device *dev)
char *event_string = "LEASE=1";
char *envp[] = { event_string, NULL };
- DRM_DEBUG("generating lease event\n");
+ drm_dbg_lease(dev, "generating lease event\n");
kobject_uevent_env(&dev->primary->kdev->kobj, KOBJ_CHANGE, envp);
}
@@ -463,7 +463,7 @@ void drm_sysfs_hotplug_event(struct drm_device *dev)
char *event_string = "HOTPLUG=1";
char *envp[] = { event_string, NULL };
- DRM_DEBUG("generating hotplug event\n");
+ drm_dbg_kms(dev, "generating hotplug event\n");
kobject_uevent_env(&dev->primary->kdev->kobj, KOBJ_CHANGE, envp);
}
--
2.39.2
next prev parent reply other threads:[~2024-04-08 9:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 9:23 [PATCH v2 0/7] drm: debug logging improvements Jani Nikula
2024-04-08 9:23 ` [PATCH v2 1/7] drm/probe-helper: switch to drm device based logging Jani Nikula
2024-04-08 9:23 ` [PATCH v2 2/7] drm/modes: switch to drm device based error logging Jani Nikula
2024-04-08 9:23 ` Jani Nikula [this message]
2024-04-08 9:23 ` [PATCH v2 4/7] drm/client: switch to drm device based logging, and more Jani Nikula
2024-04-08 9:24 ` [PATCH v2 5/7] drm/crtc: switch to drm device based logging Jani Nikula
2024-04-08 9:24 ` [PATCH v2 6/7] drm/crtc-helper: switch to drm device based logging and warns Jani Nikula
2024-04-08 12:38 ` Ville Syrjälä
2024-04-08 9:24 ` [PATCH v2 7/7] drm: prefer DRM_MODE_FMT/ARG over drm_mode_debug_printmodeline() Jani Nikula
2024-04-08 12:51 ` Ville Syrjälä
2024-04-08 11:15 ` [PATCH v2 0/7] drm: debug logging improvements Thomas Zimmermann
2024-04-08 14:13 ` ✓ CI.Patch_applied: success for drm: debug logging improvements (rev2) Patchwork
2024-04-08 14:14 ` ✗ CI.checkpatch: warning " Patchwork
2024-04-08 14:15 ` ✓ CI.KUnit: success " Patchwork
2024-04-08 14:32 ` ✓ CI.Build: " Patchwork
2024-04-08 14:37 ` ✓ CI.Hooks: " Patchwork
2024-04-08 14:38 ` ✗ CI.checksparse: warning " Patchwork
2024-04-08 15:01 ` ✓ CI.BAT: success " Patchwork
2024-04-08 16:11 ` ✗ CI.FULL: failure " Patchwork
2024-04-08 18:39 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2024-04-08 18:59 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-08 23:33 ` ✗ Fi.CI.CHECKPATCH: warning for drm: debug logging improvements (rev3) Patchwork
2024-04-08 23:33 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-08 23:44 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-09 14:44 ` ✗ Fi.CI.CHECKPATCH: warning for drm: debug logging improvements (rev4) Patchwork
2024-04-09 14:44 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-09 14:51 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-10 17:14 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-15 13:44 ` [PATCH v2 0/7] drm: debug logging improvements Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f3dd5b4a33f964c6903c7a964da5397f4084aeb.1712568037.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.