All of lore.kernel.org
 help / color / mirror / Atom feed
From: Afzal Mohammed <afzal-l0cyMroinI0@public.gmane.org>
To: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Cc: Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>,
	Santhapuri Damodar
	<damodar.santhapuri-l0cyMroinI0@public.gmane.org>,
	Ravi Babu <ravibabu-l0cyMroinI0@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 2/5] usb: musb: dsps: reduce musb instance to one
Date: Fri, 2 Nov 2012 22:02:35 +0530	[thread overview]
Message-ID: <808fe9b3f94a29c704f9d3365d7bc63ec35e94a7.1351870620.git.afzal@ti.com> (raw)
In-Reply-To: <cover.1351870620.git.afzal-l0cyMroinI0@public.gmane.org>

Currently multiple phy's of the same type are not supported, hence
reduce musb instances to one. This helps in supporting at least one
instance of musb, rather than having none. Even without this, it was
observed that both instances were working (by luck), but this holds
good iff wrapper is part of Image. And it is not correct for both
controller's to be associated with same phy, here it was working
because phy is a nop one. And having wrapper as a module and
rmmod'ing would crash.

This can be reverted once multi phy support for same type is available
and driver is enhanced to make use of it.

Signed-off-by: Afzal Mohammed <afzal-l0cyMroinI0@public.gmane.org>
---
 drivers/usb/musb/musb_dsps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index 2396bcd..524c003 100644
--- a/drivers/usb/musb/musb_dsps.c
+++ b/drivers/usb/musb/musb_dsps.c
@@ -677,7 +677,7 @@ static const struct dsps_musb_wrapper ti81xx_driver_data __devinitconst = {
 	.rxep_bitmap		= (0xfffe << 16),
 	.musb_core_offset	= 0x400,
 	.poll_seconds		= 2,
-	.instances		= 2,
+	.instances		= 1,
 };
 
 static const struct platform_device_id musb_dsps_id_table[] __devinitconst = {
-- 
1.7.12

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2012-11-02 16:32 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02 16:31 [PATCH 0/5] usb: musb: am335x support Afzal Mohammed
2012-11-02 16:32 ` [PATCH 1/5] usb: musb: dsps: remove platform callback Afzal Mohammed
     [not found] ` <cover.1351870620.git.afzal-l0cyMroinI0@public.gmane.org>
2012-11-02 16:32   ` Afzal Mohammed [this message]
2012-11-02 16:32   ` [PATCH 3/5] usb: musb: dsps: get resources by index Afzal Mohammed
2012-11-02 16:32 ` [PATCH 4/5] usb: musb: dsps: dt binding - add resources, example Afzal Mohammed
2012-11-06 13:02   ` Felipe Balbi
     [not found]     ` <20121106130245.GK11931-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-06 14:37       ` Afzal Mohammed
2012-11-02 16:32 ` [PATCH 5/5] usb: musb: dsps: control module handling (quirk) Afzal Mohammed
2012-11-02 19:36 ` [PATCH 0/5] usb: musb: am335x support Daniel Mack
2012-11-03  2:40   ` B, Ravi
2012-11-03  7:33   ` Mohammed, Afzal
     [not found]     ` <C8443D0743D26F4388EA172BF4E2A7A93EA0A1F2-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2013-03-01 21:57       ` Daniel Mack
     [not found]         ` <51312430.6060306-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-02  1:36           ` Daniel Mack
2013-03-02 16:05         ` Koen Kooi
2013-03-02 17:00           ` Daniel Mack
2013-03-03 22:24         ` Peter Korsgaard
2013-03-03 23:53           ` Daniel Mack
     [not found]             ` <5133E268.5010604-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-07 12:51               ` Daniel Mack
     [not found]                 ` <51388D64.9000005-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-08 16:44                   ` Daniel Mack
     [not found]                     ` <513A1580.90303-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-19 13:10                       ` Daniel Mack
2013-03-19 13:27                         ` Peter Korsgaard
     [not found]                           ` <87620nwmd2.fsf-D6SC8u56vOOJDPpyT6T3/w@public.gmane.org>
2013-04-03 12:00                             ` Daniel Mack
     [not found]                               ` <515C19D7.6080702-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-03 12:04                                 ` Felipe Balbi
     [not found]                                   ` <20130403120454.GX25837-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-04-03 12:11                                     ` Daniel Mack
2013-04-03 12:43                                   ` Daniel Mack
     [not found]                                     ` <515C23D4.3010206-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-03 13:09                                       ` Felipe Balbi
     [not found]                                         ` <20130403130807.GB14680-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-04-03 13:12                                           ` Koen Kooi
2013-04-03 13:16                                             ` Daniel Mack
2013-04-03 13:46                                               ` Felipe Balbi
     [not found]                                             ` <62C108BE-894A-4F1D-BE85-14DB3217120E-QLwJDigV5abLmq1fohREcCpxlwaOVQ5f@public.gmane.org>
2013-04-03 13:44                                               ` Felipe Balbi
2013-04-04  5:10                                         ` B, Ravi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=808fe9b3f94a29c704f9d3365d7bc63ec35e94a7.1351870620.git.afzal@ti.com \
    --to=afzal-l0cymroini0@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=damodar.santhapuri-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ravibabu-l0cyMroinI0@public.gmane.org \
    --cc=rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.