All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com,
	manasi.d.navare@intel.com
Subject: [Intel-gfx] [PATCH v2 15/19] drm/i915/dg2: configure TRANS_DP2_CTL for DP 2.0
Date: Mon, 23 Aug 2021 19:18:16 +0300	[thread overview]
Message-ID: <8201bc4b2b0cbc7038333771e9379227bf7f2c6e.1629735412.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1629735412.git.jani.nikula@intel.com>

Set the DP 2.0 128b/132b channel encoding for UHBR rates.

v2: Fix UHBR port clock check, use intel_dp_is_uhbr()

Bspec: 54128
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com> # v1
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 203a54f905f6..d885a4c0fb39 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -407,6 +407,20 @@ static u32 bdw_trans_port_sync_master_select(enum transcoder master_transcoder)
 		return master_transcoder + 1;
 }
 
+static void
+intel_ddi_config_transcoder_dp2(struct intel_encoder *encoder,
+				const struct intel_crtc_state *crtc_state)
+{
+	struct drm_i915_private *i915 = to_i915(encoder->base.dev);
+	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
+	u32 val = 0;
+
+	if (intel_dp_is_uhbr(crtc_state))
+		val = TRANS_DP2_128B132B_CHANNEL_CODING;
+
+	intel_de_write(i915, TRANS_DP2_CTL(cpu_transcoder), val);
+}
+
 /*
  * Returns the TRANS_DDI_FUNC_CTL value based on CRTC state.
  *
@@ -2375,7 +2389,8 @@ static void dg2_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	 */
 	intel_ddi_enable_pipe_clock(encoder, crtc_state);
 
-	/* 5.b Not relevant to i915 for now */
+	/* 5.b Configure transcoder for DP 2.0 128b/132b */
+	intel_ddi_config_transcoder_dp2(encoder, crtc_state);
 
 	/*
 	 * 5.c Configure TRANS_DDI_FUNC_CTL DDI Select, DDI Mode Select & MST
-- 
2.20.1


  parent reply	other threads:[~2021-08-23 16:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 16:18 [Intel-gfx] [PATCH v2 00/19] drm/i915/dp: dp 2.0 enabling prep work Jani Nikula
2021-08-23 16:18 ` [PATCH v2 01/19] drm/dp: add DP 2.0 UHBR link rate and bw code conversions Jani Nikula
2021-08-23 16:18   ` [Intel-gfx] " Jani Nikula
2021-08-23 16:18 ` [PATCH v2 02/19] drm/dp: use more of the extended receiver cap Jani Nikula
2021-08-23 16:18   ` [Intel-gfx] " Jani Nikula
2021-08-23 16:18 ` [PATCH v2 03/19] drm/dp: add LTTPR DP 2.0 DPCD addresses Jani Nikula
2021-08-23 16:18   ` [Intel-gfx] " Jani Nikula
2021-08-23 16:18 ` [PATCH v2 04/19] drm/dp: add helper for extracting adjust 128b/132b TX FFE preset Jani Nikula
2021-08-23 16:18   ` [Intel-gfx] " Jani Nikula
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 05/19] drm/i915/dp: use actual link rate values in struct link_config_limits Jani Nikula
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 06/19] drm/i915/dp: read sink UHBR rates Jani Nikula
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 07/19] drm/i915/dg2: add TRANS_DP2_CTL register definition Jani Nikula
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 08/19] drm/i915/dg2: add DG2+ TRANS_DDI_FUNC_CTL DP 2.0 128b/132b mode Jani Nikula
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 09/19] drm/i915/dg2: add TRANS_DP2_VFREQHIGH and TRANS_DP2_VFREQLOW Jani Nikula
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 10/19] drm/i915/dg2: add DG2 UHBR source rates Jani Nikula
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 11/19] drm/i915/dp: add max data rate calculation for UHBR rates Jani Nikula
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 12/19] drm/i915/dp: add helper for checking for UHBR link rate Jani Nikula
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 13/19] drm/i915/dp: use 128b/132b TPS2 for UHBR+ link rates Jani Nikula
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 14/19] drm/i915/dp: select 128b/132b channel encoding for UHBR rates Jani Nikula
2021-08-23 16:18 ` Jani Nikula [this message]
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 16/19] drm/i915/dp: add HAS_DP20 macro Jani Nikula
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 17/19] drm/i915/dg2: use 128b/132b transcoder DDI mode Jani Nikula
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 18/19] drm/i915/dg2: configure TRANS_DP2_VFREQ{HIGH, LOW} for 128b/132b Jani Nikula
2021-08-23 16:18 ` [Intel-gfx] [PATCH v2 19/19] drm/i915/dg2: update link training " Jani Nikula
2021-08-23 16:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: dp 2.0 enabling prep work (rev2) Patchwork
2021-08-23 17:00 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-08-23 17:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-08-23 19:32 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8201bc4b2b0cbc7038333771e9379227bf7f2c6e.1629735412.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=manasi.d.navare@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.