All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Kiraly <me@boldcoder.com>
To: linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org
Cc: Len Brown <lenb@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Dan Williams <dan.j.williams@intel.com>
Subject: Patch: Make ACPI subsystem provide CEDT table
Date: Mon, 24 Jan 2022 22:30:22 -0800	[thread overview]
Message-ID: <82f254a1-c765-0a87-f017-8c07c8ef07cd@boldcoder.com> (raw)
In-Reply-To: <1b871357-2231-336d-099c-cdccae03f837@boldcoder.com>

This is a simple ACPI patch. I'm submitting a revised version to 
linux-acpi per Rafael Wysocki and linux-cxl per Dan Williams.

The patch has been moved to the message body and a Signed-off-by tag has 
been added. Thunderbird has added CRs so "patch -p1 -l" is needed. To 
address other points:

Q. Dan Williams said: Yes, although I don't see much incremental benefit 
to developers publishing a root only raw table... So, not opposed to the 
patch, but I want to direct you to the sysfs representation of the CEDT 
and CFMWS in /sys/bus/cxl/devices... Platform firmware CXL details are 
modeled as "CXL root" objects in the /sys/bus/cxl device model.

A. The patch is being submitted in connection with work on a CXL bridge. 
The developers would like to express appreciation for the "sysfs" point. 
They find it useful to be able to do initialization through the table 
but will look at the "sysfs" approach.

Q. Rafael J. Wysocki said: I'm not sure why the #ifdef is needed.

A. I reviewed cxl-next and decided to add the #ifdef to ensure that the 
code would compile regardless of the direction that the codebase takes.

==== start of patch ====
Subject: Make ACPI subsystem provide CEDT table
Signed-off-by: Robert Kiraly <me@boldcoder.com>

This is a simple patch to the ACPI subsystem. The patch adds ACPI
_SIG_CEDT to table_sigs[] in  "drivers/acpi/tables.c".

Presently,  CXL code isn't able to make use of the  CEDT table at
the initrd stage. Subsequent to the change, the CEDT table can be
used.

If  a developer  plans to use the CEDT table to  program  the CXL
ports,  this change is needed.  Otherwise,  it isn't  expected to
make a difference.

I certify  compliance with  Developer’s Certificate of Origin 1.1
as listed in:
https://www.kernel.org/doc/html/v4.10/process/submitting-patches.
html

--- linux-5.16.old/drivers/acpi/tables.c
+++ linux-5.16/drivers/acpi/tables.c
@@ -500,6 +500,9 @@
  	ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
  	ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
  	ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
+#ifdef ACPI_SIG_CEDT
+       ACPI_SIG_CEDT,
+#endif
  	ACPI_SIG_NHLT };

  #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
==== end of patch ====



       reply	other threads:[~2022-01-25  6:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1b871357-2231-336d-099c-cdccae03f837@boldcoder.com>
2022-01-25  6:30 ` Robert Kiraly [this message]
2022-01-25 14:49   ` Patch: Make ACPI subsystem provide CEDT table Rafael J. Wysocki
2022-01-26  3:12     ` Robert Kiraly
2022-01-26 15:55       ` Rafael J. Wysocki
2022-01-27 10:15   ` Robert Kiraly
2022-02-04 18:45     ` Rafael J. Wysocki
2022-02-04 19:34       ` Robert Kiraly
2022-01-12 23:07 Robert Kiraly
2022-01-13 11:38 ` Rafael J. Wysocki
2022-01-20 18:49 ` Rafael J. Wysocki
2022-01-20 19:06   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82f254a1-c765-0a87-f017-8c07c8ef07cd@boldcoder.com \
    --to=me@boldcoder.com \
    --cc=dan.j.williams@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.