All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denton Liu <liu.denton@gmail.com>
To: Git Mailing List <git@vger.kernel.org>,
	Paul Mackerras <paulus@ozlabs.org>
Cc: Denton Liu <liu.denton@gmail.com>, Beat Bolli <dev+git@drbeat.li>
Subject: [PATCH v2 2/2] gitk: rename "commit summary" to "commit reference"
Date: Thu, 12 Dec 2019 16:44:50 -0800	[thread overview]
Message-ID: <8691ed2b84f7ee6b7c12d04d57a541bf22660333.1576197846.git.liu.denton@gmail.com> (raw)
In-Reply-To: <cover.1576197846.git.liu.denton@gmail.com>

From: Beat Bolli <dev+git@drbeat.li>

Now that the commit reference format has a canonical name, let's use this
name in gitk's UI and implementation.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
[dl: based the patch on gitk's tree]
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 gitk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gitk b/gitk
index d07e3302de..17346b4c5c 100755
--- a/gitk
+++ b/gitk
@@ -2640,7 +2640,7 @@ proc makewindow {} {
 	{mc "Diff selected -> this" command {diffvssel 1}}
 	{mc "Make patch" command mkpatch}
 	{mc "Create tag" command mktag}
-	{mc "Copy commit summary" command copysummary}
+	{mc "Copy commit reference" command copyreference}
 	{mc "Write commit to file" command writecommit}
 	{mc "Create new branch" command mkbranch}
 	{mc "Cherry-pick this commit" command cherrypick}
@@ -9426,7 +9426,7 @@ proc mktaggo {} {
     mktagcan
 }
 
-proc copysummary {} {
+proc copyreference {} {
     global rowmenuid autosellen
 
     set format "%h (%s, %ad)"
@@ -9434,10 +9434,10 @@ proc copysummary {} {
     if {$autosellen < 40} {
         lappend cmd --abbrev=$autosellen
     }
-    set summary [eval exec $cmd $rowmenuid]
+    set reference [eval exec $cmd $rowmenuid]
 
     clipboard clear
-    clipboard append $summary
+    clipboard append $reference
 }
 
 proc writecommit {} {
-- 
2.24.1.664.g198078bb5a


  parent reply	other threads:[~2019-12-13  0:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 21:39 [PATCH] gitk: use --pretty=reference for copysummary Denton Liu
2019-12-11 21:58 ` Paul Mackerras
2019-12-11 22:05   ` Junio C Hamano
2019-12-13  0:44 ` [PATCH v2 0/2] gitk: match Git's 'reference' pretty format Denton Liu
2019-12-13  0:44   ` [PATCH v2 1/2] gitk: drop quotes in copysummary format Denton Liu
2019-12-13 17:12     ` Junio C Hamano
2019-12-15  4:19     ` Paul Mackerras
2019-12-13  0:44   ` Denton Liu [this message]
2019-12-13 17:12     ` [PATCH v2 2/2] gitk: rename "commit summary" to "commit reference" Junio C Hamano
2019-12-15  4:36     ` Paul Mackerras
2019-12-13 17:04   ` [PATCH v2 0/2] gitk: match Git's 'reference' pretty format Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8691ed2b84f7ee6b7c12d04d57a541bf22660333.1576197846.git.liu.denton@gmail.com \
    --to=liu.denton@gmail.com \
    --cc=dev+git@drbeat.li \
    --cc=git@vger.kernel.org \
    --cc=paulus@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.