From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: [alsa-devel] [PATCH resend 01/11] ASoC: soc-core: add comment to jack at soc_remove_component()
Date: 04 Sep 2019 09:14:35 +0900 [thread overview]
Message-ID: <875zm8q5n8.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <877e6oq5nv.wl-kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Basically, driver which setups snd_soc_component_set_jack() need
to release it by themselves. But, as framework level robustness,
soc_remove_component() also releases it.
To avoid code reader confuse, this patch makes it clarify.
This patch makes it clarify.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
sound/soc/soc-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 2a166ab..05a2aff 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -975,7 +975,9 @@ static void soc_set_name_prefix(struct snd_soc_card *card,
static void soc_cleanup_component(struct snd_soc_component *component)
{
+ /* For framework level robustness */
snd_soc_component_set_jack(component, NULL, NULL);
+
list_del(&component->card_list);
snd_soc_dapm_free(snd_soc_component_get_dapm(component));
soc_cleanup_component_debugfs(component);
--
2.7.4
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-09-04 0:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 0:14 [alsa-devel] [PATCH resend 00/11] ASoC: soc-core cleanup Kuninori Morimoto
2019-09-04 0:14 ` Kuninori Morimoto [this message]
2019-09-04 17:53 ` [alsa-devel] Applied "ASoC: soc-core: add comment to jack at soc_remove_component()" to the asoc tree Mark Brown
2019-09-04 0:14 ` [alsa-devel] [PATCH resend 02/11] ASoC: soc-core: self contained soc_probe_link_components() Kuninori Morimoto
2019-09-09 10:07 ` [alsa-devel] Applied "ASoC: soc-core: self contained soc_probe_link_components()" to the asoc tree Mark Brown
2019-09-04 0:14 ` [alsa-devel] [PATCH resend 03/11] ASoC: soc-core: self contained soc_remove_link_components() Kuninori Morimoto
2019-09-09 10:07 ` [alsa-devel] Applied "ASoC: soc-core: self contained soc_remove_link_components()" to the asoc tree Mark Brown
2019-09-04 0:14 ` [alsa-devel] [PATCH resend 04/11] ASoC: soc-core: self contained soc_remove_link_dais() Kuninori Morimoto
2019-09-09 10:07 ` [alsa-devel] Applied "ASoC: soc-core: self contained soc_remove_link_dais()" to the asoc tree Mark Brown
2019-09-04 0:15 ` [alsa-devel] [PATCH resend 05/11] ASoC: soc-core: move soc_probe_dai() next to soc_remove_dai() Kuninori Morimoto
2019-09-09 10:07 ` [alsa-devel] Applied "ASoC: soc-core: move soc_probe_dai() next to soc_remove_dai()" to the asoc tree Mark Brown
2019-09-04 0:15 ` [alsa-devel] [PATCH resend 06/11] ASoC: soc-core: add new soc_link_init() Kuninori Morimoto
2019-09-09 10:07 ` [alsa-devel] Applied "ASoC: soc-core: add new soc_link_init()" to the asoc tree Mark Brown
2019-09-04 0:15 ` [alsa-devel] [PATCH resend 07/11] ASoC: soc-core: self contained soc_probe_link_dais() Kuninori Morimoto
2019-09-09 10:07 ` [alsa-devel] Applied "ASoC: soc-core: self contained soc_probe_link_dais()" to the asoc tree Mark Brown
2019-09-04 0:15 ` [alsa-devel] [PATCH resend 08/11] ASoC: soc-core: move soc_probe_link_dais() next to soc_remove_link_dais() Kuninori Morimoto
2019-09-09 10:07 ` [alsa-devel] Applied "ASoC: soc-core: move soc_probe_link_dais() next to soc_remove_link_dais()" to the asoc tree Mark Brown
2019-09-04 0:15 ` [alsa-devel] [PATCH resend 09/11] ASoC: soc-core: self contained soc_bind_aux_dev() Kuninori Morimoto
2019-09-09 10:07 ` [alsa-devel] Applied "ASoC: soc-core: self contained soc_bind_aux_dev()" to the asoc tree Mark Brown
2019-09-04 0:15 ` [alsa-devel] [PATCH resend 10/11] ASoC: soc-core: add soc_unbind_aux_dev() Kuninori Morimoto
2019-09-09 10:07 ` [alsa-devel] Applied "ASoC: soc-core: add soc_unbind_aux_dev()" to the asoc tree Mark Brown
2019-09-04 0:15 ` [alsa-devel] [PATCH resend 11/11] ASoC: soc-core: self contained soc_unbind_aux_dev() Kuninori Morimoto
2019-09-09 9:59 ` Mark Brown
2019-09-09 10:07 ` [alsa-devel] Applied "ASoC: soc-core: self contained soc_unbind_aux_dev()" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zm8q5n8.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.