From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: FIle copy to FAT FS on NVDIMM hits BUG_ON at fs/buffer.c:3305!
Date: Wed, 26 Jul 2017 18:23:08 +0900 [thread overview]
Message-ID: <87d18neemb.fsf@devron> (raw)
In-Reply-To: <20170726082159.GE4039@linux-x5ow.site> (Johannes Thumshirn's message of "Wed, 26 Jul 2017 10:21:59 +0200")
"Kani, Toshimitsu" <toshi.kani@hpe.com> writes:
> kernel BUG at fs/buffer.c:3305!
> invalid opcode: 0000 [#1] SMP
> :
> Workqueue: writeback wb_workfn (flush-259:0)
> task: ffff8d02595b8000 task.stack: ffffa22242400000
> RIP: 0010:try_to_free_buffers+0xd2/0xe0
> RSP: 0018:ffffa22242403830 EFLAGS: 00010246
> RAX: 00afffc000001028 RBX: 0000000000000008 RCX: ffff8d012dcf19c0
> RDX: 0000000000000000 RSI: 0000000000000008 RDI: ffffc468e3b52b80
> RBP: ffffa22242403858 R08: 0000000000000000 R09: 000000000002067c
> R10: ffff8d027ffe6000 R11: 0000000000000000 R12: 0000000000000000
> R13: ffff8d022fccdbe0 R14: ffffc468e3b52b80 R15: ffffa22242403ad0
> FS: 0000000000000000(0000) GS:ffff8d027fd40000(0000)
The locking of this path seems to be broken. The guy familiar to
bdev_write_page() path will made real fix though, The following patch
should be explaining enough what is wrong.
In short, clean_buffers() must be called before unlocking lock_page().
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---
fs/block_dev.c | 2 --
fs/mpage.c | 1 +
mm/page_io.c | 1 +
3 files changed, 2 insertions(+), 2 deletions(-)
diff -puN fs/mpage.c~bdev_write_page-fix fs/mpage.c
--- linux/fs/mpage.c~bdev_write_page-fix 2017-07-26 18:05:53.078204737 +0900
+++ linux-hirofumi/fs/mpage.c 2017-07-26 18:07:03.960043665 +0900
@@ -605,6 +605,7 @@ alloc_new:
if (!bdev_write_page(bdev, blocks[0] << (blkbits - 9),
page, wbc)) {
clean_buffers(page, first_unmapped);
+ unlock_page(page);
goto out;
}
}
diff -puN mm/page_io.c~bdev_write_page-fix mm/page_io.c
--- linux/mm/page_io.c~bdev_write_page-fix 2017-07-26 18:06:16.807150810 +0900
+++ linux-hirofumi/mm/page_io.c 2017-07-26 18:06:23.425135771 +0900
@@ -308,6 +308,7 @@ int __swap_writepage(struct page *page,
ret = bdev_write_page(sis->bdev, swap_page_sector(page), page, wbc);
if (!ret) {
+ unlock_page(page);
count_vm_event(PSWPOUT);
return 0;
}
diff -puN fs/block_dev.c~bdev_write_page-fix fs/block_dev.c
--- linux/fs/block_dev.c~bdev_write_page-fix 2017-07-26 18:08:53.490794861 +0900
+++ linux-hirofumi/fs/block_dev.c 2017-07-26 18:08:58.375783767 +0900
@@ -714,8 +714,6 @@ int bdev_write_page(struct block_device
result = ops->rw_page(bdev, sector + get_start_sect(bdev), page, true);
if (result)
end_page_writeback(page);
- else
- unlock_page(page);
blk_queue_exit(bdev->bd_queue);
return result;
}
_
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>, "Kani\,
Toshimitsu" <toshi.kani@hpe.com>,
"linux-nvdimm\@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-fsdevel\@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: FIle copy to FAT FS on NVDIMM hits BUG_ON at fs/buffer.c:3305!
Date: Wed, 26 Jul 2017 18:23:08 +0900 [thread overview]
Message-ID: <87d18neemb.fsf@devron> (raw)
In-Reply-To: <20170726082159.GE4039@linux-x5ow.site> (Johannes Thumshirn's message of "Wed, 26 Jul 2017 10:21:59 +0200")
"Kani, Toshimitsu" <toshi.kani@hpe.com> writes:
> kernel BUG at fs/buffer.c:3305!
> invalid opcode: 0000 [#1] SMP
> :
> Workqueue: writeback wb_workfn (flush-259:0)
> task: ffff8d02595b8000 task.stack: ffffa22242400000
> RIP: 0010:try_to_free_buffers+0xd2/0xe0
> RSP: 0018:ffffa22242403830 EFLAGS: 00010246
> RAX: 00afffc000001028 RBX: 0000000000000008 RCX: ffff8d012dcf19c0
> RDX: 0000000000000000 RSI: 0000000000000008 RDI: ffffc468e3b52b80
> RBP: ffffa22242403858 R08: 0000000000000000 R09: 000000000002067c
> R10: ffff8d027ffe6000 R11: 0000000000000000 R12: 0000000000000000
> R13: ffff8d022fccdbe0 R14: ffffc468e3b52b80 R15: ffffa22242403ad0
> FS: 0000000000000000(0000) GS:ffff8d027fd40000(0000)
The locking of this path seems to be broken. The guy familiar to
bdev_write_page() path will made real fix though, The following patch
should be explaining enough what is wrong.
In short, clean_buffers() must be called before unlocking lock_page().
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---
fs/block_dev.c | 2 --
fs/mpage.c | 1 +
mm/page_io.c | 1 +
3 files changed, 2 insertions(+), 2 deletions(-)
diff -puN fs/mpage.c~bdev_write_page-fix fs/mpage.c
--- linux/fs/mpage.c~bdev_write_page-fix 2017-07-26 18:05:53.078204737 +0900
+++ linux-hirofumi/fs/mpage.c 2017-07-26 18:07:03.960043665 +0900
@@ -605,6 +605,7 @@ alloc_new:
if (!bdev_write_page(bdev, blocks[0] << (blkbits - 9),
page, wbc)) {
clean_buffers(page, first_unmapped);
+ unlock_page(page);
goto out;
}
}
diff -puN mm/page_io.c~bdev_write_page-fix mm/page_io.c
--- linux/mm/page_io.c~bdev_write_page-fix 2017-07-26 18:06:16.807150810 +0900
+++ linux-hirofumi/mm/page_io.c 2017-07-26 18:06:23.425135771 +0900
@@ -308,6 +308,7 @@ int __swap_writepage(struct page *page,
ret = bdev_write_page(sis->bdev, swap_page_sector(page), page, wbc);
if (!ret) {
+ unlock_page(page);
count_vm_event(PSWPOUT);
return 0;
}
diff -puN fs/block_dev.c~bdev_write_page-fix fs/block_dev.c
--- linux/fs/block_dev.c~bdev_write_page-fix 2017-07-26 18:08:53.490794861 +0900
+++ linux-hirofumi/fs/block_dev.c 2017-07-26 18:08:58.375783767 +0900
@@ -714,8 +714,6 @@ int bdev_write_page(struct block_device
result = ops->rw_page(bdev, sector + get_start_sect(bdev), page, true);
if (result)
end_page_writeback(page);
- else
- unlock_page(page);
blk_queue_exit(bdev->bd_queue);
return result;
}
_
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2017-07-26 9:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 21:37 FIle copy to FAT FS on NVDIMM hits BUG_ON at fs/buffer.c:3305! Kani, Toshimitsu
2017-07-25 21:37 ` Kani, Toshimitsu
2017-07-25 22:22 ` Ross Zwisler
2017-07-25 22:22 ` Ross Zwisler
2017-07-25 22:27 ` Kani, Toshimitsu
2017-07-25 22:27 ` Kani, Toshimitsu
2017-07-26 8:21 ` Johannes Thumshirn
2017-07-26 8:21 ` Johannes Thumshirn
2017-07-26 9:23 ` OGAWA Hirofumi [this message]
2017-07-26 9:23 ` OGAWA Hirofumi
2017-07-26 14:23 ` Ross Zwisler
2017-07-26 14:23 ` Ross Zwisler
2017-07-26 16:08 ` Dan Williams
2017-07-26 16:08 ` Dan Williams
2017-07-26 17:03 ` Christoph Hellwig
2017-07-26 17:03 ` Christoph Hellwig
2017-07-26 17:11 ` Matthew Wilcox
2017-07-26 17:11 ` Matthew Wilcox
2017-07-27 16:12 ` Kani, Toshimitsu
2017-07-27 16:12 ` Kani, Toshimitsu
2017-07-27 18:03 ` Ross Zwisler
2017-07-27 18:03 ` Ross Zwisler
2017-07-27 18:20 ` Kani, Toshimitsu
2017-07-27 18:20 ` Kani, Toshimitsu
2017-09-20 21:04 ` Kani, Toshimitsu
2017-09-20 21:04 ` Kani, Toshimitsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d18neemb.fsf@devron \
--to=hirofumi@mail.parknet.co.jp \
--cc=jthumshirn@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.