All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: [PATCH 17/46] ASoC: qcom: apq8016_sbc: consider CPU-Platform possibility
Date: 28 Jun 2019 10:47:46 +0900	[thread overview]
Message-ID: <87lfxmv5xs.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87a7e2wkll.wl-kuninori.morimoto.gx@renesas.com>

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

commit 564684387969 ("ASoC: qcom: apq8016_sbc: don't select unnecessary
Platform")

Current ALSA SoC avoid to add duplicate component to rtd,
and this driver was selecting CPU component as Platform component.
Thus, above patch removed Platform settings from this driver,
because it assumed these are same component.

But, some CPU driver is using generic DMAEngine, in such case, both
CPU component and Platform component will have same of_node/name.
In other words, there are some components which are different but
have same of_node/name.

In such case, Card driver definitely need to select Platform even
though it is same as CPU.
It is depends on CPU driver, but is difficult to know it from Card driver.
This patch reverts above patch.

Fixes: commit 564684387969 ("ASoC: qcom: apq8016_sbc: don't select unnecessary Platform")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/qcom/apq8016_sbc.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c
index c0b0aa8..f60a719 100644
--- a/sound/soc/qcom/apq8016_sbc.c
+++ b/sound/soc/qcom/apq8016_sbc.c
@@ -150,12 +150,15 @@ static struct apq8016_sbc_data *apq8016_sbc_parse_of(struct snd_soc_card *card)
 
 	link = data->dai_link;
 
-	dlc = devm_kzalloc(dev, sizeof(*dlc), GFP_KERNEL);
+	dlc = devm_kzalloc(dev, 2 * sizeof(*dlc), GFP_KERNEL);
 	if (!dlc)
 		return ERR_PTR(-ENOMEM);
 
-	link->cpus	= dlc;
-	link->num_cpus	= 1;
+	link->cpus	= &dlc[0];
+	link->platforms	= &dlc[1];
+
+	link->num_cpus		= 1;
+	link->num_platforms	= 1;
 
 	for_each_child_of_node(node, np) {
 		cpu = of_get_child_by_name(np, "cpu");
@@ -187,6 +190,7 @@ static struct apq8016_sbc_data *apq8016_sbc_parse_of(struct snd_soc_card *card)
 			goto error;
 		}
 
+		link->platforms->of_node = link->cpus->of_node;
 		ret = of_property_read_string(np, "link-name", &link->name);
 		if (ret) {
 			dev_err(card->dev, "error getting codec dai_link name\n");
-- 
2.7.4

  parent reply	other threads:[~2019-06-28  1:47 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28  1:45 [PATCH 00/46] ASoC: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28  1:46 ` [PATCH 01/46] ASoC: vc4: vc4_htmi: " Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: vc4: vc4_htmi: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:46 ` [PATCH 02/46] ASoC: atmel: atmel-classd: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: atmel: atmel-classd: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:46 ` [PATCH 03/46] ASoC: atmel: atmel-pdmic: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: atmel: atmel-pdmic: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:46 ` [PATCH 04/46] ASoC: atmel: atmel_wm8904: consider CPU-Platform possibility unnecessary Platform" Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: atmel: atmel_wm8904: consider CPU-Platform possibility unnecessary Platform"" to the asoc tree Mark Brown
2019-06-28  1:46 ` [PATCH 05/46] ASoC: amtel: mikroe-proto: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: amtel: mikroe-proto: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` [PATCH 06/46] ASoC: atmel: sam9g20_wm8731: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: atmel: sam9g20_wm8731: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` [PATCH 07/46] ASoC: atmel: sam9x5_wm8731: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: atmel: sam9x5_wm8731: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` [PATCH 08/46] ASoC: atmel: tse850-pcm5142: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: atmel: tse850-pcm5142: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` [PATCH 09/46] ASoC: fsl: eukrea-tlv320: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: fsl: eukrea-tlv320: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` [PATCH 10/46] ASoC: fsl: fsl-asoc-card: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: fsl: fsl-asoc-card: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` [PATCH 11/46] ASoC: fsl: imx-es8328: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: fsl: imx-es8328: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` [PATCH 12/46] ASoC: fsl: imx-sgtl5000: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: fsl: imx-sgtl5000: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` [PATCH 13/46] ASoC: fsl: imx-spdif: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: fsl: imx-spdif: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` [PATCH 14/46] ASoC: fsl: imx-audmix: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: fsl: imx-audmix: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` [PATCH 15/46] ASoC: kirkwood: armada-370-db: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: kirkwood: armada-370-db: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` [PATCH 16/46] ASoC: mxs: mxs-sgtl5000: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: mxs: mxs-sgtl5000: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` Kuninori Morimoto [this message]
2019-06-28 16:56   ` Applied "ASoC: qcom: apq8016_sbc: " Mark Brown
2019-06-28  1:47 ` [PATCH 18/46] ASoC: qcom: storm: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: qcom: storm: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` [PATCH 19/46] ASoC: rockchip: rk3288_hdmi_analog: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: rockchip: rk3288_hdmi_analog: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:47 ` [PATCH 20/46] ASoC: rockchip: rockchip_max98090: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: rockchip: rockchip_max98090: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:48 ` [PATCH 21/46] ASoC: rockchip: rockchip_rt5645: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: rockchip: rockchip_rt5645: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:48 ` [PATCH 22/46] ASoC: samsung: arndale_rt5631: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: samsung: arndale_rt5631: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:48 ` [PATCH 23/46] ASoC: samsung: smdk_wm8994: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: samsung: smdk_wm8994: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:48 ` [PATCH 24/46] ASoC: samsung: snow: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: samsung: snow: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:48 ` [PATCH 25/46] ASoC: samsung: tm2_wm5110: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: samsung: tm2_wm5110: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:48 ` [PATCH 26/46] ASoC: sirf: sirf-audio: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: sirf: sirf-audio: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:48 ` [PATCH 27/46] ASoC: sunxi: sun4i-codec: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: sunxi: sun4i-codec: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:48 ` [PATCH 28/46] ASoC: tegra: tegra_alc5632: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: tegra: tegra_alc5632: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:48 ` [PATCH 29/46] ASoC: tegra: tegra_max98090: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: tegra: tegra_max98090: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:48 ` [PATCH 30/46] ASoC: tegra: tegra_rt5640: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: tegra: tegra_rt5640: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:48 ` [PATCH 31/46] ASoC: tegra: tegra_rt5677: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: tegra: tegra_rt5677: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:48 ` [PATCH 32/46] ASoC: tegra: tegra_sgtl5000: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: tegra: tegra_sgtl5000: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:49 ` [PATCH 33/46] ASoC: tegra: tegra_wm8753: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: tegra: tegra_wm8753: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:49 ` [PATCH 34/46] ASoC: tegra: tegra_wm8903: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: tegra: tegra_wm8903: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:49 ` [PATCH 35/46] ASoC: tegra: tegra_wm9712: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: tegra: tegra_wm9712: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:49 ` [PATCH 36/46] ASoC: tegra: trimslice: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: tegra: trimslice: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:49 ` [PATCH 37/46] ASoC: ti: davinci-evm: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: ti: davinci-evm: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:49 ` [PATCH 38/46] ASoC: ti: omap-abe-twl6040: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: ti: omap-abe-twl6040: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:49 ` [PATCH 39/46] ASoC: ti: omap-hdmi: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: ti: omap-hdmi: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:49 ` [PATCH 40/46] ASoC: ti: omap-twl4030: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: ti: omap-twl4030: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:49 ` [PATCH 41/46] ASoC: ti: rx51: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: ti: rx51: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:49 ` [PATCH 42/46] ASoC: ux500: mop500: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: ux500: mop500: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:49 ` [PATCH 43/46] ASoC: simple-card-utils: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: simple-card-utils: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:49 ` [PATCH 44/46] ASoC: qcom: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: qcom: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:49 ` [PATCH 45/46] ASoC: rockchip: rk3399_gru_sound: consider CPU-Platform possibility Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: rockchip: rk3399_gru_sound: consider CPU-Platform possibility" to the asoc tree Mark Brown
2019-06-28  1:50 ` [PATCH 46/46] ASoC: soc-utils: respawn dummy Platform Kuninori Morimoto
2019-06-28 16:56   ` Applied "ASoC: soc-utils: respawn dummy Platform" to the asoc tree Mark Brown
2019-07-03  6:39   ` [PATCH 46/46] ASoC: soc-utils: respawn dummy Platform Tzung-Bi Shih
2019-07-03  6:56     ` Kuninori Morimoto
2019-07-03  7:02       ` Tzung-Bi Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfxmv5xs.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.