All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: [alsa-devel] [PATCH v2 3/7] ASoC: soc-core: remove duplicate pinctrl operation when suspend
Date: 18 Dec 2019 11:45:30 +0900	[thread overview]
Message-ID: <87mubqjqr9.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87r212jqt1.wl-kuninori.morimoto.gx@renesas.com>

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

snd_soc_suspend() are doing below for pinctrl_pm_select_sleep_state()

	int snd_soc_suspend(struct device *dev)
	{
		...
		for_each_card_components(card, component) {
			...
(1)			pinctrl_pm_select_sleep_state(component->dev);
		}

		for_each_card_rtds(card, rtd) {
			...
(2)			pinctrl_pm_select_sleep_state(cpu_dai->dev);
		}
	}

(1) is called for all component (CPU/Codec/Platform), and
(2) is called for CPU DAIs.
Here, component->dev is same as dai->dev.
This means, it is called in duplicate on CPU case.
This patch removes (2).

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v2 -> v3

	- no change

 sound/soc/soc-core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index c10b9af..9b94a5a 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -619,9 +619,6 @@ int snd_soc_suspend(struct device *dev)
 
 		if (cpu_dai->driver->bus_control)
 			snd_soc_dai_suspend(cpu_dai);
-
-		/* deactivate pins to sleep state */
-		pinctrl_pm_select_sleep_state(cpu_dai->dev);
 	}
 
 	if (card->suspend_post)
-- 
2.7.4

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2019-12-18  2:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18  2:44 [alsa-devel] [PATCH 0/7 v2] ASoC: soc-core cleanup step8 Kuninori Morimoto
2019-12-18  2:45 ` [alsa-devel] [PATCH v2 1/7] ASoC: soc-core: remove snd_soc_rtdcom_list Kuninori Morimoto
2019-12-18  3:31   ` Sridharan, Ranjani
2019-12-18  3:53     ` Kuninori Morimoto
2019-12-18  2:45 ` [alsa-devel] [PATCH v2 2/7] ASoC: soc-core: care .ignore_suspend for Component suspend Kuninori Morimoto
2019-12-18  3:36   ` Sridharan, Ranjani
2019-12-18  3:59     ` Kuninori Morimoto
2019-12-18 14:54       ` Pierre-Louis Bossart
2019-12-18 17:14         ` Mark Brown
2019-12-18 17:48           ` Pierre-Louis Bossart
2019-12-18 18:06             ` Mark Brown
2019-12-18  2:45 ` Kuninori Morimoto [this message]
2019-12-18  2:46 ` [alsa-devel] [PATCH v2 4/7] ASoC: soc-core: do pinctrl_pm_select_xxx() as component Kuninori Morimoto
2019-12-18  2:46 ` [alsa-devel] [PATCH v2 5/7] ASoC: soc-core: add snd_soc_close_delayed_work() Kuninori Morimoto
2019-12-18  2:47 ` [alsa-devel] [PATCH v2 6/7] ASoC: soc-dapm: add snd_soc_dapm_stream_stop() Kuninori Morimoto
2019-12-18  2:47 ` [alsa-devel] [PATCH v2 7/7] ASoC: use snd_soc_dapm_stream_stop() for SND_SOC_DAPM_STREAM_STOP Kuninori Morimoto
2019-12-18  6:06 ` [alsa-devel] [PATCH 0/7 v2] ASoC: soc-core cleanup step8 Ranjani Sridharan
2019-12-19  5:57 ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mubqjqr9.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.