All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: [alsa-devel] [PATCH 04/13] ASoC: soc-core: create rtd->codec_dais first
Date: 10 Sep 2019 11:05:30 +0900	[thread overview]
Message-ID: <87woeglxcl.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <8736h4nby1.wl-kuninori.morimoto.gx@renesas.com>


From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

soc_new_pcm_runtime() allocs rtd and rtd->codec_dais.
This patch allocs both first, and setup these after that.
This is prepare for soc_new_pcm_runtime() cleanup.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/soc-core.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 44e1bff..fe6cafd 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -372,12 +372,6 @@ static struct snd_soc_pcm_runtime *soc_new_pcm_runtime(
 	if (!rtd)
 		return NULL;
 
-	INIT_LIST_HEAD(&rtd->component_list);
-	rtd->card = card;
-	rtd->dai_link = dai_link;
-	if (!rtd->dai_link->ops)
-		rtd->dai_link->ops = &null_snd_soc_ops;
-
 	rtd->codec_dais = kcalloc(dai_link->num_codecs,
 					sizeof(struct snd_soc_dai *),
 					GFP_KERNEL);
@@ -386,6 +380,12 @@ static struct snd_soc_pcm_runtime *soc_new_pcm_runtime(
 		return NULL;
 	}
 
+	INIT_LIST_HEAD(&rtd->component_list);
+	rtd->card = card;
+	rtd->dai_link = dai_link;
+	if (!rtd->dai_link->ops)
+		rtd->dai_link->ops = &null_snd_soc_ops;
+
 	/* see for_each_card_rtds */
 	list_add_tail(&rtd->list, &card->rtd_list);
 	rtd->num = card->num_rtd;
-- 
2.7.4

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2019-09-10  2:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10  2:04 [alsa-devel] [PATCH 00/13] ASoC: soc-core cleanup - step 3 Kuninori Morimoto
2019-09-10  2:05 ` [alsa-devel] [PATCH 01/13] ASoC: soc-core: move soc_free_pcm_runtime() Kuninori Morimoto
2019-09-10  2:05 ` [alsa-devel] [PATCH 02/13] ASoC: soc-core: merge soc_add_pcm_runtime() into soc_new_pcm_runtime() Kuninori Morimoto
2019-09-10  2:05 ` [alsa-devel] [PATCH 03/13] ASoC: soc-core: call list_del(&rtd->list) at soc_free_pcm_runtime() Kuninori Morimoto
2019-09-10  2:05 ` Kuninori Morimoto [this message]
2019-09-10  2:05 ` [alsa-devel] [PATCH 05/13] ASoC: soc-core: merge soc_new_pcm_runtime() and soc_rtd_init() Kuninori Morimoto
2019-09-10  2:05 ` [alsa-devel] [PATCH 06/13] ASoC: soc-core: merge soc_free_pcm_runtime() and soc_rtd_free() Kuninori Morimoto
2019-09-10 15:33   ` Sridharan, Ranjani
2019-09-10 23:57     ` Kuninori Morimoto
2019-09-10  2:05 ` [alsa-devel] [PATCH 07/13] ASoC: soc-core: tidyup soc_new_pcm_runtime() alloc order Kuninori Morimoto
2019-09-10  2:05 ` [alsa-devel] [PATCH 08/13] ASoC: soc-core: remove snd_soc_rtdcom_del_all() Kuninori Morimoto
2019-09-10  2:05 ` [alsa-devel] [PATCH 09/13] ASoC: soc-core: use devm_kzalloc() for rtd Kuninori Morimoto
2019-09-10 15:45   ` Sridharan, Ranjani
2019-09-10 23:54     ` Kuninori Morimoto
2019-09-10  2:06 ` [alsa-devel] [PATCH 10/13] ASoC: soc-core: remove soc_remove_dai_links() Kuninori Morimoto
2019-09-10  2:06 ` [alsa-devel] [PATCH 11/13] ASoC: soc-core: add soc_setup_card_name() Kuninori Morimoto
2019-09-10  2:06 ` [alsa-devel] [PATCH 12/13] ASoC: soc-core: use devm_xxx for component related resource Kuninori Morimoto
2019-09-10  2:06 ` [alsa-devel] [PATCH 13/13] ASoC: soc-core: setup card->rtd_num at snd_soc_instantiate_card() Kuninori Morimoto
2019-09-10 16:14   ` Sridharan, Ranjani
2019-09-11  0:00     ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woeglxcl.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.