All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Christophe Dubois <jcd@tribudubois.net>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org, jasowang@redhat.com
Cc: Jean-Christophe Dubois <jcd@tribudubois.net>
Subject: [Qemu-devel] [PATCH v4 5/8] i.MX: Fix FEC code for ECR register reset value.
Date: Thu, 19 May 2016 00:23:00 +0200	[thread overview]
Message-ID: <89f71f6406b78449a411535e24cb3decb34fbaf1.1463609668.git.jcd@tribudubois.net> (raw)
In-Reply-To: <cover.1463609668.git.jcd@tribudubois.net>

According to the FEC chapter of i.MX25 reference manual ECR register is
initialized at 0xf0000000 at reset time.

We fix the value.

Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
---

Changes since v1:
 * Not present on v1

Changes since v2:
 * Not present on v2
 
Changes since v3:
 * Not present on v3

 hw/net/imx_fec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c
index a649027..87e3c87 100644
--- a/hw/net/imx_fec.c
+++ b/hw/net/imx_fec.c
@@ -338,7 +338,7 @@ static void imx_fec_reset(DeviceState *d)
     s->eir = 0;
     s->eimr = 0;
     s->rx_enabled = 0;
-    s->ecr = 0;
+    s->ecr = 0xf0000000;
     s->mscr = 0;
     s->mibc = 0xc0000000;
     s->rcr = 0x05ee0001;
-- 
2.7.4

  parent reply	other threads:[~2016-05-18 22:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 22:22 [Qemu-devel] [PATCH v4 0/8] Add Ethernet device for i.MX6 SOC Jean-Christophe Dubois
2016-05-18 22:22 ` [Qemu-devel] [PATCH v4 1/8] net: improve UDP/TCP checksum computation Jean-Christophe Dubois
2016-05-18 22:22 ` [Qemu-devel] [PATCH v4 2/8] net: handle optional VLAN header in " Jean-Christophe Dubois
2016-05-18 22:22 ` [Qemu-devel] [PATCH v4 3/8] i.MX: Fix FEC code for MDIO operation selection Jean-Christophe Dubois
2016-05-18 22:22 ` [Qemu-devel] [PATCH v4 4/8] i.MX: Fix FEC code for MDIO address selection Jean-Christophe Dubois
2016-05-18 22:23 ` Jean-Christophe Dubois [this message]
2016-05-18 22:23 ` [Qemu-devel] [PATCH v4 6/8] i.MX: move FEC device to a register array structure Jean-Christophe Dubois
2016-05-19  3:28   ` Jason Wang
2016-05-19  6:10     ` Jean-Christophe DUBOIS
2016-05-20  2:26       ` Jason Wang
2016-05-20 21:25         ` Jean-Christophe DUBOIS
2016-05-18 22:23 ` [Qemu-devel] [PATCH v4 7/8] Add ENET/Gbps Ethernet support to FEC device Jean-Christophe Dubois
2016-05-19  3:48   ` Jason Wang
2016-05-19 18:14     ` Jean-Christophe DUBOIS
2016-05-19 18:37       ` Peter Maydell
2016-05-20 21:24         ` Jean-Christophe DUBOIS
2016-05-20  2:34       ` Jason Wang
2016-05-20 21:23         ` Jean-Christophe DUBOIS
2016-05-24  2:16           ` Jason Wang
2016-05-24 19:33             ` Jean-Christophe DUBOIS
2016-05-25  8:14               ` Jason Wang
2016-05-18 22:23 ` [Qemu-devel] [PATCH v4 8/8] Add ENET device to i.MX6 SOC Jean-Christophe Dubois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89f71f6406b78449a411535e24cb3decb34fbaf1.1463609668.git.jcd@tribudubois.net \
    --to=jcd@tribudubois.net \
    --cc=jasowang@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.