All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@kernel.org>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
	Nadav Amit <nadav.amit@gmail.com>,
	Kees Cook <keescook@chromium.org>,
	Brian Gerst <brgerst@gmail.com>,
	"kernel-hardening@lists.openwall.com" 
	<kernel-hardening@lists.openwall.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>, Jann Horn <jann@thejh.net>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Andy Lutomirski <luto@kernel.org>,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	linux-mm@kvack.org
Subject: [PATCH v2 05/13] mm: Move memcg stack accounting to account_kernel_stack
Date: Fri, 17 Jun 2016 13:00:41 -0700	[thread overview]
Message-ID: <8a17889a9d47b7b4deb41f2fcccada8bf54d4b6f.1466192946.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1466192946.git.luto@kernel.org>
In-Reply-To: <cover.1466192946.git.luto@kernel.org>

We should account for stacks regardless of stack size.  Move it into
account_kernel_stack.

Fixes: 12580e4b54ba8 ("mm: memcontrol: report kernel stack usage in cgroup2 memory.stat")
Cc: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
 kernel/fork.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index be7f006af727..cd2abe6e4e41 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -165,20 +165,12 @@ static struct thread_info *alloc_thread_info_node(struct task_struct *tsk,
 	struct page *page = alloc_kmem_pages_node(node, THREADINFO_GFP,
 						  THREAD_SIZE_ORDER);
 
-	if (page)
-		memcg_kmem_update_page_stat(page, MEMCG_KERNEL_STACK,
-					    1 << THREAD_SIZE_ORDER);
-
 	return page ? page_address(page) : NULL;
 }
 
 static inline void free_thread_info(struct thread_info *ti)
 {
-	struct page *page = virt_to_page(ti);
-
-	memcg_kmem_update_page_stat(page, MEMCG_KERNEL_STACK,
-				    -(1 << THREAD_SIZE_ORDER));
-	__free_kmem_pages(page, THREAD_SIZE_ORDER);
+	free_kmem_pages((unsigned long)ti, THREAD_SIZE_ORDER);
 }
 # else
 static struct kmem_cache *thread_info_cache;
@@ -227,6 +219,11 @@ static void account_kernel_stack(struct thread_info *ti, int account)
 
 	mod_zone_page_state(zone, NR_KERNEL_STACK_KB,
 			    THREAD_SIZE / 1024 * account);
+
+	/* All stack pages belong to the same memcg. */
+	memcg_kmem_update_page_stat(
+		virt_to_page(ti), MEMCG_KERNEL_STACK,
+		account * (THREAD_SIZE / PAGE_SIZE));
 }
 
 void free_task(struct task_struct *tsk)
-- 
2.5.5

WARNING: multiple messages have this Message-ID (diff)
From: Andy Lutomirski <luto@kernel.org>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
	Nadav Amit <nadav.amit@gmail.com>,
	Kees Cook <keescook@chromium.org>,
	Brian Gerst <brgerst@gmail.com>,
	"kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>, Jann Horn <jann@thejh.net>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Andy Lutomirski <luto@kernel.org>,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	linux-mm@kvack.org
Subject: [PATCH v2 05/13] mm: Move memcg stack accounting to account_kernel_stack
Date: Fri, 17 Jun 2016 13:00:41 -0700	[thread overview]
Message-ID: <8a17889a9d47b7b4deb41f2fcccada8bf54d4b6f.1466192946.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1466192946.git.luto@kernel.org>
In-Reply-To: <cover.1466192946.git.luto@kernel.org>

We should account for stacks regardless of stack size.  Move it into
account_kernel_stack.

Fixes: 12580e4b54ba8 ("mm: memcontrol: report kernel stack usage in cgroup2 memory.stat")
Cc: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
 kernel/fork.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index be7f006af727..cd2abe6e4e41 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -165,20 +165,12 @@ static struct thread_info *alloc_thread_info_node(struct task_struct *tsk,
 	struct page *page = alloc_kmem_pages_node(node, THREADINFO_GFP,
 						  THREAD_SIZE_ORDER);
 
-	if (page)
-		memcg_kmem_update_page_stat(page, MEMCG_KERNEL_STACK,
-					    1 << THREAD_SIZE_ORDER);
-
 	return page ? page_address(page) : NULL;
 }
 
 static inline void free_thread_info(struct thread_info *ti)
 {
-	struct page *page = virt_to_page(ti);
-
-	memcg_kmem_update_page_stat(page, MEMCG_KERNEL_STACK,
-				    -(1 << THREAD_SIZE_ORDER));
-	__free_kmem_pages(page, THREAD_SIZE_ORDER);
+	free_kmem_pages((unsigned long)ti, THREAD_SIZE_ORDER);
 }
 # else
 static struct kmem_cache *thread_info_cache;
@@ -227,6 +219,11 @@ static void account_kernel_stack(struct thread_info *ti, int account)
 
 	mod_zone_page_state(zone, NR_KERNEL_STACK_KB,
 			    THREAD_SIZE / 1024 * account);
+
+	/* All stack pages belong to the same memcg. */
+	memcg_kmem_update_page_stat(
+		virt_to_page(ti), MEMCG_KERNEL_STACK,
+		account * (THREAD_SIZE / PAGE_SIZE));
 }
 
 void free_task(struct task_struct *tsk)
-- 
2.5.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Andy Lutomirski <luto@kernel.org>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
	Nadav Amit <nadav.amit@gmail.com>,
	Kees Cook <keescook@chromium.org>,
	Brian Gerst <brgerst@gmail.com>,
	"kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>, Jann Horn <jann@thejh.net>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Andy Lutomirski <luto@kernel.org>,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	linux-mm@kvack.org
Subject: [kernel-hardening] [PATCH v2 05/13] mm: Move memcg stack accounting to account_kernel_stack
Date: Fri, 17 Jun 2016 13:00:41 -0700	[thread overview]
Message-ID: <8a17889a9d47b7b4deb41f2fcccada8bf54d4b6f.1466192946.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1466192946.git.luto@kernel.org>
In-Reply-To: <cover.1466192946.git.luto@kernel.org>

We should account for stacks regardless of stack size.  Move it into
account_kernel_stack.

Fixes: 12580e4b54ba8 ("mm: memcontrol: report kernel stack usage in cgroup2 memory.stat")
Cc: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
 kernel/fork.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index be7f006af727..cd2abe6e4e41 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -165,20 +165,12 @@ static struct thread_info *alloc_thread_info_node(struct task_struct *tsk,
 	struct page *page = alloc_kmem_pages_node(node, THREADINFO_GFP,
 						  THREAD_SIZE_ORDER);
 
-	if (page)
-		memcg_kmem_update_page_stat(page, MEMCG_KERNEL_STACK,
-					    1 << THREAD_SIZE_ORDER);
-
 	return page ? page_address(page) : NULL;
 }
 
 static inline void free_thread_info(struct thread_info *ti)
 {
-	struct page *page = virt_to_page(ti);
-
-	memcg_kmem_update_page_stat(page, MEMCG_KERNEL_STACK,
-				    -(1 << THREAD_SIZE_ORDER));
-	__free_kmem_pages(page, THREAD_SIZE_ORDER);
+	free_kmem_pages((unsigned long)ti, THREAD_SIZE_ORDER);
 }
 # else
 static struct kmem_cache *thread_info_cache;
@@ -227,6 +219,11 @@ static void account_kernel_stack(struct thread_info *ti, int account)
 
 	mod_zone_page_state(zone, NR_KERNEL_STACK_KB,
 			    THREAD_SIZE / 1024 * account);
+
+	/* All stack pages belong to the same memcg. */
+	memcg_kmem_update_page_stat(
+		virt_to_page(ti), MEMCG_KERNEL_STACK,
+		account * (THREAD_SIZE / PAGE_SIZE));
 }
 
 void free_task(struct task_struct *tsk)
-- 
2.5.5

  parent reply	other threads:[~2016-06-17 20:03 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17 20:00 [PATCH v2 00/13] Virtually mapped stacks with guard pages (x86, core) Andy Lutomirski
2016-06-17 20:00 ` [kernel-hardening] " Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 01/13] x86/mm/hotplug: Don't remove PGD entries in remove_pagetable() Andy Lutomirski
2016-06-17 20:00   ` [kernel-hardening] " Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 02/13] x86/cpa: In populate_pgd, don't set the pgd entry until it's populated Andy Lutomirski
2016-06-17 20:00   ` [kernel-hardening] " Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 03/13] x86/cpa: Warn if kernel_unmap_pages_in_pgd is used inappropriately Andy Lutomirski
2016-06-17 20:00   ` [kernel-hardening] " Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:30   ` Borislav Petkov
2016-06-17 20:30     ` [kernel-hardening] " Borislav Petkov
2016-06-17 20:30     ` Borislav Petkov
2016-06-18 10:29     ` Andy Lutomirski
2016-06-18 10:29       ` [kernel-hardening] " Andy Lutomirski
2016-06-18 10:29       ` Andy Lutomirski
2016-06-18 10:37       ` Borislav Petkov
2016-06-18 10:37         ` [kernel-hardening] " Borislav Petkov
2016-06-18 10:37         ` Borislav Petkov
2016-06-17 20:00 ` [PATCH v2 04/13] mm: Track NR_KERNEL_STACK in KiB instead of number of stacks Andy Lutomirski
2016-06-17 20:00   ` [kernel-hardening] " Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-20 13:16   ` Michal Hocko
2016-06-20 13:16     ` [kernel-hardening] " Michal Hocko
2016-06-20 13:16     ` Michal Hocko
2016-06-20 13:16     ` Michal Hocko
2016-06-17 20:00 ` Andy Lutomirski [this message]
2016-06-17 20:00   ` [kernel-hardening] [PATCH v2 05/13] mm: Move memcg stack accounting to account_kernel_stack Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:55   ` Josh Poimboeuf
2016-06-17 20:55     ` [kernel-hardening] " Josh Poimboeuf
2016-06-17 20:55     ` Josh Poimboeuf
2016-06-17 20:55     ` Josh Poimboeuf
2016-06-17 22:18     ` Andy Lutomirski
2016-06-17 22:18       ` [kernel-hardening] " Andy Lutomirski
2016-06-17 22:18       ` Andy Lutomirski
2016-06-17 22:18       ` Andy Lutomirski
2016-06-20 13:02   ` Michal Hocko
2016-06-20 13:02     ` [kernel-hardening] " Michal Hocko
2016-06-20 13:02     ` Michal Hocko
2016-06-20 13:02     ` Michal Hocko
2016-06-20 16:05     ` Andy Lutomirski
2016-06-20 16:05       ` [kernel-hardening] " Andy Lutomirski
2016-06-20 16:05       ` Andy Lutomirski
2016-06-20 16:05       ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 06/13] fork: Add generic vmalloced stack support Andy Lutomirski
2016-06-17 20:00   ` [kernel-hardening] " Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:57   ` Josh Poimboeuf
2016-06-17 20:57     ` [kernel-hardening] " Josh Poimboeuf
2016-06-17 20:57     ` Josh Poimboeuf
2016-06-17 22:18     ` Andy Lutomirski
2016-06-17 22:18       ` [kernel-hardening] " Andy Lutomirski
2016-06-17 22:18       ` Andy Lutomirski
2016-06-20 13:36   ` Michal Hocko
2016-06-20 13:36     ` [kernel-hardening] " Michal Hocko
2016-06-20 13:36     ` Michal Hocko
2016-06-20 13:36     ` Michal Hocko
2016-06-20 16:13     ` Andy Lutomirski
2016-06-20 16:13       ` [kernel-hardening] " Andy Lutomirski
2016-06-20 16:13       ` Andy Lutomirski
2016-06-21  8:46       ` Michal Hocko
2016-06-21  8:46         ` [kernel-hardening] " Michal Hocko
2016-06-21  8:46         ` Michal Hocko
2016-06-21 17:01         ` Andy Lutomirski
2016-06-21 17:01           ` [kernel-hardening] " Andy Lutomirski
2016-06-21 17:01           ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 07/13] x86/die: Don't try to recover from an OOPS on a non-default stack Andy Lutomirski
2016-06-17 20:00   ` [kernel-hardening] " Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 08/13] x86/dumpstack: When OOPSing, rewind the stack before do_exit Andy Lutomirski
2016-06-17 20:00   ` [kernel-hardening] " Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 09/13] x86/dumpstack: When dumping stack bytes due to OOPS, start with regs->sp Andy Lutomirski
2016-06-17 20:00   ` [kernel-hardening] " Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 10/13] x86/dumpstack: Try harder to get a call trace on stack overflow Andy Lutomirski
2016-06-17 20:00   ` [kernel-hardening] " Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 11/13] x86/dumpstack/64: Handle faults when printing the "Stack:" part of an OOPS Andy Lutomirski
2016-06-17 20:00   ` [kernel-hardening] " Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 12/13] x86/mm/64: Enable vmapped stacks Andy Lutomirski
2016-06-17 20:00   ` [kernel-hardening] " Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 13/13] x86/mm: Improve stack-overflow #PF handling Andy Lutomirski
2016-06-17 20:00   ` [kernel-hardening] " Andy Lutomirski
2016-06-17 20:00   ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a17889a9d47b7b4deb41f2fcccada8bf54d4b6f.1466192946.git.luto@kernel.org \
    --to=luto@kernel.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jann@thejh.net \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=nadav.amit@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vdavydov@virtuozzo.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.