All of lore.kernel.org
 help / color / mirror / Atom feed
From: han.lu@intel.com
To: tiwai@suse.de, liam.r.girdwood@linux.intel.com,
	bernard.gautier@intel.com, edward.c.popescu@intel.com,
	alsa-devel@alsa-project.org
Cc: "Lu, Han" <han.lu@intel.com>
Subject: [PATCH 2/3] alsabat: add standalone mode
Date: Tue, 15 Mar 2016 11:18:53 +0800	[thread overview]
Message-ID: <8c11985dbf81d6bcbe62b30600c478f7fc7f0d40.1458011641.git.han.lu@intel.com> (raw)
In-Reply-To: <cover.1458011641.git.han.lu@intel.com>
In-Reply-To: <cover.1458011641.git.han.lu@intel.com>

From: "Lu, Han" <han.lu@intel.com>

Add support for standalone mode where alsabat will run on a
different machine to the one being tested.
In standalone mode, the alsabat just generates, playback and
capture sound data like in normal mode, but does not analyze.
The alsabat being built without libfftw3 support is always work
in standalone mode.
The alsabat in normal mode can also bypass data analysis using
option "--standalone".

Signed-off-by: Lu, Han <han.lu@intel.com>

diff --git a/bat/Makefile.am b/bat/Makefile.am
index 8dfafa9..5646e9a 100644
--- a/bat/Makefile.am
+++ b/bat/Makefile.am
@@ -6,7 +6,6 @@ EXTRA_DIST = alsabat.1
 alsabat_SOURCES = \
 	bat.c \
 	common.c \
-	analyze.c \
 	signal.c \
 	convert.c \
 	alsa.c
@@ -15,8 +14,12 @@ noinst_HEADERS = \
 	common.h \
 	bat-signal.h \
 	alsa.h \
-	convert.h \
-	analyze.h
+	convert.h
+
+if HAVE_LIBFFTW3
+alsabat_SOURCES += analyze.c
+noinst_HEADERS += analyze.h
+endif
 
 AM_CPPFLAGS = \
 	      -Wall -I$(top_srcdir)/include
diff --git a/bat/alsabat.1 b/bat/alsabat.1
index 8d0b9c0..5f41669 100644
--- a/bat/alsabat.1
+++ b/bat/alsabat.1
@@ -120,6 +120,15 @@ Internal loopback mode.
 Playback, capture and analysis internal to ALSABAT only. This is intended
 for developers to test new ALSABAT features as no audio is routed outside
 of ALSABAT.
+.TP
+\fI\-\-standalone\fP
+Add support for standalone mode where ALSABAT will run on a different machine
+to the one being tested.
+In standalone mode, the sound data can be generated, playback and captured
+just like in normal mode, but will not be analyzed.
+The ALSABAT being built without libfftw3 support is always in standalone mode.
+The ALSABAT in normal mode can also bypass data analysis using option
+"--standalone".
 
 .SH EXAMPLES
 
diff --git a/bat/bat.c b/bat/bat.c
index 9c637f2..85ec5aa 100644
--- a/bat/bat.c
+++ b/bat/bat.c
@@ -33,7 +33,9 @@
 
 #include "alsa.h"
 #include "convert.h"
+#ifdef HAVE_LIBFFTW3
 #include "analyze.h"
+#endif
 
 static int get_duration(struct bat *bat)
 {
@@ -289,6 +291,7 @@ _("Usage: alsabat [-options]...\n"
 "      --file=#           file for playback\n"
 "      --saveplay=#       file that storing playback content, for debug\n"
 "      --local            internal loop, set to bypass pcm hardware devices\n"
+"      --standalone       standalone mode, to bypass analysis\n"
 ));
 	fprintf(bat->log, _("Recognized sample formats are: %s %s %s %s\n"),
 			snd_pcm_format_name(SND_PCM_FORMAT_U8),
@@ -339,6 +342,7 @@ static void parse_arguments(struct bat *bat, int argc, char *argv[])
 		{"file",     1, 0, OPT_READFILE},
 		{"saveplay", 1, 0, OPT_SAVEPLAY},
 		{"local",    0, 0, OPT_LOCAL},
+		{"standalone", 0, 0, OPT_STANDALONE},
 		{0, 0, 0, 0}
 	};
 
@@ -357,6 +361,9 @@ static void parse_arguments(struct bat *bat, int argc, char *argv[])
 		case OPT_LOCAL:
 			bat->local = true;
 			break;
+		case OPT_STANDALONE:
+			bat->standalone = true;
+			break;
 		case 'D':
 			if (bat->playback.device == NULL)
 				bat->playback.device = optarg;
@@ -601,7 +608,12 @@ int main(int argc, char *argv[])
 		test_loopback(&bat);
 
 analyze:
-	err = analyze_capture(&bat);
+#ifdef HAVE_LIBFFTW3
+	if (!bat.standalone)
+		err = analyze_capture(&bat);
+#else
+	fprintf(bat.log, _("No libfftw3 library. Exit without analysis.\n"));
+#endif
 out:
 	fprintf(bat.log, _("\nReturn value is %d\n"), err);
 
diff --git a/bat/common.h b/bat/common.h
index 5417c0e..30e39fc 100644
--- a/bat/common.h
+++ b/bat/common.h
@@ -23,6 +23,7 @@
 #define OPT_READFILE			(OPT_BASE + 2)
 #define OPT_SAVEPLAY			(OPT_BASE + 3)
 #define OPT_LOCAL			(OPT_BASE + 4)
+#define OPT_STANDALONE			(OPT_BASE + 5)
 
 #define COMPOSE(a, b, c, d)		((a) | ((b)<<8) | ((c)<<16) | ((d)<<24))
 #define WAV_RIFF			COMPOSE('R', 'I', 'F', 'F')
@@ -150,6 +151,7 @@ struct bat {
 	char *narg;			/* argument string of duration */
 	char *logarg;			/* path name of log file */
 	char *debugplay;		/* path name to store playback signal */
+	bool standalone;		/* enable to bypass analysis */
 
 	struct pcm playback;
 	struct pcm capture;
diff --git a/configure.ac b/configure.ac
index bdb133c..f6f8103 100644
--- a/configure.ac
+++ b/configure.ac
@@ -70,7 +70,9 @@ if test x$bat = xtrue; then
   FFTW_INC=""
   FFTW_LIB=""
   FFTW_CFLAGS=""
-  AC_CHECK_LIB([fftw3], [fftw_malloc], , [AC_MSG_ERROR([Error: need FFTW3 library])])
+  dnl Check for libfftw3
+  have_libfftw3="yes"
+  AC_CHECK_LIB([fftw3], [fftw_malloc], , [have_libfftw3="no"])
   AC_CHECK_LIB([m], [sqrtf], , [AC_MSG_ERROR([Error: Need sqrtf])])
   AC_CHECK_LIB([pthread], [pthread_create], , [AC_MSG_ERROR([Error: need PTHREAD library])])
   FFTW_CFLAGS="$CFLAGS"
@@ -83,6 +85,7 @@ if test x$bat = xtrue; then
   AC_SUBST(FFTW_CFLAGS)
 
 fi
+AM_CONDITIONAL(HAVE_LIBFFTW3, test "$have_libfftw3" = "yes")
 
 dnl Check for librt
 LIBRT=""
-- 
2.5.0

  parent reply	other threads:[~2016-03-15  3:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15  3:18 [PATCH 0/3] *** new features for alsabat *** han.lu
2016-03-15  3:18 ` [PATCH 1/3] alsabat: add default device name for playback and capture han.lu
2016-03-15  3:18 ` han.lu [this message]
2016-03-15  3:18 ` [PATCH 3/3] alsabat: add bash test script han.lu
2016-03-15  9:02 ` [PATCH 0/3] *** new features for alsabat *** Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c11985dbf81d6bcbe62b30600c478f7fc7f0d40.1458011641.git.han.lu@intel.com \
    --to=han.lu@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bernard.gautier@intel.com \
    --cc=edward.c.popescu@intel.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.