From: Kailang <kailang@realtek.com>
To: "Takashi Iwai (tiwai@suse.de)" <tiwai@suse.de>
Cc: " (alsa-devel@alsa-project.org)" <alsa-devel@alsa-project.org>
Subject: Fixed GPIO2 value assigned
Date: Mon, 13 Feb 2023 07:20:17 +0000 [thread overview]
Message-ID: <8d02bb9ac8134f878cd08607fdf088fd@realtek.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 212 bytes --]
Hi Takashi,
This fix was GPIO2 value 0x3 change to 0x4.
GPIO2 GPIO1 GPIO0
1 0 0 ==> 0x4 ==> GPIO2 HIGH
GPIO2 GPIO1 GPIO0
0 1 1 ==> 0x3 ==> GPIO0 and GPIO1 HIGH
BR,
Kailang
[-- Attachment #2: 0000-gpio2-high.patch --]
[-- Type: application/octet-stream, Size: 855 bytes --]
From 76ecb6b4597daf2d034ae7f9566fce611bb72d72 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Mon, 13 Feb 2023 14:54:22 +0800
Subject: [PATCH] ALSA: hda/realtek - fixed wrong gpio assigned
GPIO2 PIN use for output. Mask Dir and Data need to assign for 0x4. Not 0x3.
This fixed was for Lenovo Desktop(0x17aa1056). GPIO2 use for AMP enable.
Signed-off-by: Kailang Yang <kailang@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 1134a493d225..14b84a1f43d3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -832,7 +832,7 @@ static int alc_subsystem_id(struct hda_codec *codec, const hda_nid_t *ports)
alc_setup_gpio(codec, 0x02);
break;
case 7:
- alc_setup_gpio(codec, 0x03);
+ alc_setup_gpio(codec, 0x04);
break;
case 5:
default:
next reply other threads:[~2023-02-13 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 7:20 Kailang [this message]
2023-02-13 8:10 ` Fixed GPIO2 value assigned Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d02bb9ac8134f878cd08607fdf088fd@realtek.com \
--to=kailang@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.