From: Jason Gunthorpe <jgg@nvidia.com>
To: Cornelia Huck <cohuck@redhat.com>, kvm@vger.kernel.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
"Raj, Ashok" <ashok.raj@intel.com>,
Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,
Neo Jia <cjia@nvidia.com>,
Dan Williams <dan.j.williams@intel.com>,
Christoph Hellwig <hch@lst.de>, Jike Song <jike.song@intel.com>,
Kirti Wankhede <kwankhede@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Tarun Gupta <targupta@nvidia.com>
Subject: [PATCH 09/18] vfio/mdev: Add missing error handling to dev_set_name()
Date: Tue, 23 Mar 2021 14:55:26 -0300 [thread overview]
Message-ID: <9-v1-7dedf20b2b75+4f785-vfio2_jgg@nvidia.com> (raw)
In-Reply-To: <0-v1-7dedf20b2b75+4f785-vfio2_jgg@nvidia.com>
This can fail, and seems to be a popular target for syzkaller error
injection. Check the error return and unwind with put_device().
Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
drivers/vfio/mdev/mdev_core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c
index 517b6fd351b63a..4b5e372ed58f26 100644
--- a/drivers/vfio/mdev/mdev_core.c
+++ b/drivers/vfio/mdev/mdev_core.c
@@ -258,7 +258,9 @@ int mdev_device_create(struct mdev_type *type, const guid_t *uuid)
list_add(&mdev->next, &mdev_list);
mutex_unlock(&mdev_list_lock);
- dev_set_name(&mdev->dev, "%pUl", uuid);
+ ret = dev_set_name(&mdev->dev, "%pUl", uuid);
+ if (ret)
+ goto mdev_fail;
/* Check if parent unregistration has started */
if (!down_read_trylock(&parent->unreg_sem)) {
--
2.31.0
next prev parent reply other threads:[~2021-03-23 17:56 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 17:55 [PATCH 00/18] Make vfio_mdev type safe Jason Gunthorpe
2021-03-23 17:55 ` [Intel-gfx] " Jason Gunthorpe
2021-03-23 17:55 ` Jason Gunthorpe
2021-03-23 17:55 ` [PATCH 01/18] vfio/mdev: Fix missing static's on MDEV_TYPE_ATTR's Jason Gunthorpe
2021-03-23 17:55 ` [PATCH 02/18] vfio/mdev: Add missing typesafety around mdev_device Jason Gunthorpe
2021-03-26 2:04 ` Tian, Kevin
2021-03-30 15:24 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 03/18] vfio/mdev: Simplify driver registration Jason Gunthorpe
2021-03-23 19:14 ` Christoph Hellwig
2021-03-26 12:10 ` Jason Gunthorpe
2021-03-26 12:55 ` Christoph Hellwig
2021-03-26 2:17 ` Tian, Kevin
2021-03-30 15:28 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 04/18] vfio/mdev: Use struct mdev_type in struct mdev_device Jason Gunthorpe
2021-03-23 19:15 ` Christoph Hellwig
2021-03-26 2:29 ` Tian, Kevin
2021-04-06 18:41 ` Jason Gunthorpe
2021-03-30 15:31 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 05/18] vfio/mdev: Do not allow a mdev_type to have a NULL parent pointer Jason Gunthorpe
2021-03-23 19:15 ` Christoph Hellwig
2021-04-06 16:08 ` Jason Gunthorpe
2021-03-26 2:38 ` Tian, Kevin
2021-03-29 8:42 ` Max Gurtovoy
2021-03-30 15:34 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 06/18] vfio/mdev: Expose mdev_get/put_parent to mdev_private.h Jason Gunthorpe
2021-03-23 19:16 ` Christoph Hellwig
2021-03-26 2:47 ` Tian, Kevin
2021-03-30 15:37 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 07/18] vfio/mdev: Add missing reference counting to mdev_type Jason Gunthorpe
2021-03-23 19:17 ` Christoph Hellwig
2021-03-26 2:52 ` Tian, Kevin
2021-03-30 15:38 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 08/18] vfio/mdev: Reorganize mdev_device_create() Jason Gunthorpe
2021-03-23 19:20 ` Christoph Hellwig
2021-03-26 3:33 ` Tian, Kevin
2021-03-26 3:36 ` Tian, Kevin
2021-04-06 16:40 ` Jason Gunthorpe
2021-03-26 3:31 ` Tian, Kevin
2021-03-30 15:50 ` Cornelia Huck
2021-03-23 17:55 ` Jason Gunthorpe [this message]
2021-03-23 19:21 ` [PATCH 09/18] vfio/mdev: Add missing error handling to dev_set_name() Christoph Hellwig
2021-03-26 3:35 ` Tian, Kevin
2021-03-29 8:50 ` Max Gurtovoy
2021-03-30 15:53 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 10/18] vfio/mdev: Remove duplicate storage of parent in mdev_device Jason Gunthorpe
2021-03-23 19:22 ` Christoph Hellwig
2021-03-26 3:53 ` Tian, Kevin
2021-03-26 11:53 ` Jason Gunthorpe
2021-03-30 16:14 ` Cornelia Huck
2021-03-30 16:50 ` Jason Gunthorpe
2021-03-30 16:15 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 11/18] vfio/mdev: Add mdev/mtype_get_type_group_id() Jason Gunthorpe
2021-03-23 19:23 ` Christoph Hellwig
2021-04-06 18:53 ` Jason Gunthorpe
2021-03-26 5:52 ` Tian, Kevin
2021-03-30 16:26 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 12/18] vfio/mtty: Use mdev_get_type_group_id() Jason Gunthorpe
2021-03-23 19:24 ` Christoph Hellwig
2021-03-23 17:55 ` [PATCH 13/18] vfio/mdpy: " Jason Gunthorpe
2021-03-23 19:25 ` Christoph Hellwig
2021-03-23 17:55 ` [PATCH 14/18] vfio/mbochs: " Jason Gunthorpe
2021-03-23 19:25 ` Christoph Hellwig
2021-03-23 17:55 ` [PATCH 15/18] vfio/gvt: Make DRM_I915_GVT depend on VFIO_MDEV Jason Gunthorpe
2021-03-23 17:55 ` [Intel-gfx] " Jason Gunthorpe
2021-03-23 19:26 ` Christoph Hellwig
2021-03-23 19:39 ` Jason Gunthorpe
2021-03-23 19:39 ` [Intel-gfx] " Jason Gunthorpe
2021-03-30 4:39 ` Zhenyu Wang
2021-03-30 4:39 ` Zhenyu Wang
2021-03-26 6:03 ` Tian, Kevin
2021-03-26 6:03 ` Tian, Kevin
2021-03-23 17:55 ` [PATCH 16/18] vfio/gvt: Use mdev_get_type_group_id() Jason Gunthorpe
2021-03-23 17:55 ` [Intel-gfx] " Jason Gunthorpe
2021-03-23 19:28 ` Christoph Hellwig
2021-03-26 6:09 ` Tian, Kevin
2021-03-26 6:09 ` [Intel-gfx] " Tian, Kevin
2021-03-23 17:55 ` [PATCH 17/18] vfio/mdev: Remove kobj from mdev_parent_ops->create() Jason Gunthorpe
2021-03-23 17:55 ` [Intel-gfx] " Jason Gunthorpe
2021-03-23 17:55 ` Jason Gunthorpe
2021-03-23 19:29 ` Christoph Hellwig
2021-03-23 19:29 ` [Intel-gfx] " Christoph Hellwig
2021-03-26 6:11 ` Tian, Kevin
2021-03-26 6:11 ` [Intel-gfx] " Tian, Kevin
2021-03-26 6:11 ` Tian, Kevin
2021-03-30 16:29 ` Cornelia Huck
2021-03-30 16:29 ` [Intel-gfx] " Cornelia Huck
2021-03-30 16:29 ` Cornelia Huck
2021-03-23 17:55 ` [PATCH 18/18] vfio/mdev: Correct the function signatures for the mdev_type_attributes Jason Gunthorpe
2021-03-23 17:55 ` [Intel-gfx] " Jason Gunthorpe
2021-03-23 17:55 ` Jason Gunthorpe
2021-03-23 19:31 ` Christoph Hellwig
2021-03-23 19:31 ` [Intel-gfx] " Christoph Hellwig
2021-04-06 18:34 ` Jason Gunthorpe
2021-04-06 18:34 ` [Intel-gfx] " Jason Gunthorpe
2021-04-06 18:34 ` Jason Gunthorpe
2021-03-26 7:03 ` Tian, Kevin
2021-03-26 7:03 ` [Intel-gfx] " Tian, Kevin
2021-03-26 7:03 ` Tian, Kevin
2021-03-30 16:35 ` Cornelia Huck
2021-03-30 16:35 ` [Intel-gfx] " Cornelia Huck
2021-03-30 16:35 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9-v1-7dedf20b2b75+4f785-vfio2_jgg@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=cjia@nvidia.com \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=jike.song@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=mgurtovoy@nvidia.com \
--cc=targupta@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.