From: Nicholas Fraser <nfraser@codeweavers.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
"Frank Ch. Eigler" <fche@redhat.com>,
Song Liu <songliubraving@fb.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kim Phillips <kim.phillips@amd.com>,
Tommi Rantala <tommi.t.rantala@nokia.com>,
Remi Bernon <rbernon@codeweavers.com>,
linux-kernel@vger.kernel.org
Cc: Ulrich Czekalla <uczekalla@codeweavers.com>,
Huw Davies <huw@codeweavers.com>
Subject: [PATCH 1/2] perf report: Remove redundant libbfd checks
Date: Tue, 16 Feb 2021 15:37:20 -0500 [thread overview]
Message-ID: <94758ca1-0031-d7c6-6c6a-900fd77ef695@codeweavers.com> (raw)
In-Reply-To: <d1c87379-8837-a5e7-eb44-f063ca0f4766@codeweavers.com>
This removes the redundant checks bfd_check_format() and
bfd_target_elf_flavour. They were previously checking different files.
---
tools/perf/util/symbol.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 492c873713cc..08f6f57c84fd 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1586,15 +1586,6 @@ int dso__load_bfd_symbols(struct dso *dso, const char *debugfile)
if (section)
dso->text_offset = section->vma - section->filepos;
- if (!bfd_check_format(abfd, bfd_object)) {
- pr_debug2("%s: cannot read %s bfd file.\n", __func__,
- debugfile);
- goto out_close;
- }
-
- if (bfd_get_flavour(abfd) == bfd_target_elf_flavour)
- goto out_close;
-
symbols_size = bfd_get_symtab_upper_bound(abfd);
if (symbols_size == 0) {
bfd_close(abfd);
--
2.30.1
next prev parent reply other threads:[~2021-02-16 20:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 19:17 [PATCH 0/4] perf: Fix archive/debugcache PE files Nicholas Fraser
2021-02-16 20:37 ` Nicholas Fraser [this message]
2021-02-16 21:05 ` [PATCH 1/2] perf report: Remove redundant libbfd checks Nicholas Fraser
2021-02-16 21:06 ` [PATCH 2/2] perf buildid-cache: Add test for 16-byte build-id Nicholas Fraser
2021-02-17 19:53 ` Jiri Olsa
2021-02-18 19:39 ` [PATCH 1/2] perf report: Remove redundant libbfd checks Arnaldo Carvalho de Melo
2021-02-18 19:42 ` Nicholas Fraser
2021-02-18 19:45 ` Arnaldo Carvalho de Melo
2021-02-16 20:38 ` [PATCH 2/2] perf buildid-cache: Add test for 16-byte build-id Nicholas Fraser
2021-02-16 21:04 ` Nicholas Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94758ca1-0031-d7c6-6c6a-900fd77ef695@codeweavers.com \
--to=nfraser@codeweavers.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=fche@redhat.com \
--cc=huw@codeweavers.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rbernon@codeweavers.com \
--cc=songliubraving@fb.com \
--cc=tommi.t.rantala@nokia.com \
--cc=uczekalla@codeweavers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.