All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 07/10] drm/i915: extract i915_suspend.h from i915_drv.h
Date: Thu,  8 Aug 2019 16:42:46 +0300	[thread overview]
Message-ID: <94f2884a3e5611c3e1f015104afb965e47bd8992.1565271681.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1565271681.git.jani.nikula@intel.com>

It used to be handy that we only had a couple of headers, but over time
i915_drv.h has become unwieldy. Extract declarations to a separate
header file corresponding to the implementation module, clarifying the
modularity of the driver.

Ensure the new header is self-contained, and do so with minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.

No functional changes.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c     |  1 +
 drivers/gpu/drm/i915/i915_drv.h     |  4 ----
 drivers/gpu/drm/i915/i915_suspend.c |  1 +
 drivers/gpu/drm/i915/i915_suspend.h | 14 ++++++++++++++
 4 files changed, 16 insertions(+), 4 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/i915_suspend.h

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 6621da4f4f18..6af31a4d9308 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -70,6 +70,7 @@
 #include "i915_irq.h"
 #include "i915_perf.h"
 #include "i915_query.h"
+#include "i915_suspend.h"
 #include "i915_sysfs.h"
 #include "i915_trace.h"
 #include "i915_vgpu.h"
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index b9f6c443ef7c..f3118bd1d751 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2498,10 +2498,6 @@ int intel_engine_cmd_parser(struct intel_engine_cs *engine,
 			    u32 batch_len,
 			    bool is_master);
 
-/* i915_suspend.c */
-int i915_save_state(struct drm_i915_private *dev_priv);
-int i915_restore_state(struct drm_i915_private *dev_priv);
-
 /* intel_device_info.c */
 static inline struct intel_device_info *
 mkwrite_device_info(struct drm_i915_private *dev_priv)
diff --git a/drivers/gpu/drm/i915/i915_suspend.c b/drivers/gpu/drm/i915/i915_suspend.c
index e41cf73a9737..8508a01ad8b9 100644
--- a/drivers/gpu/drm/i915/i915_suspend.c
+++ b/drivers/gpu/drm/i915/i915_suspend.c
@@ -31,6 +31,7 @@
 
 #include "i915_drv.h"
 #include "i915_reg.h"
+#include "i915_suspend.h"
 
 static void i915_save_display(struct drm_i915_private *dev_priv)
 {
diff --git a/drivers/gpu/drm/i915/i915_suspend.h b/drivers/gpu/drm/i915/i915_suspend.h
new file mode 100644
index 000000000000..3a36fb4ecc05
--- /dev/null
+++ b/drivers/gpu/drm/i915/i915_suspend.h
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2019 Intel Corporation
+ */
+
+#ifndef __I915_SUSPEND_H__
+#define __I915_SUSPEND_H__
+
+struct drm_i915_private;
+
+int i915_save_state(struct drm_i915_private *i915);
+int i915_restore_state(struct drm_i915_private *i915);
+
+#endif /* __I915_SUSPEND_H__ */
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-08-08 13:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08 13:42 [PATCH 00/10] drm/i915: header cleanup of the day Jani Nikula
2019-08-08 13:42 ` [PATCH 01/10] drm/i915: remove unused dev_priv->no_aux_handshake Jani Nikula
2019-08-08 13:44   ` Chris Wilson
2019-08-08 13:42 ` [PATCH 02/10] drm/i915: move add_taint_for_CI() to i915_utils.h Jani Nikula
2019-08-08 13:42 ` [PATCH 03/10] drm/i915: move I915_STATE_WARN() and _ON() to intel_display.h Jani Nikula
2019-08-08 13:42 ` [PATCH 04/10] drm/i915: move printing and load error inject to i915_utils.[ch] Jani Nikula
2019-08-08 13:42 ` [PATCH 05/10] drm/i915: extract i915_perf.h from i915_drv.h Jani Nikula
2019-08-08 13:42 ` [PATCH 06/10] drm/i915: extract i915_sysfs.h " Jani Nikula
2019-08-08 13:42 ` Jani Nikula [this message]
2019-08-08 13:42 ` [PATCH 08/10] drm/i915: extract i915_memcpy.h " Jani Nikula
2019-08-08 13:42 ` [PATCH 09/10] drm/i915: extract gem/i915_gem_stolen.h " Jani Nikula
2019-08-08 13:42 ` [PATCH 10/10] drm/i915: extract i915_gem_shrinker.h " Jani Nikula
2019-08-08 13:54 ` [PATCH 00/10] drm/i915: header cleanup of the day Chris Wilson
2019-08-09  9:53   ` Jani Nikula
2019-08-08 14:51 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-08-08 14:57 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-08-08 15:16 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-09  0:24 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94f2884a3e5611c3e1f015104afb965e47bd8992.1565271681.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.