From: Sanchayan Maity <maitysanchayan@gmail.com> To: broonie@kernel.org Cc: stefan@agner.ch, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Sanchayan Maity <maitysanchayan@gmail.com> Subject: [PATCH v2 4/4] spi: spi-fsl-dspi: Minor code cleanup and error path fixes Date: Mon, 21 Nov 2016 11:24:04 +0530 [thread overview] Message-ID: <971874d8e662622c0cfe478adaa4c75b08388d0e.1479706671.git.maitysanchayan@gmail.com> (raw) In-Reply-To: <cover.1479706671.git.maitysanchayan@gmail.com> In-Reply-To: <cover.1479706671.git.maitysanchayan@gmail.com> Code cleanup for improving code readability and error path fixes and cleanup removing use of devm_kfree. Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com> --- drivers/spi/spi-fsl-dspi.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index 08882f7..2987a16 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -226,8 +226,10 @@ static void dspi_rx_dma_callback(void *arg) if (!(dspi->dataflags & TRAN_STATE_RX_VOID)) { for (i = 0; i < dma->curr_xfer_len; i++) { d = dspi->dma->rx_dma_buf[i]; - rx_word ? (*(u16 *)dspi->rx = d) : - (*(u8 *)dspi->rx = d); + if (rx_word) + *(u16 *)dspi->rx = d; + else + *(u8 *)dspi->rx = d; dspi->rx += rx_word + 1; } } @@ -247,14 +249,20 @@ static int dspi_next_xfer_dma_submit(struct fsl_dspi *dspi) tx_word = is_double_byte_mode(dspi); for (i = 0; i < dma->curr_xfer_len - 1; i++) { - val = tx_word ? *(u16 *) dspi->tx : *(u8 *) dspi->tx; + if (tx_word) + val = *(u16 *) dspi->tx; + else + val = *(u8 *) dspi->tx; dspi->dma->tx_dma_buf[i] = SPI_PUSHR_TXDATA(val) | SPI_PUSHR_PCS(dspi->cs) | SPI_PUSHR_CTAS(0) | SPI_PUSHR_CONT; dspi->tx += tx_word + 1; } - val = tx_word ? *(u16 *) dspi->tx : *(u8 *) dspi->tx; + if (tx_word) + val = *(u16 *) dspi->tx; + else + val = *(u8 *) dspi->tx; dspi->dma->tx_dma_buf[i] = SPI_PUSHR_TXDATA(val) | SPI_PUSHR_PCS(dspi->cs) | SPI_PUSHR_CTAS(0); @@ -430,9 +438,11 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr) return 0; err_slave_config: - devm_kfree(dev, dma->rx_dma_buf); + dma_free_coherent(dev, DSPI_DMA_BUFSIZE, + dma->rx_dma_buf, dma->rx_dma_phys); err_rx_dma_buf: - devm_kfree(dev, dma->tx_dma_buf); + dma_free_coherent(dev, DSPI_DMA_BUFSIZE, + dma->tx_dma_buf, dma->tx_dma_phys); err_tx_dma_buf: dma_release_channel(dma->chan_tx); err_tx_channel: -- 2.10.2
WARNING: multiple messages have this Message-ID (diff)
From: maitysanchayan@gmail.com (Sanchayan Maity) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 4/4] spi: spi-fsl-dspi: Minor code cleanup and error path fixes Date: Mon, 21 Nov 2016 11:24:04 +0530 [thread overview] Message-ID: <971874d8e662622c0cfe478adaa4c75b08388d0e.1479706671.git.maitysanchayan@gmail.com> (raw) In-Reply-To: <cover.1479706671.git.maitysanchayan@gmail.com> Code cleanup for improving code readability and error path fixes and cleanup removing use of devm_kfree. Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com> --- drivers/spi/spi-fsl-dspi.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index 08882f7..2987a16 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -226,8 +226,10 @@ static void dspi_rx_dma_callback(void *arg) if (!(dspi->dataflags & TRAN_STATE_RX_VOID)) { for (i = 0; i < dma->curr_xfer_len; i++) { d = dspi->dma->rx_dma_buf[i]; - rx_word ? (*(u16 *)dspi->rx = d) : - (*(u8 *)dspi->rx = d); + if (rx_word) + *(u16 *)dspi->rx = d; + else + *(u8 *)dspi->rx = d; dspi->rx += rx_word + 1; } } @@ -247,14 +249,20 @@ static int dspi_next_xfer_dma_submit(struct fsl_dspi *dspi) tx_word = is_double_byte_mode(dspi); for (i = 0; i < dma->curr_xfer_len - 1; i++) { - val = tx_word ? *(u16 *) dspi->tx : *(u8 *) dspi->tx; + if (tx_word) + val = *(u16 *) dspi->tx; + else + val = *(u8 *) dspi->tx; dspi->dma->tx_dma_buf[i] = SPI_PUSHR_TXDATA(val) | SPI_PUSHR_PCS(dspi->cs) | SPI_PUSHR_CTAS(0) | SPI_PUSHR_CONT; dspi->tx += tx_word + 1; } - val = tx_word ? *(u16 *) dspi->tx : *(u8 *) dspi->tx; + if (tx_word) + val = *(u16 *) dspi->tx; + else + val = *(u8 *) dspi->tx; dspi->dma->tx_dma_buf[i] = SPI_PUSHR_TXDATA(val) | SPI_PUSHR_PCS(dspi->cs) | SPI_PUSHR_CTAS(0); @@ -430,9 +438,11 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr) return 0; err_slave_config: - devm_kfree(dev, dma->rx_dma_buf); + dma_free_coherent(dev, DSPI_DMA_BUFSIZE, + dma->rx_dma_buf, dma->rx_dma_phys); err_rx_dma_buf: - devm_kfree(dev, dma->tx_dma_buf); + dma_free_coherent(dev, DSPI_DMA_BUFSIZE, + dma->tx_dma_buf, dma->tx_dma_phys); err_tx_dma_buf: dma_release_channel(dma->chan_tx); err_tx_channel: -- 2.10.2
next prev parent reply other threads:[~2016-11-21 6:03 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-21 5:54 [PATCH v2 0/4] Fixes for Vybrid SPI DMA implementation Sanchayan Maity 2016-11-21 5:54 ` Sanchayan Maity 2016-11-21 5:54 ` Sanchayan Maity 2016-11-21 5:54 ` [PATCH v2 1/4] spi: spi-fsl-dspi: Fix SPI transfer issue when using multiple SPI_IOC_MESSAGE Sanchayan Maity 2016-11-21 5:54 ` Sanchayan Maity 2016-11-21 5:54 ` Sanchayan Maity 2016-11-21 19:18 ` Mark Brown 2016-11-21 19:18 ` Mark Brown 2016-11-21 19:18 ` Mark Brown 2016-11-21 19:14 ` maitysanchayan 2016-11-21 19:14 ` maitysanchayan at gmail.com 2016-11-21 19:14 ` maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w 2016-11-21 19:18 ` maitysanchayan 2016-11-21 19:18 ` maitysanchayan at gmail.com 2016-11-22 16:22 ` Mark Brown 2016-11-22 16:22 ` Mark Brown 2016-11-22 16:22 ` Mark Brown 2016-11-21 5:54 ` [PATCH v2 2/4] spi: spi-fsl-dspi: Fix continuous selection format Sanchayan Maity 2016-11-21 5:54 ` Sanchayan Maity 2016-11-21 5:54 ` Sanchayan Maity 2016-11-21 23:15 ` Stefan Agner 2016-11-21 23:15 ` Stefan Agner 2016-11-22 6:11 ` maitysanchayan 2016-11-22 6:11 ` maitysanchayan at gmail.com 2016-11-22 6:11 ` maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w 2016-11-21 5:54 ` [PATCH v2 3/4] spi: spi-fsl-dspi: Fix incorrect DMA setup Sanchayan Maity 2016-11-21 5:54 ` Sanchayan Maity 2016-11-21 23:16 ` Stefan Agner 2016-11-21 23:16 ` Stefan Agner 2016-11-21 23:16 ` Stefan Agner 2016-11-22 17:26 ` Applied "spi: spi-fsl-dspi: Fix incorrect DMA setup" to the spi tree Mark Brown 2016-11-22 17:26 ` Mark Brown 2016-11-21 5:54 ` Sanchayan Maity [this message] 2016-11-21 5:54 ` [PATCH v2 4/4] spi: spi-fsl-dspi: Minor code cleanup and error path fixes Sanchayan Maity 2016-11-21 23:22 ` Stefan Agner 2016-11-21 23:22 ` Stefan Agner 2016-11-21 23:22 ` Stefan Agner 2016-11-22 6:12 ` maitysanchayan 2016-11-22 6:12 ` maitysanchayan at gmail.com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=971874d8e662622c0cfe478adaa4c75b08388d0e.1479706671.git.maitysanchayan@gmail.com \ --to=maitysanchayan@gmail.com \ --cc=broonie@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=stefan@agner.ch \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.