All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms+renesas@verge.net.au>
To: linux-renesas-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	Magnus Damm <magnus.damm@gmail.com>,
	Simon Horman <horms+renesas@verge.net.au>
Subject: [PATCH 21/42] ARM: dts: r8a7778: Use R-Car GPIO Gen1 fallback compat string
Date: Fri, 20 Oct 2017 12:28:48 +0200	[thread overview]
Message-ID: <9b43ba66f145127025cf82a35f47f228ea936935.1508493785.git.horms+renesas@verge.net.au> (raw)
In-Reply-To: <cover.1508493785.git.horms+renesas@verge.net.au>

Use newly added R-Car GPIO Gen1 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in DT of r8a7778 SoC.

As the driver does not match on "renesas,gpio-r8a7778" there
are some run-time considerations for this patch:

* When a resulting DTB is used with kernels newer than v4.14 this should
  not have any run-time effect as renesas,rcar-gen1-gpio is matched by the
  driver since commit dbd1dad2ab8f ("gpio: rcar: add gen[123] fallback
  compatibility strings")

* However, when used with older kernels GPIO will be disabled as
  no compat string match will be made by the driver.

The regression documented above for the new DTB with old kernel case
is acceptable in my opinion.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a7778.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778.dtsi
index 8f3156c0e575..a31817b2dda7 100644
--- a/arch/arm/boot/dts/r8a7778.dtsi
+++ b/arch/arm/boot/dts/r8a7778.dtsi
@@ -88,7 +88,7 @@
 	};
 
 	gpio0: gpio@ffc40000 {
-		compatible = "renesas,gpio-r8a7778", "renesas,gpio-rcar";
+		compatible = "renesas,gpio-r8a7778", "renesas,rcar-gen1-gpio";
 		reg = <0xffc40000 0x2c>;
 		interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
 		#gpio-cells = <2>;
@@ -99,7 +99,7 @@
 	};
 
 	gpio1: gpio@ffc41000 {
-		compatible = "renesas,gpio-r8a7778", "renesas,gpio-rcar";
+		compatible = "renesas,gpio-r8a7778", "renesas,rcar-gen1-gpio";
 		reg = <0xffc41000 0x2c>;
 		interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
 		#gpio-cells = <2>;
@@ -110,7 +110,7 @@
 	};
 
 	gpio2: gpio@ffc42000 {
-		compatible = "renesas,gpio-r8a7778", "renesas,gpio-rcar";
+		compatible = "renesas,gpio-r8a7778", "renesas,rcar-gen1-gpio";
 		reg = <0xffc42000 0x2c>;
 		interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
 		#gpio-cells = <2>;
@@ -121,7 +121,7 @@
 	};
 
 	gpio3: gpio@ffc43000 {
-		compatible = "renesas,gpio-r8a7778", "renesas,gpio-rcar";
+		compatible = "renesas,gpio-r8a7778", "renesas,rcar-gen1-gpio";
 		reg = <0xffc43000 0x2c>;
 		interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
 		#gpio-cells = <2>;
@@ -132,7 +132,7 @@
 	};
 
 	gpio4: gpio@ffc44000 {
-		compatible = "renesas,gpio-r8a7778", "renesas,gpio-rcar";
+		compatible = "renesas,gpio-r8a7778", "renesas,rcar-gen1-gpio";
 		reg = <0xffc44000 0x2c>;
 		interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
 		#gpio-cells = <2>;
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: horms+renesas@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 21/42] ARM: dts: r8a7778: Use R-Car GPIO Gen1 fallback compat string
Date: Fri, 20 Oct 2017 12:28:48 +0200	[thread overview]
Message-ID: <9b43ba66f145127025cf82a35f47f228ea936935.1508493785.git.horms+renesas@verge.net.au> (raw)
In-Reply-To: <cover.1508493785.git.horms+renesas@verge.net.au>

Use newly added R-Car GPIO Gen1 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in DT of r8a7778 SoC.

As the driver does not match on "renesas,gpio-r8a7778" there
are some run-time considerations for this patch:

* When a resulting DTB is used with kernels newer than v4.14 this should
  not have any run-time effect as renesas,rcar-gen1-gpio is matched by the
  driver since commit dbd1dad2ab8f ("gpio: rcar: add gen[123] fallback
  compatibility strings")

* However, when used with older kernels GPIO will be disabled as
  no compat string match will be made by the driver.

The regression documented above for the new DTB with old kernel case
is acceptable in my opinion.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a7778.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778.dtsi
index 8f3156c0e575..a31817b2dda7 100644
--- a/arch/arm/boot/dts/r8a7778.dtsi
+++ b/arch/arm/boot/dts/r8a7778.dtsi
@@ -88,7 +88,7 @@
 	};
 
 	gpio0: gpio at ffc40000 {
-		compatible = "renesas,gpio-r8a7778", "renesas,gpio-rcar";
+		compatible = "renesas,gpio-r8a7778", "renesas,rcar-gen1-gpio";
 		reg = <0xffc40000 0x2c>;
 		interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
 		#gpio-cells = <2>;
@@ -99,7 +99,7 @@
 	};
 
 	gpio1: gpio at ffc41000 {
-		compatible = "renesas,gpio-r8a7778", "renesas,gpio-rcar";
+		compatible = "renesas,gpio-r8a7778", "renesas,rcar-gen1-gpio";
 		reg = <0xffc41000 0x2c>;
 		interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
 		#gpio-cells = <2>;
@@ -110,7 +110,7 @@
 	};
 
 	gpio2: gpio at ffc42000 {
-		compatible = "renesas,gpio-r8a7778", "renesas,gpio-rcar";
+		compatible = "renesas,gpio-r8a7778", "renesas,rcar-gen1-gpio";
 		reg = <0xffc42000 0x2c>;
 		interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
 		#gpio-cells = <2>;
@@ -121,7 +121,7 @@
 	};
 
 	gpio3: gpio at ffc43000 {
-		compatible = "renesas,gpio-r8a7778", "renesas,gpio-rcar";
+		compatible = "renesas,gpio-r8a7778", "renesas,rcar-gen1-gpio";
 		reg = <0xffc43000 0x2c>;
 		interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
 		#gpio-cells = <2>;
@@ -132,7 +132,7 @@
 	};
 
 	gpio4: gpio at ffc44000 {
-		compatible = "renesas,gpio-r8a7778", "renesas,gpio-rcar";
+		compatible = "renesas,gpio-r8a7778", "renesas,rcar-gen1-gpio";
 		reg = <0xffc44000 0x2c>;
 		interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
 		#gpio-cells = <2>;
-- 
2.11.0

  parent reply	other threads:[~2017-10-20 10:30 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-20 10:29 [GIT PULL] Second Round of Renesas ARM Based SoC DT Updates for v4.15 Simon Horman
2017-10-20 10:29 ` Simon Horman
2017-10-20 10:28 ` [PATCH 01/42] ARM: dts: gr-peach: Fix 'leds' node name indent Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 02/42] ARM: dts: gr-peach: Enable MTU2 timer pulse unit Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 03/42] ARM: dts: r8a7790: Use generic node name for VSP1 nodes Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 04/42] ARM: dts: r8a7791: " Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 05/42] ARM: dts: r8a7792: " Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 06/42] ARM: dts: r8a7794: " Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 07/42] ARM: dts: iwg20d-q7: Rework DT architecture Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 08/42] ARM: dts: iwg20d-q7-dbcm-ca: Add device trees for camera DB Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 09/42] ARM: dts: r8a7790: add cpu capacity-dmips-mhz information Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 10/42] ARM: dts: r8a7745: Add internal PCI bridge nodes Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 11/42] ARM: dts: r8a7745: Add USB PHY DT support Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 12/42] ARM: dts: r8a7745: Link PCI USB devices to USB PHY Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 13/42] ARM: dts: iwg22d-sodimm: Enable internal PCI Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 14/42] ARM: dts: iwg22d-sodimm: Enable USB PHY Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 15/42] ARM: dts: r8a7743: Add HS-USB device node Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 16/42] ARM: dts: iwg20d-q7: Enable HS-USB Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 17/42] ARM: dts: r8a7743: Add USB-DMAC device nodes Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 18/42] ARM: dts: r8a7743: Enable DMA for HSUSB Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 19/42] ARM: dts: gr-peach: Add ETHER pin group Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 20/42] ARM: dts: gr-peach: Enable ostm0 and ostm1 timers Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` Simon Horman [this message]
2017-10-20 10:28   ` [PATCH 21/42] ARM: dts: r8a7778: Use R-Car GPIO Gen1 fallback compat string Simon Horman
2017-10-20 10:28 ` [PATCH 22/42] ARM: dts: r8a7779: " Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 23/42] ARM: dts: r8a7743: Use R-Car GPIO Gen2 " Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 24/42] ARM: dts: r8a7790: " Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 25/42] ARM: dts: r8a7791: " Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 26/42] ARM: dts: r8a7792: " Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 27/42] ARM: dts: r8a7793: " Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 28/42] ARM: dts: r8a7794: " Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 29/42] ARM: dts: r8a73a4: Add clock for CA15 CPU0 core Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 30/42] ARM: dts: r8a7743: Add missing clock for secondary CA15 CPU core Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 31/42] ARM: dts: r8a7778: Add clock for CA9 " Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:28 ` [PATCH 32/42] ARM: dts: r8a7779: Add clocks for CA9 CPU cores Simon Horman
2017-10-20 10:28   ` Simon Horman
2017-10-20 10:29 ` [PATCH 33/42] ARM: dts: r8a7790: Add missing clocks for secondary CA15 " Simon Horman
2017-10-20 10:29   ` Simon Horman
2017-10-20 10:29 ` [PATCH 34/42] ARM: dts: r8a7790: Add clocks for CA7 " Simon Horman
2017-10-20 10:29   ` Simon Horman
2017-10-20 10:29 ` [PATCH 35/42] ARM: dts: r8a7791: Add missing clock for secondary CA15 CPU core Simon Horman
2017-10-20 10:29   ` Simon Horman
2017-10-20 10:29 ` [PATCH 36/42] ARM: dts: r8a7792: " Simon Horman
2017-10-20 10:29   ` Simon Horman
2017-10-20 10:29 ` [PATCH 37/42] ARM: dts: r8a7793: " Simon Horman
2017-10-20 10:29   ` Simon Horman
2017-10-20 10:29 ` [PATCH 38/42] ARM: dts: r8a7794: Add missing clock for secondary CA7 " Simon Horman
2017-10-20 10:29   ` Simon Horman
2017-10-20 10:29 ` [PATCH 39/42] ARM: dts: sh73a0: Add clocks for CA9 CPU cores Simon Horman
2017-10-20 10:29   ` Simon Horman
2017-10-20 10:29 ` [PATCH 40/42] dt-bindings: clk: r7s72100: Add missing I and G clocks Simon Horman
2017-10-20 10:29   ` Simon Horman
2017-10-20 10:29 ` [PATCH 41/42] ARM: dts: r7s72100: Add clock for CA9 CPU core Simon Horman
2017-10-20 10:29   ` Simon Horman
2017-10-20 10:29 ` [PATCH 42/42] ARM: dts: r8a7743: Add xhci support to SoC dtsi Simon Horman
2017-10-20 10:29   ` Simon Horman
2017-10-30 11:04 ` [GIT PULL] Second Round of Renesas ARM Based SoC DT Updates for v4.15 Arnd Bergmann
2017-10-30 11:04   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b43ba66f145127025cf82a35f47f228ea936935.1508493785.git.horms+renesas@verge.net.au \
    --to=horms+renesas@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.