All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: cip-dev@lists.cip-project.org
Cc: Quirin Gylstorff <quirin.gylstorff@siemens.com>,
	Christian Storm <christian.storm@siemens.com>
Subject: [isar-cip-core][PATCH v2 08/13] efibootguard: Fix empty command line case
Date: Thu,  5 May 2022 18:43:24 +0200	[thread overview]
Message-ID: <9e8df37239f072c7cc8e832cb0beccc8025a1f2d.1651769009.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1651769009.git.jan.kiszka@siemens.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

We crash in case of an empty command line with non-unified kernel images
right now. Just avoid cmdline==None, will also make upcoming changes
simpler.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 scripts/lib/wic/plugins/source/efibootguard-boot.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/lib/wic/plugins/source/efibootguard-boot.py b/scripts/lib/wic/plugins/source/efibootguard-boot.py
index 909e629..9267033 100644
--- a/scripts/lib/wic/plugins/source/efibootguard-boot.py
+++ b/scripts/lib/wic/plugins/source/efibootguard-boot.py
@@ -80,7 +80,7 @@ class EfibootguardBootPlugin(SourcePlugin):
 
         boot_files = source_params.get("files", "").split(' ')
         unified_kernel = source_params.get("unified-kernel") or 'y'
-        cmdline = bootloader.append
+        cmdline = bootloader.append or ''
         if unified_kernel == 'y':
             boot_image = cls._create_unified_kernel_image(rootfs_dir,
                                                           cr_workdir,
@@ -113,7 +113,7 @@ class EfibootguardBootPlugin(SourcePlugin):
             % (
                 part.label.upper(),
                 boot_image,
-                '-a "%s"' % cmdline if cmdline else "",
+                '-a "%s"' % cmdline,
                 source_params.get("revision", 1),
                 wdog_timeout
             )
-- 
2.34.1



  parent reply	other threads:[~2022-05-05 16:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05 16:43 [isar-cip-core][PATCH v2 00/13] Fixes and improvements for SWUpdate images, kernel/config update Jan Kiszka
2022-05-05 16:43 ` [isar-cip-core][PATCH v2 01/13] initramfs-etc-overlay-hook: Improve error reporting of script Jan Kiszka
2022-05-05 16:43 ` [isar-cip-core][PATCH v2 02/13] initramfs-etc-overlay-hook: Install overlay module Jan Kiszka
2022-05-05 16:43 ` [isar-cip-core][PATCH v2 03/13] initramfs-abrootfs-hook: Remove obsolete patch Jan Kiszka
2022-05-05 16:43 ` [isar-cip-core][PATCH v2 04/13] Rework secure boot key handling and signing recipes Jan Kiszka
2022-05-05 16:43 ` [isar-cip-core][PATCH v2 05/13] linux-cip: Update cip-kernel-config for QEMU and ipc227e Jan Kiszka
2022-05-05 16:43 ` [isar-cip-core][PATCH v2 06/13] linux-cip: Update to 4.19.239-cip72 and 5.10.112-cip6 Jan Kiszka
2022-05-05 16:43 ` [isar-cip-core][PATCH v2 07/13] efibootguard: Update to 0.11 release Jan Kiszka
2022-05-05 16:43 ` Jan Kiszka [this message]
2022-05-05 16:43 ` [isar-cip-core][PATCH v2 09/13] efibootguard: Use new unified kernel image generation Jan Kiszka
2022-05-05 16:43 ` [isar-cip-core][PATCH v2 10/13] efibootguard: Add support for embedding DTBs into unified kernel images Jan Kiszka
2022-05-05 16:43 ` [isar-cip-core][PATCH v2 11/13] u-boot-qemu-arm64: Add recipe for customized version based on 2022.04 Jan Kiszka
2022-05-05 16:43 ` [isar-cip-core][PATCH v2 12/13] Enable SWUpdate with and w/o secure boot for QEMU arm64 Jan Kiszka
2022-05-05 16:43 ` [isar-cip-core][PATCH v2 13/13] start-qemu.sh: Add support for SWUpdate and secure boot mode to arm64 Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e8df37239f072c7cc8e832cb0beccc8025a1f2d.1651769009.git.jan.kiszka@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=christian.storm@siemens.com \
    --cc=cip-dev@lists.cip-project.org \
    --cc=quirin.gylstorff@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.