All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takuya ASADA <syuu@dokukino.com>
To: ceph-devel@vger.kernel.org
Subject: librados.hpp fix
Date: Tue, 3 Aug 2010 21:21:10 +0900	[thread overview]
Message-ID: <AANLkTi=wtavHtw04KwZRfK2LrWahS6TdmN2nh_phcRJn@mail.gmail.com> (raw)

Hi,

I just realized librados.hpp could compile only if "using namespace
std;" is declared before "#include <rados/librados.hpp>", because
"vector" used without std namespace, and I think it's wrong.
It can fix following patch.

syuu

diff --git a/src/include/librados.hpp b/src/include/librados.hpp
index b0d3622..06fa3b2 100644
--- a/src/include/librados.hpp
+++ b/src/include/librados.hpp
@@ -38,7 +38,7 @@ namespace librados {

   struct SnapContext {
     snap_t seq;
-    vector<snap_t> snaps;
+    std::vector<snap_t> snaps;
   };


@@ -57,7 +57,7 @@ public:
   int lookup_pool(const char *name);

   void set_snap(pool_t pool, snap_t seq);
-  int set_snap_context(pool_t pool, snap_t seq, vector<snap_t>& snaps);
+  int set_snap_context(pool_t pool, snap_t seq, std::vector<snap_t>& snaps);


   int create(pool_t pool, const std::string& oid, bool exclusive);

             reply	other threads:[~2010-08-03 12:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03 12:21 Takuya ASADA [this message]
2010-08-03 16:45 ` librados.hpp fix Sage Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=wtavHtw04KwZRfK2LrWahS6TdmN2nh_phcRJn@mail.gmail.com' \
    --to=syuu@dokukino.com \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.