All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bryan Freed <bfreed@chromium.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org,
	Mandeep Baines <msb@chromium.org>,
	Olof Johansson <olofj@chromium.org>
Subject: [PATCH] i915: Initialize panel timing registers if VBIOS did not.
Date: Thu, 7 Oct 2010 17:05:46 -0700	[thread overview]
Message-ID: <AANLkTimODmDBdYBc=yZqcemRoauOan_Ag7cqRo_V18-Z@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1144 bytes --]

The time between start of the pixel clock and backlight enable is a basic
panel timing constraint.  If the Panel Power On/Off registers are found
to be 0, assume we are booting without VBIOS initialization and set these
registers to something reasonable.

Change-Id: Ibed6cc10d46bf52fd92e0beb25ae3525b5eef99d
Signed-off-by: Bryan Freed <bfreed@chromium.org>
---
 drivers/gpu/drm/i915/intel_bios.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_bios.c
b/drivers/gpu/drm/i915/intel_bios.c
index ad030ff..943bbad 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -505,6 +505,15 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
  /* general features */
  dev_priv->int_tv_support = 1;
  dev_priv->int_crt_support = 1;
+
+ /* Set the Panel Power On/Off timings if uninitialized. */
+ if ((I915_READ(PP_ON_DELAYS) == 0) && (I915_READ(PP_OFF_DELAYS) == 0)) {
+ /* Set T2 to 40ms and T5 to 200ms */
+ I915_WRITE(PP_ON_DELAYS, 0x019007d0);
+
+ /* Set T3 to 35ms and Tx to 200ms */
+ I915_WRITE(PP_OFF_DELAYS, 0x015e07d0);
+ }
 }

 /**
-- 
1.7.1

[-- Attachment #1.2: Type: text/html, Size: 2181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2010-10-08  0:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08  0:05 Bryan Freed [this message]
2010-10-08  9:58 ` [PATCH] i915: Initialize panel timing registers if VBIOS did not Chris Wilson
2010-10-08 18:35   ` Bryan Freed
2010-10-08 20:11     ` Jim Gettys
2010-10-08 20:28   ` Chris Wilson
2010-10-08 21:17     ` Jesse Barnes
2010-10-13 21:00       ` Olof Johansson
2010-10-14  8:22         ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimODmDBdYBc=yZqcemRoauOan_Ag7cqRo_V18-Z@mail.gmail.com' \
    --to=bfreed@chromium.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=msb@chromium.org \
    --cc=olofj@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.