doubt: inode_t->get_layout_size_increment() is signed.

From: Miguel F Mascarenhas Sousa Filipe <miguel.filipe@gmail.com>
To: ceph-devel@vger.kernel.org
Subject: doubt: inode_t->get_layout_size_increment() is signed.
Date: Tue, 6 Jul 2010 01:16:45 +0100	[thread overview]
Message-ID: <AANLkTingtd5NZClFkNsiuzX3phcFTzCeLw4-MiBt_wA9@mail.gmail.com> (raw)

Hi there,

I'm interested in this project and started now checking out the code
and make it compile...

I got hunting this signed comparison warning:

mds/Locker.cc: In member function ‘bool
Locker::_do_cap_update(CInode*, Capability*, int, snapid_t,
MClientCaps*, MClientCaps*)’:
mds/Locker.cc:1923: warning: comparison between signed and unsigned
integer expressions

that is related with inode_t->get_layout_size_increment() being signed.
This seems like a bug since it returns a size, but since I don't know
the implications of changing this to uint64_t.. I'm asking..

Is this the right fix?
--------

diff --git a/src/mds/mdstypes.h b/src/mds/mdstypes.h
index b7bfd1d..3054610 100644
--- a/src/mds/mdstypes.h
+++ b/src/mds/mdstypes.h
@@ -379,7 +379,7 @@ struct inode_t {

   bool is_truncating() const { return (truncate_pending > 0); }

-  int64_t get_layout_size_increment() {
+  uint64_t get_layout_size_increment() {
     return layout.fl_object_size * layout.fl_stripe_count;
   }

------

Kind regards,

-- 
Miguel Mascarenhas Filipe
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
