All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wischer, Timo (ADITG/ESB)" <twischer@de.adit-jv.com>
To: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: arecord cannot interrupt streaming via CTRL-C when using voc_pcm_wirte()
Date: Mon, 10 Jul 2017 07:47:43 +0000	[thread overview]
Message-ID: <B0FB33DC1499054591F62C0EF1E013D76845AF71@HI2EXCH01.adit-jv.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]

Hi all,

please merge following patch:


>From fb58aa47b8715924667a0a4383ce9a3615378413 Mon Sep 17 00:00:00 2001
From: Srikanth Krishnakar <Srikanth_Krishnakar@mentor.com>
Date: Mon, 19 Dec 2016 14:04:39 +0530
Subject: alsa-utils: interrupt streaming via signal in voc_pcm_write

arecord (alsa-utils v1.1.2) cannot interrupt streaming
via CTRL-C. Fixed the issue by properly handling 'in_aborting'
flag in appropriate functions.

Signed-off-by: Anant Agrawal <Anant_Agrawal@mentor.com>
Signed-off-by: Mikhail Durnev <mikhail_durnev@mentor.com>
Signed-off-by: Srikanth Krishnakar <Srikanth_Krishnakar@mentor.com>
Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>
---
 aplay/aplay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/aplay/aplay.c b/aplay/aplay.c
index 2da7dda..cdaa1a8 100644
--- a/aplay/aplay.c
+++ b/aplay/aplay.c
@@ -2161,7 +2161,7 @@ static ssize_t voc_pcm_write(u_char *data, size_t count)
        ssize_t result = count, r;
        size_t size;

-       while (count > 0) {
+       while (count > 0 && !in_aborting) {
                size = count;
                if (size > chunk_bytes - buffer_pos)
                        size = chunk_bytes - buffer_pos;
--
2.7.4



Best regards

Timo Wischer

Advanced Driver Information Technology GmbH
Software Group I (ADITG/ESB)
Robert-Bosch-Str. 200
31139 Hildesheim
Germany

Tel. +49 5121 49 6938
Fax +49 5121 49 6999
twischer@de.adit-jv.com

ADIT is a joint venture company of Robert Bosch GmbH/Robert Bosch Car Multimedia GmbH and DENSO Corporation
Sitz: Hildesheim, Registergericht: Amtsgericht Hildesheim HRB 3438
Geschäftsführung: Wilhelm Grabow, Ken Yaguchi

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-alsa-utils-interrupt-streaming-via-signal.patch --]
[-- Type: text/x-patch; name="0001-alsa-utils-interrupt-streaming-via-signal.patch", Size: 1107 bytes --]

From fb58aa47b8715924667a0a4383ce9a3615378413 Mon Sep 17 00:00:00 2001
From: Srikanth Krishnakar <Srikanth_Krishnakar@mentor.com>
Date: Mon, 19 Dec 2016 14:04:39 +0530
Subject: alsa-utils: interrupt streaming via signal in voc_pcm_write

aplay/arecord (alsa-utils v1.1.2) cannot interrupt streaming
via CTRL-C. Fixed the issue by properly handling 'in_aborting'
flag in appropriate functions.

Signed-off-by: Anant Agrawal <Anant_Agrawal@mentor.com>
Signed-off-by: Mikhail Durnev <mikhail_durnev@mentor.com>
Signed-off-by: Srikanth Krishnakar <Srikanth_Krishnakar@mentor.com>
Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>
---
 aplay/aplay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/aplay/aplay.c b/aplay/aplay.c
index 2da7dda..cdaa1a8 100644
--- a/aplay/aplay.c
+++ b/aplay/aplay.c
@@ -2161,7 +2161,7 @@ static ssize_t voc_pcm_write(u_char *data, size_t count)
 	ssize_t result = count, r;
 	size_t size;
 
-	while (count > 0) {
+	while (count > 0 && !in_aborting) {
 		size = count;
 		if (size > chunk_bytes - buffer_pos)
 			size = chunk_bytes - buffer_pos;
-- 
2.7.4


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2017-07-10  7:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10  7:47 Wischer, Timo (ADITG/ESB) [this message]
2017-07-10 13:27 ` arecord cannot interrupt streaming via CTRL-C when using voc_pcm_wirte() Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B0FB33DC1499054591F62C0EF1E013D76845AF71@HI2EXCH01.adit-jv.com \
    --to=twischer@de.adit-jv.com \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.