All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hubert Feurstein <h.feurstein@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] atmel_lcdfb: fix usage of wrong registers in suspend/resume
Date: Mon, 06 Jun 2011 13:24:09 +0000	[thread overview]
Message-ID: <BANLkTi=+HnxpEsgA=GCxyTGe2NV_KBXTiA@mail.gmail.com> (raw)
In-Reply-To: <1307350251-5767-1-git-send-email-h.feurstein@gmail.com>

Or it must be this way:
---
diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index 4484c72..c2ceae4 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -1085,7 +1085,7 @@ static int atmel_lcdfb_suspend(struct
platform_device *pdev, pm_message_t mesg)
 	 */
 	lcdc_writel(sinfo, ATMEL_LCDC_IDR, ~0UL);

-	sinfo->saved_lcdcon = lcdc_readl(sinfo, ATMEL_LCDC_CONTRAST_VAL);
+	sinfo->saved_lcdcon = lcdc_readl(sinfo, ATMEL_LCDC_CONTRAST_CTR);
 	lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_CTR, 0);
 	if (sinfo->atmel_lcdfb_power_control)
 		sinfo->atmel_lcdfb_power_control(0);
--
So which solution was originally intended?

Best regards
Hubert

2011/6/6 Hubert Feurstein <h.feurstein@gmail.com>:
> I assume the intention was to set the contrast value to 0 and not
> the contrast control register (in atmel_lcdfb_suspend). And in
> atmel_lcdfb_resume the contrast value should be restored.
>
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  drivers/video/atmel_lcdfb.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index 4484c72..2ed7ec1 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -1086,7 +1086,7 @@ static int atmel_lcdfb_suspend(struct platform_device *pdev, pm_message_t mesg)
>        lcdc_writel(sinfo, ATMEL_LCDC_IDR, ~0UL);
>
>        sinfo->saved_lcdcon = lcdc_readl(sinfo, ATMEL_LCDC_CONTRAST_VAL);
> -       lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_CTR, 0);
> +       lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_VAL, 0);
>        if (sinfo->atmel_lcdfb_power_control)
>                sinfo->atmel_lcdfb_power_control(0);
>
> @@ -1105,7 +1105,7 @@ static int atmel_lcdfb_resume(struct platform_device *pdev)
>        atmel_lcdfb_start(sinfo);
>        if (sinfo->atmel_lcdfb_power_control)
>                sinfo->atmel_lcdfb_power_control(1);
> -       lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_CTR, sinfo->saved_lcdcon);
> +       lcdc_writel(sinfo, ATMEL_LCDC_CONTRAST_VAL, sinfo->saved_lcdcon);
>
>        /* Enable FIFO & DMA errors */
>        lcdc_writel(sinfo, ATMEL_LCDC_IER, ATMEL_LCDC_UFLWI
> --
> 1.7.1
>
>

  reply	other threads:[~2011-06-06 13:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06  8:50 [PATCH] atmel_lcdfb: fix usage of wrong registers in suspend/resume Hubert Feurstein
2011-06-06 13:24 ` Hubert Feurstein [this message]
2012-01-09 15:45 ` Nicolas Ferre
2012-01-09 16:23 ` [PATCH v2] atmel_lcdfb: fix usage of CONTRAST_CTR " Nicolas Ferre
2012-01-09 16:23   ` Nicolas Ferre
2012-01-09 16:46   ` [PATCH v2] atmel_lcdfb: fix usage of CONTRAST_CTR in Jean-Christophe PLAGNIOL-VILLARD
2012-01-09 16:46     ` [PATCH v2] atmel_lcdfb: fix usage of CONTRAST_CTR in suspend/resume Jean-Christophe PLAGNIOL-VILLARD
2012-01-30  5:13   ` Florian Tobias Schandinat
2012-01-30  5:13     ` Florian Tobias Schandinat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=+HnxpEsgA=GCxyTGe2NV_KBXTiA@mail.gmail.com' \
    --to=h.feurstein@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.