From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>
Subject: Re: pull-request: bpf 2022-08-10
Date: Thu, 11 Aug 2022 00:06:52 -0700 [thread overview]
Message-ID: <CAADnVQK589CZN1Q9w8huJqkEyEed+ZMTWqcpA1Rm2CjN3a4XoQ@mail.gmail.com> (raw)
In-Reply-To: <20220810211857.51884269@kernel.org>
On Wed, Aug 10, 2022 at 9:18 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 10 Aug 2022 20:53:57 -0700 Jakub Kicinski wrote:
> > On Wed, 10 Aug 2022 21:06:24 +0200 Daniel Borkmann wrote:
> > > The following pull-request contains BPF updates for your *net* tree.
> >
> > Could you follow up before we send the PR to Linus if this is legit?
> >
> > kernel/bpf/syscall.c:5089:5: warning: no previous prototype for function 'kern_sys_bpf' [-Wmissing-prototypes]
> > int kern_sys_bpf(int cmd, union bpf_attr *attr, unsigned int size)
> > ^
> > kernel/bpf/syscall.c:5089:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > int kern_sys_bpf(int cmd, union bpf_attr *attr, unsigned int size)
>
> Looking at the code it seems intentional, even if questionable.
> I wish BPF didn't have all these W=1 warnings, I always worry
> we'll end up letting an real one in since the CI only compares
> counts and the counts seem to fluctuate.
Yeah. It is intentional.
We used all sorts of hacks to shut up this pointless warning.
Just grep for __diag_ignore_all("-Wmissing-prototypes
in two files already.
Here I've opted for the explicit hack and the comment.
Pushed this fix to bpf tree:
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/commit/?id=4e4588f1c4d2e67c993208f0550ef3fae33abce4
Please consider pulling these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git
next prev parent reply other threads:[~2022-08-11 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 19:06 pull-request: bpf 2022-08-10 Daniel Borkmann
2022-08-11 3:53 ` Jakub Kicinski
2022-08-11 4:18 ` Jakub Kicinski
2022-08-11 7:06 ` Alexei Starovoitov [this message]
2022-08-11 14:54 ` Jakub Kicinski
2022-08-11 5:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQK589CZN1Q9w8huJqkEyEed+ZMTWqcpA1Rm2CjN3a4XoQ@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.