From: Javier Martinez Canillas <martinez.javier@gmail.com> To: Benoit Cousson <b-cousson@ti.com> Cc: Jon Hunter <jon-hunter@ti.com>, Tony Lindgren <tony@atomide.com>, device-tree <devicetree-discuss@lists.ozlabs.org>, linux-omap <linux-omap@vger.kernel.org>, linux-arm <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 0/9] ARM: dts: Various OMAP2+ device-tree updates Date: Thu, 14 Mar 2013 17:02:39 +0100 [thread overview] Message-ID: <CAAwP0s2BW-GTKsS0UpAWiMbRTFyDzgeUmOCw2p0CaB3RDKOnBw@mail.gmail.com> (raw) In-Reply-To: <5141E55E.9040801@ti.com> On Thu, Mar 14, 2013 at 3:57 PM, Benoit Cousson <b-cousson@ti.com> wrote: > Salut Jon, > > On 03/08/2013 06:27 PM, Jon Hunter wrote: >> Various OMAP device-tree updates for PMU, DMA, GPIO, GPMC and boards. >> >> The DMA, PMU and OMAP3430 SDP board changes have been sent before >> individually but re-sending here as a complete series for v3.10. >> >> This is based upon v3.9-rc1 and the OMAP3 GPMC binding from Florian >> Vaussard [1] and OMAP5 DT SPI patch from Felipe Balbi [2]. >> >> [1] https://patchwork.kernel.org/patch/2057111/ > > I've tried to follow the series review, and it seems that Florian was > considering sending some other patches. It is not clear if this is a new > version of the series or some additional patches. > Hi Benoit, According to [1] Jon suggested that it was not necessary to map all the 16MB for the GPMC mapped register address space since in practice is a very small fraction of that size is used. I had the following patch but I did never post it because Jon said that the I/O memory mapping is page-aligned and the minimum page size for ARM is 4KB anyways, so there is no functional difference between using 0x1000 or 0x02d0. But now reading [2] I see that you prefer to do what the documentation said and don't assume any the page size / alignment. [2]: https://patchwork.kernel.org/patch/2239741/ >From 68edff5a102bb8fc81e006738baa456eb69f080a Mon Sep 17 00:00:00 2001 From: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Date: Wed, 27 Feb 2013 02:30:51 +0100 Subject: [PATCH] ARM: dts: OMAP3: reduce GPMC mapped registers address space Currently the OMAP General-Purpose Memory Controller (GPMC) device node maps 16 MB of address space for its hardware registers. This is because the OMAP Technical Reference Manual says that the GPMC module register address space size is 16 MB. But in practice the maximum address offset used by a GPMC register is 0x02d0. So, there is no need to map such a big address space for GPMC regs. This change was suggested by Jon Hunter [1]. [1]: https://patchwork.kernel.org/patch/2057111/ Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/boot/dts/omap3.dtsi | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index 2ddae38..a60eaf1 100644 --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -407,7 +407,7 @@ gpmc: gpmc@6e000000 { compatible = "ti,omap3430-gpmc"; ti,hwmods = "gpmc"; - reg = <0x6e000000 0x1000000>; + reg = <0x6e000000 0x02d0>; interrupts = <20>; gpmc,num-cs = <8>; gpmc,num-waitpins = <4>; -- 1.7.7.6
WARNING: multiple messages have this Message-ID (diff)
From: martinez.javier@gmail.com (Javier Martinez Canillas) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/9] ARM: dts: Various OMAP2+ device-tree updates Date: Thu, 14 Mar 2013 17:02:39 +0100 [thread overview] Message-ID: <CAAwP0s2BW-GTKsS0UpAWiMbRTFyDzgeUmOCw2p0CaB3RDKOnBw@mail.gmail.com> (raw) In-Reply-To: <5141E55E.9040801@ti.com> On Thu, Mar 14, 2013 at 3:57 PM, Benoit Cousson <b-cousson@ti.com> wrote: > Salut Jon, > > On 03/08/2013 06:27 PM, Jon Hunter wrote: >> Various OMAP device-tree updates for PMU, DMA, GPIO, GPMC and boards. >> >> The DMA, PMU and OMAP3430 SDP board changes have been sent before >> individually but re-sending here as a complete series for v3.10. >> >> This is based upon v3.9-rc1 and the OMAP3 GPMC binding from Florian >> Vaussard [1] and OMAP5 DT SPI patch from Felipe Balbi [2]. >> >> [1] https://patchwork.kernel.org/patch/2057111/ > > I've tried to follow the series review, and it seems that Florian was > considering sending some other patches. It is not clear if this is a new > version of the series or some additional patches. > Hi Benoit, According to [1] Jon suggested that it was not necessary to map all the 16MB for the GPMC mapped register address space since in practice is a very small fraction of that size is used. I had the following patch but I did never post it because Jon said that the I/O memory mapping is page-aligned and the minimum page size for ARM is 4KB anyways, so there is no functional difference between using 0x1000 or 0x02d0. But now reading [2] I see that you prefer to do what the documentation said and don't assume any the page size / alignment. [2]: https://patchwork.kernel.org/patch/2239741/ >From 68edff5a102bb8fc81e006738baa456eb69f080a Mon Sep 17 00:00:00 2001 From: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Date: Wed, 27 Feb 2013 02:30:51 +0100 Subject: [PATCH] ARM: dts: OMAP3: reduce GPMC mapped registers address space Currently the OMAP General-Purpose Memory Controller (GPMC) device node maps 16 MB of address space for its hardware registers. This is because the OMAP Technical Reference Manual says that the GPMC module register address space size is 16 MB. But in practice the maximum address offset used by a GPMC register is 0x02d0. So, there is no need to map such a big address space for GPMC regs. This change was suggested by Jon Hunter [1]. [1]: https://patchwork.kernel.org/patch/2057111/ Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/boot/dts/omap3.dtsi | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index 2ddae38..a60eaf1 100644 --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -407,7 +407,7 @@ gpmc: gpmc at 6e000000 { compatible = "ti,omap3430-gpmc"; ti,hwmods = "gpmc"; - reg = <0x6e000000 0x1000000>; + reg = <0x6e000000 0x02d0>; interrupts = <20>; gpmc,num-cs = <8>; gpmc,num-waitpins = <4>; -- 1.7.7.6
next prev parent reply other threads:[~2013-03-14 16:02 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-08 17:27 [PATCH 0/9] ARM: dts: Various OMAP2+ device-tree updates Jon Hunter 2013-03-08 17:27 ` Jon Hunter 2013-03-08 17:27 ` [PATCH 1/9] ARM: OMAP2+: Prepare for device-tree PMU support Jon Hunter 2013-03-08 17:27 ` Jon Hunter 2013-03-08 17:27 ` [PATCH 2/9] ARM: dts: OMAP2+: Add PMU nodes Jon Hunter 2013-03-08 17:27 ` Jon Hunter 2013-03-08 17:27 ` [PATCH 3/9] ARM: dts: OMAP2+: Add SDMA controller bindings and nodes Jon Hunter 2013-03-08 17:27 ` Jon Hunter 2013-03-08 17:27 ` [PATCH 4/9] ARM: dts: OMAP3: Add support for OMAP3430 SDP board Jon Hunter 2013-03-08 17:27 ` Jon Hunter 2013-03-09 2:25 ` Anil Kumar 2013-03-09 2:25 ` Anil Kumar 2013-03-11 17:53 ` Jon Hunter 2013-03-11 17:53 ` Jon Hunter 2013-03-12 2:42 ` Kumar, Anil 2013-03-12 2:42 ` Kumar, Anil 2013-03-12 8:50 ` Javier Martinez Canillas 2013-03-12 8:50 ` Javier Martinez Canillas 2013-03-13 2:50 ` Kumar, Anil 2013-03-13 2:50 ` Kumar, Anil 2013-03-12 21:27 ` Jon Hunter 2013-03-12 21:27 ` Jon Hunter 2013-03-13 2:59 ` Kumar, Anil 2013-03-13 2:59 ` Kumar, Anil 2013-03-11 2:45 ` Anil Kumar 2013-03-11 2:45 ` Anil Kumar 2013-03-11 17:54 ` Jon Hunter 2013-03-11 17:54 ` Jon Hunter 2013-03-08 17:27 ` [PATCH 5/9] ARM: dts: Add GPMC node for OMAP2, OMAP4 and OMAP5 Jon Hunter 2013-03-08 17:27 ` Jon Hunter 2013-03-08 20:25 ` Javier Martinez Canillas 2013-03-08 20:25 ` Javier Martinez Canillas 2013-03-08 21:41 ` Jon Hunter 2013-03-08 21:41 ` Jon Hunter 2013-03-09 1:25 ` Javier Martinez Canillas 2013-03-09 1:25 ` Javier Martinez Canillas 2013-03-09 12:42 ` Ezequiel Garcia 2013-03-09 12:42 ` Ezequiel Garcia 2013-03-11 17:56 ` Jon Hunter 2013-03-11 17:56 ` Jon Hunter 2013-03-14 15:45 ` Benoit Cousson 2013-03-14 15:45 ` Benoit Cousson 2013-03-14 15:50 ` Jon Hunter 2013-03-14 15:50 ` Jon Hunter 2013-03-14 15:57 ` Ezequiel Garcia 2013-03-14 15:57 ` Ezequiel Garcia 2013-03-14 15:58 ` Benoit Cousson 2013-03-14 15:58 ` Benoit Cousson 2013-03-14 16:00 ` Jon Hunter 2013-03-14 16:00 ` Jon Hunter 2013-03-14 16:03 ` Benoit Cousson 2013-03-14 16:03 ` Benoit Cousson 2013-03-08 17:27 ` [PATCH 6/9] ARM: dts: Add OMAP3430 SDP flash memory bindings Jon Hunter 2013-03-08 17:27 ` Jon Hunter 2013-03-08 17:27 ` [PATCH 7/9] ARM: dts: Add OMAP2 gpio bindings Jon Hunter 2013-03-08 17:27 ` Jon Hunter 2013-03-08 17:27 ` [PATCH 8/9] ARM: dts: OMAP3+: Correct gpio #interrupts-cells property Jon Hunter 2013-03-08 17:27 ` Jon Hunter 2013-03-08 17:27 ` [PATCH 9/9] ARM: dts: OMAP3: Add reg and interrupt properties for gpio Jon Hunter 2013-03-08 17:27 ` Jon Hunter 2013-03-14 14:57 ` [PATCH 0/9] ARM: dts: Various OMAP2+ device-tree updates Benoit Cousson 2013-03-14 14:57 ` Benoit Cousson 2013-03-14 15:45 ` Florian Vaussard 2013-03-14 15:45 ` Florian Vaussard 2013-03-14 15:59 ` Jon Hunter 2013-03-14 15:59 ` Jon Hunter 2013-03-14 16:06 ` Benoit Cousson 2013-03-14 16:06 ` Benoit Cousson 2013-03-14 16:02 ` Javier Martinez Canillas [this message] 2013-03-14 16:02 ` Javier Martinez Canillas 2013-03-14 16:04 ` Jon Hunter 2013-03-14 16:04 ` Jon Hunter 2013-03-14 16:08 ` Benoit Cousson 2013-03-14 16:08 ` Benoit Cousson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAwP0s2BW-GTKsS0UpAWiMbRTFyDzgeUmOCw2p0CaB3RDKOnBw@mail.gmail.com \ --to=martinez.javier@gmail.com \ --cc=b-cousson@ti.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=jon-hunter@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.