All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalesh Singh <kaleshsingh@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Suren Baghdasaryan <surenb@google.com>,
	Hridya Valsaraju <hridya@google.com>,
	Namhyung Kim <namhyung@kernel.org>,
	"Cc: Android Kernel" <kernel-team@android.com>,
	Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@redhat.com>,
	Shuah Khan <shuah@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Tom Zanussi <zanussi@kernel.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] tracing: Add division and multiplication support for hist triggers
Date: Wed, 20 Oct 2021 08:23:31 -0700	[thread overview]
Message-ID: <CAC_TJve8pEHSvPAWecX9Lx04q7_bWd2izv=5FJLc=3vSKiDnZA@mail.gmail.com> (raw)
In-Reply-To: <20211020111301.0032a43d@gandalf.local.home>

On Wed, Oct 20, 2021 at 8:13 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Wed, 20 Oct 2021 07:54:59 -0700
> Kalesh Singh <kaleshsingh@google.com> wrote:
>
> > Is it worth adding something like this for the multiplication case as well?
>
> No, multiplication is a pretty fast operation, and the added branches to
> test would cause more overhead than what you would save. But, division is a
> very slow operation, and I believe that even with the extra branches it
> would still help.
>
> If we do this, it should be a separate patch anyway, where we can actual do
> measurements to see if there was an improvement, and revert if not.

Sounds good. Thanks for the clarification Steve.

- Kalesh

>
> -- Steve

  reply	other threads:[~2021-10-20 15:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20  1:31 [PATCH v2 0/5] tracing: Extend histogram triggers expression parsing Kalesh Singh
2021-10-20  1:31 ` [PATCH v2 1/5] tracing: Add support for creating hist trigger variables from literal Kalesh Singh
2021-10-20 15:32   ` Steven Rostedt
2021-10-20 15:55     ` Kalesh Singh
2021-10-20 15:59       ` Steven Rostedt
2021-10-20  1:31 ` [PATCH v2 2/5] tracing: Add division and multiplication support for hist triggers Kalesh Singh
2021-10-20  2:27   ` Steven Rostedt
2021-10-20 14:54     ` Kalesh Singh
2021-10-20 15:13       ` Steven Rostedt
2021-10-20 15:23         ` Kalesh Singh [this message]
2021-10-20  1:31 ` [PATCH v2 3/5] tracing: Fix operator precedence for hist triggers expression Kalesh Singh
2021-10-20 14:28   ` Steven Rostedt
2021-10-20 15:06     ` Kalesh Singh
2021-10-20 15:13       ` Steven Rostedt
2021-10-20 15:48   ` Steven Rostedt
2021-10-20 16:11     ` Kalesh Singh
2021-10-20 16:19       ` Steven Rostedt
2021-10-20 16:22     ` Kalesh Singh
2021-10-20  1:31 ` [PATCH v2 4/5] tracing/selftests: Add tests for hist trigger expression parsing Kalesh Singh
2021-10-20  1:31 ` [PATCH v2 5/5] tracing/histogram: Document expression arithmetic and constants Kalesh Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAC_TJve8pEHSvPAWecX9Lx04q7_bWd2izv=5FJLc=3vSKiDnZA@mail.gmail.com' \
    --to=kaleshsingh@google.com \
    --cc=corbet@lwn.net \
    --cc=hridya@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=zanussi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.