All of lore.kernel.org
 help / color / mirror / Atom feed
From: anders.roxell at linaro.org (Anders Roxell)
Subject: kselftest-merge misses config's to merge
Date: Fri, 10 Aug 2018 10:50:26 +0200	[thread overview]
Message-ID: <CADYN=9KTA0LeczLnY8kxyrCtm2umPX0ODsmVEhBbBTY4MfUP0A@mail.gmail.com> (raw)

Hi,

I have a question about the config files in tools/testing/selftests/ .
The kselftest-merge target in the root Makefile assumes that the
config files are placed in
tools/testing/selftests/*/config and selftests/android/ion/config and
selftests/net/forwarding/config doesn't follow that. So either we move
those files up a level or do something like below in the top Makefile.

diff --git a/Makefile b/Makefile
index c88d56de7fda..06aeeca16917 100644
--- a/Makefile
+++ b/Makefile
@@ -1188,12 +1188,13 @@ PHONY += kselftest-clean
 kselftest-clean:
  $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests clean

+KSFT_CONFIGS=$(shell find $(srctree)/tools/testing/selftests/ -type f
-name config)
 PHONY += kselftest-merge
 kselftest-merge:
  $(if $(wildcard $(objtree)/.config),, $(error No .config exists,
config your kernel first!))
  $(Q)$(CONFIG_SHELL) $(srctree)/scripts/kconfig/merge_config.sh \
  -m $(objtree)/.config \
- $(srctree)/tools/testing/selftests/*/config
+ $(KSFT_CONFIGS)
  +$(Q)$(MAKE) -f $(srctree)/Makefile olddefconfig

 # ---------------------------------------------------------------------------


or do you have another way to solve this?

Cheers,
Anders

WARNING: multiple messages have this Message-ID (diff)
From: anders.roxell@linaro.org (Anders Roxell)
Subject: kselftest-merge misses config's to merge
Date: Fri, 10 Aug 2018 10:50:26 +0200	[thread overview]
Message-ID: <CADYN=9KTA0LeczLnY8kxyrCtm2umPX0ODsmVEhBbBTY4MfUP0A@mail.gmail.com> (raw)
Message-ID: <20180810085026.srzLk2aX5uhGsxImYK_cwgXmv4QQYjT3l0P53qBxG4c@z> (raw)

Hi,

I have a question about the config files in tools/testing/selftests/ .
The kselftest-merge target in the root Makefile assumes that the
config files are placed in
tools/testing/selftests/*/config and selftests/android/ion/config and
selftests/net/forwarding/config doesn't follow that. So either we move
those files up a level or do something like below in the top Makefile.

diff --git a/Makefile b/Makefile
index c88d56de7fda..06aeeca16917 100644
--- a/Makefile
+++ b/Makefile
@@ -1188,12 +1188,13 @@ PHONY += kselftest-clean
 kselftest-clean:
  $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests clean

+KSFT_CONFIGS=$(shell find $(srctree)/tools/testing/selftests/ -type f
-name config)
 PHONY += kselftest-merge
 kselftest-merge:
  $(if $(wildcard $(objtree)/.config),, $(error No .config exists,
config your kernel first!))
  $(Q)$(CONFIG_SHELL) $(srctree)/scripts/kconfig/merge_config.sh \
  -m $(objtree)/.config \
- $(srctree)/tools/testing/selftests/*/config
+ $(KSFT_CONFIGS)
  +$(Q)$(MAKE) -f $(srctree)/Makefile olddefconfig

 # ---------------------------------------------------------------------------


or do you have another way to solve this?

Cheers,
Anders

             reply	other threads:[~2018-08-10  8:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10  8:50 anders.roxell [this message]
2018-08-10  8:50 ` kselftest-merge misses config's to merge Anders Roxell
2018-08-17 17:15 ` anders.roxell
2018-08-17 17:15   ` Anders Roxell
2018-08-20 15:01   ` shuah
2018-08-20 15:01     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADYN=9KTA0LeczLnY8kxyrCtm2umPX0ODsmVEhBbBTY4MfUP0A@mail.gmail.com' \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.