From: sudip midya <midya.sudip@gmail.com>
To: xfs@oss.sgi.com, david@fromorbit.com
Subject: [PATCH]remove rcu_lock/unlock around lockless radix_tree_tagged()
Date: Wed, 21 Sep 2016 21:19:51 +0530 [thread overview]
Message-ID: <CADccLx9oHDQLDifPAu+tB7pD6OmHu6Mgt7qtMSNtqrgPRNCVGQ@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1297 bytes --]
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Sudip Midya <midya.sudip@gmail.com>
[-- Attachment #1.2: Type: text/html, Size: 1378 bytes --]
[-- Attachment #2: radix_tree_tagged.patch --]
[-- Type: text/x-patch, Size: 779 bytes --]
commit 0e0ac9d9811add9d3a4892888c50f99f3ff80dd6
Author: Sudip Midya <Sudip.Midya@ap.sony.com>
Date: Wed Sep 21 21:05:42 2016 +0530
mm: remove unnecessary rcu_lock/unlock around radix_tree_tagged.
The function queue_delayed_work is already protected with
interrupts disabled, no need to add the rcu_lock
diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
index fb39a66..887c868 100644
--- a/fs/xfs/xfs_icache.c
+++ b/fs/xfs/xfs_icache.c
@@ -153,12 +153,10 @@ xfs_reclaim_work_queue(
struct xfs_mount *mp)
{
- rcu_read_lock();
if (radix_tree_tagged(&mp->m_perag_tree, XFS_ICI_RECLAIM_TAG)) {
queue_delayed_work(mp->m_reclaim_workqueue, &mp->m_reclaim_work,
msecs_to_jiffies(xfs_syncd_centisecs / 6 * 10));
}
- rcu_read_unlock();
}
/*
[-- Attachment #3: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2016-09-21 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 15:49 sudip midya [this message]
2016-09-25 14:33 ` [PATCH]remove rcu_lock/unlock around lockless radix_tree_tagged() Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADccLx9oHDQLDifPAu+tB7pD6OmHu6Mgt7qtMSNtqrgPRNCVGQ@mail.gmail.com \
--to=midya.sudip@gmail.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.