From: Ganapatrao Kulkarni <gpkulkarni@gmail.com> To: Will Deacon <will.deacon@arm.com> Cc: Bjorn Helgaas <helgaas@kernel.org>, Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-pci@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>, Bjorn Helgaas <bhelgaas@google.com>, Hanjun Guo <hanjun.guo@linaro.org>, Robert Richter <rrichter@cavium.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com> Subject: Re: [PATCH] arm64, pci, numa: Adding helper functions as required by pci Date: Sat, 9 Jan 2016 11:35:17 +0530 [thread overview] Message-ID: <CAFpQJXUaVS7tBqjQ4Dh201yrOWFxa3Bk2q-ZCFtK4mk-te=Q7w@mail.gmail.com> (raw) In-Reply-To: <20160108180638.GF11228@arm.com> On Fri, Jan 8, 2016 at 11:36 PM, Will Deacon <will.deacon@arm.com> wrote: > On Fri, Jan 08, 2016 at 12:01:31PM -0600, Bjorn Helgaas wrote: >> On Tue, Dec 22, 2015 at 04:08:50PM +0530, Ganapatrao Kulkarni wrote: >> > Adding helper functions and necessary code to make >> > pci driver(pci-host-generic) numa aware. >> > >> > This patch is on top of arm64-numa v7. >> > http://www.spinics.net/lists/arm-kernel/msg460813.html >> > >> > Signed-off-by: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com> >> > --- >> > arch/arm64/include/asm/numa.h | 8 +++++--- >> > arch/arm64/kernel/pci.c | 8 ++++++++ >> > drivers/pci/host/pci-host-generic.c | 1 + >> > 3 files changed, 14 insertions(+), 3 deletions(-) >> > >> > diff --git a/arch/arm64/include/asm/numa.h b/arch/arm64/include/asm/numa.h >> > index b8c2a3f..1eca4db 100644 >> > --- a/arch/arm64/include/asm/numa.h >> > +++ b/arch/arm64/include/asm/numa.h >> > @@ -15,9 +15,11 @@ >> > extern int __node_distance(int from, int to); >> > #define node_distance(a, b) __node_distance(a, b) >> > >> > -/* dummy definitions for pci functions */ >> > -#define pcibus_to_node(node) 0 >> > -#define cpumask_of_pcibus(bus) 0 >> > +struct pci_bus; >> > +extern int pcibus_to_node(struct pci_bus *bus); >> > +#define cpumask_of_pcibus(bus) (pcibus_to_node(bus) == -1 ? \ >> > + cpu_all_mask : \ >> > + cpumask_of_node(pcibus_to_node(bus))) >> >> All the arch definitions of cpumask_of_pcibus() are pretty similar; >> could they be made more generic? At the very least, can you drop the >> definition here and use the one in include/asm-generic/topology.h, >> which is identical to what you're defining here? macro cpumask_of_pcibus is defined under #ifndef CONFIG_NUMA in include/asm-generic/topology.h and this macro is defined again for NUMA in respective arch header files. i think moving this macro from ifndef will allow us to use without redefinition. --- a/include/asm-generic/topology.h +++ b/include/asm-generic/topology.h @@ -54,14 +54,14 @@ #define pcibus_to_node(bus) ((void)(bus), -1) #endif +#endif /* CONFIG_NUMA */ + #ifndef cpumask_of_pcibus #define cpumask_of_pcibus(bus) (pcibus_to_node(bus) == -1 ? \ cpu_all_mask : \ cpumask_of_node(pcibus_to_node(bus))) #endif -#endif /* CONFIG_NUMA */ - #if !defined(CONFIG_NUMA) || !defined(CONFIG_HAVE_MEMORYLESS_NODES) #ifndef set_numa_mem i have got below compilation error withour macro defined in arch code. drivers/pci/pci-sysfs.c: In function ‘cpuaffinity_show’: drivers/pci/pci-sysfs.c:114:15: error: implicit declaration of function ‘cpumask_of_pcibus’ [-Werror=implicit-function-declaration] drivers/pci/pci-sysfs.c:114:34: warning: initialization makes pointer from integer without a cast [enabled by default] drivers/pci/pci-sysfs.c: In function ‘cpulistaffinity_show’: drivers/pci/pci-sysfs.c:123:34: warning: initialization makes pointer from integer without a cast [enabled by default] cc1: some warnings being treated as errors i can send this as separate patch( as a fix patch). > > +1 on that. I asked for exactly the same thing in my review of v7: > > http://www.spinics.net/lists/arm-kernel/msg469592.html > > but it looks like I was just ignored. > > Will thanks ganapat
WARNING: multiple messages have this Message-ID (diff)
From: gpkulkarni@gmail.com (Ganapatrao Kulkarni) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm64, pci, numa: Adding helper functions as required by pci Date: Sat, 9 Jan 2016 11:35:17 +0530 [thread overview] Message-ID: <CAFpQJXUaVS7tBqjQ4Dh201yrOWFxa3Bk2q-ZCFtK4mk-te=Q7w@mail.gmail.com> (raw) In-Reply-To: <20160108180638.GF11228@arm.com> On Fri, Jan 8, 2016 at 11:36 PM, Will Deacon <will.deacon@arm.com> wrote: > On Fri, Jan 08, 2016 at 12:01:31PM -0600, Bjorn Helgaas wrote: >> On Tue, Dec 22, 2015 at 04:08:50PM +0530, Ganapatrao Kulkarni wrote: >> > Adding helper functions and necessary code to make >> > pci driver(pci-host-generic) numa aware. >> > >> > This patch is on top of arm64-numa v7. >> > http://www.spinics.net/lists/arm-kernel/msg460813.html >> > >> > Signed-off-by: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com> >> > --- >> > arch/arm64/include/asm/numa.h | 8 +++++--- >> > arch/arm64/kernel/pci.c | 8 ++++++++ >> > drivers/pci/host/pci-host-generic.c | 1 + >> > 3 files changed, 14 insertions(+), 3 deletions(-) >> > >> > diff --git a/arch/arm64/include/asm/numa.h b/arch/arm64/include/asm/numa.h >> > index b8c2a3f..1eca4db 100644 >> > --- a/arch/arm64/include/asm/numa.h >> > +++ b/arch/arm64/include/asm/numa.h >> > @@ -15,9 +15,11 @@ >> > extern int __node_distance(int from, int to); >> > #define node_distance(a, b) __node_distance(a, b) >> > >> > -/* dummy definitions for pci functions */ >> > -#define pcibus_to_node(node) 0 >> > -#define cpumask_of_pcibus(bus) 0 >> > +struct pci_bus; >> > +extern int pcibus_to_node(struct pci_bus *bus); >> > +#define cpumask_of_pcibus(bus) (pcibus_to_node(bus) == -1 ? \ >> > + cpu_all_mask : \ >> > + cpumask_of_node(pcibus_to_node(bus))) >> >> All the arch definitions of cpumask_of_pcibus() are pretty similar; >> could they be made more generic? At the very least, can you drop the >> definition here and use the one in include/asm-generic/topology.h, >> which is identical to what you're defining here? macro cpumask_of_pcibus is defined under #ifndef CONFIG_NUMA in include/asm-generic/topology.h and this macro is defined again for NUMA in respective arch header files. i think moving this macro from ifndef will allow us to use without redefinition. --- a/include/asm-generic/topology.h +++ b/include/asm-generic/topology.h @@ -54,14 +54,14 @@ #define pcibus_to_node(bus) ((void)(bus), -1) #endif +#endif /* CONFIG_NUMA */ + #ifndef cpumask_of_pcibus #define cpumask_of_pcibus(bus) (pcibus_to_node(bus) == -1 ? \ cpu_all_mask : \ cpumask_of_node(pcibus_to_node(bus))) #endif -#endif /* CONFIG_NUMA */ - #if !defined(CONFIG_NUMA) || !defined(CONFIG_HAVE_MEMORYLESS_NODES) #ifndef set_numa_mem i have got below compilation error withour macro defined in arch code. drivers/pci/pci-sysfs.c: In function ?cpuaffinity_show?: drivers/pci/pci-sysfs.c:114:15: error: implicit declaration of function ?cpumask_of_pcibus? [-Werror=implicit-function-declaration] drivers/pci/pci-sysfs.c:114:34: warning: initialization makes pointer from integer without a cast [enabled by default] drivers/pci/pci-sysfs.c: In function ?cpulistaffinity_show?: drivers/pci/pci-sysfs.c:123:34: warning: initialization makes pointer from integer without a cast [enabled by default] cc1: some warnings being treated as errors i can send this as separate patch( as a fix patch). > > +1 on that. I asked for exactly the same thing in my review of v7: > > http://www.spinics.net/lists/arm-kernel/msg469592.html > > but it looks like I was just ignored. > > Will thanks ganapat
next prev parent reply other threads:[~2016-01-09 6:05 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-22 10:38 [PATCH] arm64, pci, numa: Adding helper functions as required by pci Ganapatrao Kulkarni 2015-12-22 10:38 ` Ganapatrao Kulkarni 2016-01-08 18:01 ` Bjorn Helgaas 2016-01-08 18:01 ` Bjorn Helgaas 2016-01-08 18:06 ` Will Deacon 2016-01-08 18:06 ` Will Deacon 2016-01-09 6:05 ` Ganapatrao Kulkarni [this message] 2016-01-09 6:05 ` Ganapatrao Kulkarni 2016-01-09 6:05 ` Ganapatrao Kulkarni 2016-01-09 15:24 ` Bjorn Helgaas 2016-01-09 15:24 ` Bjorn Helgaas 2016-01-09 15:24 ` Bjorn Helgaas 2016-01-09 15:35 ` Ganapatrao Kulkarni 2016-01-09 15:35 ` Ganapatrao Kulkarni 2016-01-09 15:35 ` Ganapatrao Kulkarni 2016-01-11 17:12 ` Matthias Brugger 2016-01-11 17:12 ` Matthias Brugger 2016-01-11 17:12 ` Matthias Brugger 2016-01-11 17:26 ` Ganapatrao Kulkarni 2016-01-11 17:26 ` Ganapatrao Kulkarni 2016-01-11 17:26 ` Ganapatrao Kulkarni 2016-01-15 23:38 ` Bjorn Helgaas 2016-01-15 23:38 ` Bjorn Helgaas 2016-01-15 23:38 ` Bjorn Helgaas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAFpQJXUaVS7tBqjQ4Dh201yrOWFxa3Bk2q-ZCFtK4mk-te=Q7w@mail.gmail.com' \ --to=gpkulkarni@gmail.com \ --cc=Prasun.Kapoor@caviumnetworks.com \ --cc=bhelgaas@google.com \ --cc=catalin.marinas@arm.com \ --cc=gkulkarni@caviumnetworks.com \ --cc=hanjun.guo@linaro.org \ --cc=helgaas@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=rrichter@cavium.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.